Update the validator example for version 5 configuration
This commit is contained in:
@@ -543,11 +543,11 @@ extract:
|
|||||||
module: dnd/scene-descriptions
|
module: dnd/scene-descriptions
|
||||||
retries: 1
|
retries: 1
|
||||||
validators:
|
validators:
|
||||||
- generic/valid_json
|
- module: generic/valid_json
|
||||||
- extract/dnd/scene-descriptions/shape
|
- module: extract/dnd/scene-descriptions/shape
|
||||||
- extract/dnd/scene-descriptions/source_refs
|
- module: extract/dnd/scene-descriptions/source_refs
|
||||||
- generic/valid_json_schema
|
- module: generic/valid_json_schema
|
||||||
- extract/dnd/scene-descriptions/source_relatedness
|
- module: extract/dnd/scene-descriptions/source_relatedness
|
||||||
- module: extract/dnd/scene-descriptions/combat_semantics
|
- module: extract/dnd/scene-descriptions/combat_semantics
|
||||||
retries: 1
|
retries: 1
|
||||||
~~~
|
~~~
|
||||||
|
|||||||
@@ -164,6 +164,9 @@ no credentials, raw YAML, or unescaped terminal controls are added.
|
|||||||
|
|
||||||
## Finding 5 — Finish Current Documentation And Comment Migration
|
## Finding 5 — Finish Current Documentation And Comment Migration
|
||||||
|
|
||||||
|
Status: Addressed. The validator example uses canonical objects and passes
|
||||||
|
production selected-pipeline validation; the loader comment describes current behavior.
|
||||||
|
|
||||||
Priority: P2 for the unusable operator example; P3 for the stale comment.
|
Priority: P2 for the unusable operator example; P3 for the stale comment.
|
||||||
|
|
||||||
`docs/config.md:539` explains how to enable the combat semantic validator,
|
`docs/config.md:539` explains how to enable the combat semantic validator,
|
||||||
@@ -201,3 +204,11 @@ The existing green suite does not cover the failing edge cases above. After
|
|||||||
remediation, add the focused behavioral coverage described per finding, rerun
|
remediation, add the focused behavioral coverage described per finding, rerun
|
||||||
the full checks, and validate the corrected documentation example. No live
|
the full checks, and validate the corrected documentation example. No live
|
||||||
LLM tests are needed.
|
LLM tests are needed.
|
||||||
|
|
||||||
|
### Remediation Verification
|
||||||
|
|
||||||
|
All five findings are addressed. Added load-boundary regressions cover sequence
|
||||||
|
normalization, explicit branch validity, and worker-key presence; CLI tests cover
|
||||||
|
source legends. After these changes, the full Go tests, vet, and build passed,
|
||||||
|
as did production selected-pipeline validation of the corrected documentation
|
||||||
|
snippet and the minimal, complete, and development-profile examples.
|
||||||
|
|||||||
@@ -15,9 +15,8 @@ type LoadOptions struct {
|
|||||||
InvocationDirectory string
|
InvocationDirectory string
|
||||||
}
|
}
|
||||||
|
|
||||||
// loadDocument is the private ConfigKit load boundary under construction.
|
// loadDocument composes and validates a version 5 file with ConfigKit before
|
||||||
// Production commands continue to use the existing version 4 loader until the
|
// runtime conversion, retaining source provenance and frozen inspection output.
|
||||||
// runtime conversion and command wiring are complete.
|
|
||||||
func loadDocument(path string, options LoadOptions) (*configkit.Result[Document], error) {
|
func loadDocument(path string, options LoadOptions) (*configkit.Result[Document], error) {
|
||||||
return loadDocumentWithSource(configkit.File(path), options, true)
|
return loadDocumentWithSource(configkit.File(path), options, true)
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user