From c02eec74dd672531688f6749d72999bc8c57c25b Mon Sep 17 00:00:00 2001 From: Eric Rakestraw Date: Mon, 14 Sep 2026 00:42:35 +0000 Subject: [PATCH] Update the validator example for version 5 configuration --- docs/config.md | 10 +++++----- docs/roadmap/remediation.md | 11 +++++++++++ internal/core/config/load.go | 5 ++--- 3 files changed, 18 insertions(+), 8 deletions(-) diff --git a/docs/config.md b/docs/config.md index b5f172a3..c7df43cb 100644 --- a/docs/config.md +++ b/docs/config.md @@ -543,11 +543,11 @@ extract: module: dnd/scene-descriptions retries: 1 validators: - - generic/valid_json - - extract/dnd/scene-descriptions/shape - - extract/dnd/scene-descriptions/source_refs - - generic/valid_json_schema - - extract/dnd/scene-descriptions/source_relatedness + - module: generic/valid_json + - module: extract/dnd/scene-descriptions/shape + - module: extract/dnd/scene-descriptions/source_refs + - module: generic/valid_json_schema + - module: extract/dnd/scene-descriptions/source_relatedness - module: extract/dnd/scene-descriptions/combat_semantics retries: 1 ~~~ diff --git a/docs/roadmap/remediation.md b/docs/roadmap/remediation.md index 2603e507..596e263f 100644 --- a/docs/roadmap/remediation.md +++ b/docs/roadmap/remediation.md @@ -164,6 +164,9 @@ no credentials, raw YAML, or unescaped terminal controls are added. ## Finding 5 — Finish Current Documentation And Comment Migration +Status: Addressed. The validator example uses canonical objects and passes +production selected-pipeline validation; the loader comment describes current behavior. + Priority: P2 for the unusable operator example; P3 for the stale comment. `docs/config.md:539` explains how to enable the combat semantic validator, @@ -201,3 +204,11 @@ The existing green suite does not cover the failing edge cases above. After remediation, add the focused behavioral coverage described per finding, rerun the full checks, and validate the corrected documentation example. No live LLM tests are needed. + +### Remediation Verification + +All five findings are addressed. Added load-boundary regressions cover sequence +normalization, explicit branch validity, and worker-key presence; CLI tests cover +source legends. After these changes, the full Go tests, vet, and build passed, +as did production selected-pipeline validation of the corrected documentation +snippet and the minimal, complete, and development-profile examples. diff --git a/internal/core/config/load.go b/internal/core/config/load.go index 9f1b6b56..e6088ed7 100644 --- a/internal/core/config/load.go +++ b/internal/core/config/load.go @@ -15,9 +15,8 @@ type LoadOptions struct { InvocationDirectory string } -// loadDocument is the private ConfigKit load boundary under construction. -// Production commands continue to use the existing version 4 loader until the -// runtime conversion and command wiring are complete. +// loadDocument composes and validates a version 5 file with ConfigKit before +// runtime conversion, retaining source provenance and frozen inspection output. func loadDocument(path string, options LoadOptions) (*configkit.Result[Document], error) { return loadDocumentWithSource(configkit.File(path), options, true) }