Reuse indexes for D&D citation validation

This commit is contained in:
2026-07-25 12:53:48 +00:00
parent 9d1356a20e
commit 7a66095912
7 changed files with 55 additions and 21 deletions

View File

@@ -37,10 +37,14 @@ func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationReq
if combatshape.Validate(req.Value) != nil {
return contracts.ValidationResult{Approved: true}, nil
}
resolver, err := shared.NewCitationResolver(req.Source)
if err != nil {
return contracts.ValidationResult{Approved: true}, nil
}
citedTexts := make([]string, len(req.Value.CombatTurns))
for turnIndex, turn := range req.Value.CombatTurns {
citedText, err := shared.CitedText(req.Source, turn.SourceRefs)
citedText, err := resolver.CitedText(turn.SourceRefs)
if err != nil {
return contracts.ValidationResult{Approved: true}, nil
}

View File

@@ -39,9 +39,13 @@ func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationReq
if interactionshape.Validate(req.Value) != nil {
return contracts.ValidationResult{Approved: true}, nil
}
resolver, err := shared.NewCitationResolver(req.Source)
if err != nil {
return contracts.ValidationResult{Approved: true}, nil
}
citedTexts := make([]string, len(req.Value.Interactions))
for index, interaction := range req.Value.Interactions {
citedText, err := shared.CitedText(req.Source, interaction.SourceRefs)
citedText, err := resolver.CitedText(interaction.SourceRefs)
if err != nil {
return contracts.ValidationResult{Approved: true}, nil
}

View File

@@ -37,9 +37,13 @@ func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationReq
if err := npcshape.Validate(req.Value); err != nil {
return contracts.ValidationResult{Approved: true}, nil
}
resolver, err := shared.NewCitationResolver(req.Source)
if err != nil {
return contracts.ValidationResult{Approved: true}, nil
}
citedTexts := make([]string, len(req.Value.NPCs))
for npcIndex, npc := range req.Value.NPCs {
citedText, err := shared.CitedText(req.Source, npc.SourceRefs)
citedText, err := resolver.CitedText(npc.SourceRefs)
if err != nil {
return contracts.ValidationResult{Approved: true}, nil
}

View File

@@ -48,9 +48,13 @@ func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationReq
if shape.Validate(req.Value) != nil || !sourceRefsValid(req.Source, req.Value) {
return contracts.ValidationResult{Approved: true}, nil
}
resolver, err := shared.NewCitationResolver(req.Source)
if err != nil {
return contracts.ValidationResult{Approved: true}, nil
}
warnings := make([]contracts.Warning, 0)
for index, scene := range req.Value.Scenes {
citedText, err := shared.CitedText(req.Source, []source.SourceRef{scene.SourceRef})
citedText, err := resolver.CitedText([]source.SourceRef{scene.SourceRef})
if err != nil {
return contracts.ValidationResult{Approved: true}, nil
}

View File

@@ -36,9 +36,13 @@ func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationReq
if err := spellshape.Validate(req.Value); err != nil {
return contracts.ValidationResult{Approved: true}, nil
}
resolver, err := shared.NewCitationResolver(req.Source)
if err != nil {
return contracts.ValidationResult{Approved: true}, nil
}
citedTexts := make([]string, len(req.Value.SpellCasts))
for spellIndex, spell := range req.Value.SpellCasts {
citedText, err := shared.CitedText(req.Source, spell.SourceRefs)
citedText, err := resolver.CitedText(spell.SourceRefs)
if err != nil {
return contracts.ValidationResult{Approved: true}, nil
}