Finish stateless execution cleanup

internal/app/app.go

@@ -367,7 +367,7 @@ func RunBatchDetailed(ctx context.Context, req BatchRequest) (*BatchResult, erro
 			result.Reports = append(result.Reports, item)
 		}
 		result.Total = len(result.Reports)
-		batchNotification, _ := notifyBatch(ctx, req.Config, req.Batch, batchRunID(startedAt, req.Batch), startedAt, result, plannedReports, req.Notifier)
+		batchNotification := notifyBatch(ctx, req.Config, req.Batch, batchRunID(startedAt, req.Batch), startedAt, result, plannedReports, req.Notifier)
 		if batchNotification != nil {
 			result.Notification = batchNotification
 		}

internal/app/batch_notification.go

@@ -46,31 +46,31 @@ func batchRunID(startedAt time.Time, batch BatchKind) string {
 	return startedAt.UTC().Format(runIDTimestampLayout) + "_" + string(batch)
 }
 
-func notifyBatch(ctx context.Context, cfg config.Config, batch BatchKind, runID string, startedAt time.Time, result *BatchResult, planned []plannedBatchReport, notifier Notifier) (*BatchNotificationResult, error) {
+func notifyBatch(ctx context.Context, cfg config.Config, batch BatchKind, runID string, startedAt time.Time, result *BatchResult, planned []plannedBatchReport, notifier Notifier) *BatchNotificationResult {
 	if !cfg.Notify.Distributor.Enabled {
-		return nil, nil
+		return nil
 	}
 	if !cfg.Notify.Distributor.Batch.Enabled {
-		return nil, nil
+		return nil
 	}
 	if result == nil {
-		return nil, fmt.Errorf("batch result is required")
+		return failedBatchNotificationResult(batchNotificationRequest{}, fmt.Errorf("batch result is required"))
 	}
 	if result.Failed > 0 {
 		return &BatchNotificationResult{
 			Status: "skipped",
 			Reason: "one or more reports failed",
-		}, nil
+		}
 	}
 
 	req, err := buildBatchNotificationRequest(cfg, batch, runID, startedAt, result.Reports, planned)
 	if err != nil {
-		return failedBatchNotificationResult(batchNotificationRequest{}, err), err
+		return failedBatchNotificationResult(batchNotificationRequest{}, err)
 	}
 
 	batchNotifier, err := resolveBatchNotifier(cfg, notifier)
 	if err != nil {
-		return failedBatchNotificationResult(req, err), err
+		return failedBatchNotificationResult(req, err)
 	}
 
 	notification, notifyErr := batchNotifier.NotifyBatch(ctx, req)
@@ -82,9 +82,9 @@ func notifyBatch(ctx context.Context, cfg config.Config, batch BatchKind, runID
 	if wrappedErr != nil {
 		batchResult.Status = "failed"
 		batchResult.Error = wrappedErr.Error()
-		return batchResult, wrappedErr
+		return batchResult
 	}
-	return batchResult, nil
+	return batchResult
 }
 
 func resolveBatchNotifier(cfg config.Config, notifier Notifier) (batchNotifier, error) {