Clean up and normalize prompt output modules
This commit is contained in:
@@ -42,7 +42,7 @@ plan.
|
||||
- Do not depend on `/outlooks/convective/active` or
|
||||
`/outlooks/convective/location` for initial behavior.
|
||||
- Include SPC discussion text only when at least one retained report-period
|
||||
outlook has `severity_rank >= 3`.
|
||||
categorical outlook has `severity_rank >= 3`.
|
||||
- Define the discussion threshold as an internal constant, initially `3`, not a
|
||||
config field.
|
||||
|
||||
@@ -305,13 +305,10 @@ Implementation:
|
||||
- `outlook_type`;
|
||||
- `label`;
|
||||
- `label_text`;
|
||||
- `severity_rank`;
|
||||
- `valid_start`;
|
||||
- `valid_end`;
|
||||
- `period_begins`;
|
||||
- `period_ends`;
|
||||
- `issued_at`;
|
||||
- `expires_at`;
|
||||
- `contains_location`;
|
||||
- `source_url`;
|
||||
- `image_url`.
|
||||
- Use human-readable local time helpers consistent with current modules.
|
||||
- Do not emit GeoJSON geometry.
|
||||
@@ -359,22 +356,25 @@ Implementation:
|
||||
- Define a package-private constant near the module, for example:
|
||||
`defaultSPCConvectiveDiscussionMinimumSeverityRank = 3`.
|
||||
- Build from derived retained outlooks and discussions.
|
||||
- Include discussion text only when at least one retained outlook has
|
||||
- Include discussion text only when at least one retained categorical outlook
|
||||
has
|
||||
`severityRank >= defaultSPCConvectiveDiscussionMinimumSeverityRank`.
|
||||
- When the threshold is not met, return `nil` output so the stanza is omitted.
|
||||
- When threshold is met, include discussions for retained outlook days with:
|
||||
- `day`;
|
||||
- `period_begins`;
|
||||
- `period_ends`;
|
||||
- `headline`;
|
||||
- `summary`;
|
||||
- `discussion`;
|
||||
- `updated_at`.
|
||||
- Include a concise reason field such as:
|
||||
`included_because: "severity_rank >= 3"`.
|
||||
`included_because: "categorical severity_rank >= 3"`.
|
||||
|
||||
Acceptance criteria:
|
||||
|
||||
- Slight Risk or higher retained outlooks include matching discussion records
|
||||
when available.
|
||||
- Slight Risk or higher retained categorical outlooks include matching
|
||||
discussion records when available.
|
||||
- Lower-risk retained outlooks still appear in `spc_convective_outlooks` but
|
||||
do not emit `spc_convective_discussion`.
|
||||
- Missing discussion text omits the stanza without failing report generation.
|
||||
@@ -542,7 +542,8 @@ Manual review:
|
||||
- Confirm no module builder performs Weather API calls.
|
||||
- Confirm prompt YAML omits GeoJSON geometry.
|
||||
- Confirm checked-empty outlook data is not represented as missing data.
|
||||
- Confirm SPC discussion text appears only at severity rank `3` or higher.
|
||||
- Confirm SPC discussion text appears only for categorical outlooks at severity
|
||||
rank `3` or higher.
|
||||
- Confirm public CLI syntax, output paths, distributor upload behavior, and
|
||||
Scriptorium argv remain unchanged.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user