eric/weatherreporter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Retire unused weather bundle persistence helpers

Browse Source
This commit is contained in:
Eric Rakestraw
2026-08-13 04:12:38 +00:00
parent 7884b9a6c3
commit c3ebf06bd5
4 changed files with 0 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/adapters/weatherapi/client.go
View File

@@ -19,7 +19,6 @@ import (
"time" "time"
"gitea.maximumdirect.net/eric/weatherreporter/internal/config" "gitea.maximumdirect.net/eric/weatherreporter/internal/config"
"gitea.maximumdirect.net/eric/weatherreporter/internal/fileutil"
"gitea.maximumdirect.net/eric/weatherreporter/internal/weatherdata" "gitea.maximumdirect.net/eric/weatherreporter/internal/weatherdata"
) )
@@ -718,10 +717,3 @@ func sourceHash(raw json.RawMessage) (string, error) {
sum := sha256.Sum256(compact.Bytes()) sum := sha256.Sum256(compact.Bytes())
return hex.EncodeToString(sum[:]), nil return hex.EncodeToString(sum[:]), nil
} }
func SaveBundle(path string, bundle *weatherdata.Bundle) error {
if err := fileutil.WriteJSONAtomic(path, bundle); err != nil {
return fmt.Errorf("save bundle: %w", err)
}
return nil
}

21
internal/adapters/weatherapi/client_test.go
View File

@@ -1055,27 +1055,6 @@ func TestHTTPTimeout(t *testing.T) {
} }
} }
func TestSaveBundle(t *testing.T) {
server := fixtureServer(t, nil, nil)
client := newTestClient(t, server.URL+"/", nil)
bundle, err := client.FetchBundle(context.Background())
if err != nil {
t.Fatalf("FetchBundle() error = %v", err)
}
path := filepath.Join(t.TempDir(), "nested", "bundle.json")
if err := SaveBundle(path, bundle); err != nil {
t.Fatalf("SaveBundle() error = %v", err)
}
data, err := os.ReadFile(path)
if err != nil {
t.Fatalf("read saved bundle: %v", err)
}
if !strings.Contains(string(data), `"hourly"`) {
t.Fatalf("saved bundle missing hourly source:\n%s", string(data))
}
}
type handlerOverride struct { type handlerOverride struct {
status int status int
body string body string

9
internal/fileutil/fileutil.go
View File

@@ -3,7 +3,6 @@ package fileutil
import ( import (
"context" "context"
"encoding/json"
"fmt" "fmt"
"os" "os"
"path/filepath" "path/filepath"
@@ -74,11 +73,3 @@ func WriteFileAtomicContext(ctx context.Context, path string, data []byte) error
} }
return nil return nil
} }
func WriteJSONAtomic(path string, value any) error {
data, err := json.MarshalIndent(value, "", " ")
if err != nil {
return fmt.Errorf("marshal %q: %w", path, err)
}
return WriteFileAtomic(path, data)
}

16
internal/fileutil/fileutil_test.go
View File

@@ -150,19 +150,3 @@ func TestWriteFileAtomicContextPreservesDestinationWhenCanceledAtPublication(t *
t.Fatalf("temporary files/error = %v/%v", matches, globErr) t.Fatalf("temporary files/error = %v/%v", matches, globErr)
} }
} }
func TestWriteJSONAtomic(t *testing.T) {
path := filepath.Join(t.TempDir(), "artifact.json")
if err := WriteJSONAtomic(path, map[string]string{"status": "ok"}); err != nil {
t.Fatalf("WriteJSONAtomic() error = %v", err)
}
data, err := os.ReadFile(path)
if err != nil {
t.Fatalf("ReadFile() error = %v", err)
}
if string(data) != "{\n \"status\": \"ok\"\n}" {
t.Fatalf("json = %q, want indented object", data)
}
}