Normalize briefing module options and weather stories

internal/config/config_test.go

@@ -563,6 +563,35 @@ func TestReportModuleOverridesNormalizesConstructedOptionsWithoutMutatingConfig(
 	}
 }
 
+func TestReportModuleOverridesCanonicalizesTypedPointerOptions(t *testing.T) {
+	cfg := Defaults()
+	options := &module.AreaForecastDiscussionOptions{Sections: []string{"short_term"}}
+	cfg.Reports = map[string]ReportConfig{
+		"daily": {
+			DeterministicModules: []ModuleConfigItem{
+				{ID: module.Metadata},
+				{ID: module.AreaForecastDiscussion, Options: options},
+			},
+			deterministicModulesSet: true,
+		},
+	}
+
+	overrides, err := cfg.ReportModuleOverrides()
+	if err != nil {
+		t.Fatalf("ReportModuleOverrides() error = %v", err)
+	}
+	got, ok := overrides[report.Daily][1].Options.(module.AreaForecastDiscussionOptions)
+	if !ok {
+		t.Fatalf("override options type = %T, want AreaForecastDiscussionOptions", overrides[report.Daily][1].Options)
+	}
+	if !reflect.DeepEqual(got, *options) {
+		t.Fatalf("override options = %#v, want %#v", got, *options)
+	}
+	if cfg.Reports["daily"].DeterministicModules[1].Options != options {
+		t.Fatalf("config options = %#v, want original pointer %#v", cfg.Reports["daily"].DeterministicModules[1].Options, options)
+	}
+}
+
 func TestValidateReportModuleAliasesDirectly(t *testing.T) {
 	retiredDailyKey := retiredDailyReportKeyForTest()
 	tests := []struct {

internal/config/reports.go

@@ -180,7 +180,7 @@ func normalizeModuleOptions(registry briefing.ModuleRegistry, id module.ID, raw
 		return nil, fmt.Errorf("module %q does not accept options", id)
 	}
 	if err := definition.ValidateOptions(raw); err == nil {
-		return raw, nil
+		return definition.CanonicalOptions(raw)
 	}
 	optionType := reflect.TypeOf(definition.DefaultOptions)
 	normalized, err := decodeKnownOptions(raw, optionType)