Refactor to separate each module and report into an individual file

internal/report/daily_report.go

@@ -0,0 +1,69 @@
+package report
+
+import (
+	"gitea.maximumdirect.net/eric/weatherreporter/internal/module"
+	"gitea.maximumdirect.net/eric/weatherreporter/internal/timeutil"
+)
+
+func dailyTodayDefinition() Definition {
+	return Definition{
+		ID:                 DailyToday,
+		Name:               "Daily Report",
+		PromptID:           "weather.daily_report",
+		ComparisonStrategy: CompareSameValidDate,
+		ArtifactGroup:      "daily",
+		BatchOutputName:    "daily.md",
+		Generated:          true,
+		CompatiblePriorIDs: []ID{DailyToday, DailyTomorrow},
+		Modules:            dailyTodayModules(),
+		Morning:            true,
+		resolve:            resolveDailyToday,
+	}
+}
+
+func dailyTomorrowDefinition() Definition {
+	return Definition{
+		ID:                 DailyTomorrow,
+		Name:               "Tomorrow Planning Brief",
+		PromptID:           "weather.daily_report",
+		ComparisonStrategy: CompareSameValidDate,
+		ArtifactGroup:      "daily",
+		BatchOutputName:    "tomorrow.md",
+		Generated:          true,
+		CompatiblePriorIDs: []ID{DailyToday, DailyTomorrow},
+		Modules:            dailyTomorrowModules(),
+		Evening:            true,
+		resolve:            resolveDailyTomorrow,
+	}
+}
+
+func dailyTodayModules() []module.ConfigItem {
+	return moduleItems(
+		module.Metadata,
+		module.CurrentConditions,
+		module.DerivedDailySummary,
+		module.DerivedDaypartSummaries,
+		module.PrecipTiming,
+		module.AlertDigest,
+		module.AreaForecastDiscussion,
+		module.WeatherStory,
+		module.OutdoorWindows,
+	)
+}
+
+func dailyTomorrowModules() []module.ConfigItem {
+	items := dailyTodayModules()
+	items = append(items, module.ConfigItem{ID: module.TomorrowPlanning})
+	return items
+}
+
+func resolveDailyToday(req ResolveRequest) (timeutil.Period, error) {
+	if !req.Date.IsZero() {
+		return timeutil.CivilDay(req.Date, req.Location), nil
+	}
+	return timeutil.CivilDay(req.Now, req.Location), nil
+}
+
+func resolveDailyTomorrow(req ResolveRequest) (timeutil.Period, error) {
+	return timeutil.CivilDay(req.Now.In(req.Location).AddDate(0, 0, 1), req.Location), nil
+}

internal/report/period.go

@@ -3,8 +3,6 @@ package report
 import (
 	"fmt"
 	"time"
-
-	"gitea.maximumdirect.net/eric/weatherreporter/internal/timeutil"
 )
 
 func Resolve(id ID, req ResolveRequest) (Resolved, error) {
@@ -70,75 +68,3 @@ func (r Registry) resolveDefinition(definition Definition, req ResolveRequest) (
 		ValidPeriod: period,
 	}, nil
 }
-
-func resolveDailyToday(req ResolveRequest) (timeutil.Period, error) {
-	if !req.Date.IsZero() {
-		return timeutil.CivilDay(req.Date, req.Location), nil
-	}
-	return timeutil.CivilDay(req.Now, req.Location), nil
-}
-
-func ParseStormPeriod(start string, end string, location *time.Location) (timeutil.Period, error) {
-	if location == nil {
-		location = time.UTC
-	}
-	startTime, err := timeutil.ParseStormTime(start, location)
-	if err != nil {
-		return timeutil.Period{}, err
-	}
-	endTime, err := timeutil.ParseStormTime(end, location)
-	if err != nil {
-		return timeutil.Period{}, err
-	}
-	period := timeutil.Period{Start: startTime, End: endTime}
-	if !period.IsValid() {
-		return timeutil.Period{}, fmt.Errorf("storm report requires end time after start time")
-	}
-	return period, nil
-}
-
-func resolveDailyTomorrow(req ResolveRequest) (timeutil.Period, error) {
-	return timeutil.CivilDay(req.Now.In(req.Location).AddDate(0, 0, 1), req.Location), nil
-}
-
-func resolveThreeDay(req ResolveRequest) (timeutil.Period, error) {
-	localNow := req.Now.In(req.Location)
-	endDate := localNow.AddDate(0, 0, 3)
-	end := time.Date(endDate.Year(), endDate.Month(), endDate.Day(), 0, 0, 0, 0, req.Location)
-	return timeutil.Period{Start: localNow, End: end}, nil
-}
-
-func resolveWeekend(req ResolveRequest) (timeutil.Period, error) {
-	localNow := req.Now.In(req.Location)
-	weekday := localNow.Weekday()
-	if weekday == time.Sunday {
-		return timeutil.Period{}, fmt.Errorf("weekend outlook is not scheduled on Sunday morning")
-	}
-
-	daysUntilSaturday := (int(time.Saturday) - int(weekday) + 7) % 7
-	saturday := localNow.AddDate(0, 0, daysUntilSaturday)
-	start := time.Date(saturday.Year(), saturday.Month(), saturday.Day(), 0, 0, 0, 0, req.Location)
-	if weekday == time.Friday || weekday == time.Saturday {
-		friday := start.AddDate(0, 0, -1)
-		fridayEvening := time.Date(friday.Year(), friday.Month(), friday.Day(), 18, 0, 0, 0, req.Location)
-		start = fridayEvening
-		if localNow.After(start) {
-			start = localNow
-		}
-	}
-	end := time.Date(saturday.Year(), saturday.Month(), saturday.Day(), 0, 0, 0, 0, req.Location).AddDate(0, 0, 2)
-	return timeutil.Period{Start: start, End: end}, nil
-}
-
-func resolveStorm(req ResolveRequest) (timeutil.Period, error) {
-	if req.StormStart.IsZero() {
-		return timeutil.Period{}, fmt.Errorf("storm report requires a start time")
-	}
-	if req.StormEnd.IsZero() {
-		return timeutil.Period{}, fmt.Errorf("storm report requires an end time")
-	}
-	if !req.StormEnd.After(req.StormStart) {
-		return timeutil.Period{}, fmt.Errorf("storm report requires end time after start time")
-	}
-	return timeutil.Period{Start: req.StormStart, End: req.StormEnd}, nil
-}

internal/report/registry.go

@@ -12,70 +12,11 @@ type Registry struct {
 
 func DefaultRegistry() Registry {
 	definitions := []Definition{
-		{
-			ID:                 DailyToday,
-			Name:               "Daily Report",
-			PromptID:           "weather.daily_report",
-			ComparisonStrategy: CompareSameValidDate,
-			ArtifactGroup:      "daily",
-			BatchOutputName:    "daily.md",
-			Generated:          true,
-			CompatiblePriorIDs: []ID{DailyToday, DailyTomorrow},
-			Modules:            dailyTodayModules(),
-			Morning:            true,
-			resolve:            resolveDailyToday,
-		},
-		{
-			ID:                 DailyTomorrow,
-			Name:               "Tomorrow Planning Brief",
-			PromptID:           "weather.daily_report",
-			ComparisonStrategy: CompareSameValidDate,
-			ArtifactGroup:      "daily",
-			BatchOutputName:    "tomorrow.md",
-			Generated:          true,
-			CompatiblePriorIDs: []ID{DailyToday, DailyTomorrow},
-			Modules:            dailyTomorrowModules(),
-			Evening:            true,
-			resolve:            resolveDailyTomorrow,
-		},
-		{
-			ID:                 ThreeDay,
-			Name:               "3-Day Outlook",
-			PromptID:           "weather.three_day_outlook",
-			ComparisonStrategy: CompareSameValidDate,
-			ArtifactGroup:      "three-day",
-			BatchOutputName:    "three-day.md",
-			Generated:          true,
-			CompatiblePriorIDs: []ID{ThreeDay},
-			Modules:            threeDayModules(),
-			Morning:            true,
-			resolve:            resolveThreeDay,
-		},
-		{
-			ID:                 Weekend,
-			Name:               "Weekend Outlook",
-			PromptID:           "weather.weekend_outlook",
-			ComparisonStrategy: CompareWeekendWindow,
-			ArtifactGroup:      "weekend",
-			BatchOutputName:    "weekend.md",
-			Generated:          true,
-			CompatiblePriorIDs: []ID{Weekend},
-			Modules:            weekendModules(),
-			Morning:            true,
-			resolve:            resolveWeekend,
-		},
-		{
-			ID:                 Storm,
-			Name:               "Storm Report",
-			PromptID:           "weather.storm_report",
-			ComparisonStrategy: CompareExplicitWindow,
-			ArtifactGroup:      "storm",
-			BatchOutputName:    "storm.md",
-			Generated:          true,
-			CompatiblePriorIDs: []ID{Storm},
-			Modules:            stormModules(),
-			resolve:            resolveStorm,
-		},
+		dailyTodayDefinition(),
+		dailyTomorrowDefinition(),
+		threeDayDefinition(),
+		weekendDefinition(),
+		stormDefinition(),
 	}
 	registry := Registry{definitions: map[ID]Definition{}}
 	for _, definition := range definitions {
@@ -101,63 +42,6 @@ func (r Registry) WithModuleOverrides(overrides map[ID][]module.ConfigItem) (Reg
 	return next, nil
 }
 
-func dailyTodayModules() []module.ConfigItem {
-	return moduleItems(
-		module.Metadata,
-		module.CurrentConditions,
-		module.DerivedDailySummary,
-		module.DerivedDaypartSummaries,
-		module.PrecipTiming,
-		module.AlertDigest,
-		module.AreaForecastDiscussion,
-		module.WeatherStory,
-		module.OutdoorWindows,
-	)
-}
-
-func dailyTomorrowModules() []module.ConfigItem {
-	items := dailyTodayModules()
-	items = append(items, module.ConfigItem{ID: module.TomorrowPlanning})
-	return items
-}
-
-func threeDayModules() []module.ConfigItem {
-	return moduleItems(
-		module.Metadata,
-		module.CurrentConditions,
-		module.DerivedDaypartSummaries,
-		module.PrecipTiming,
-		module.AlertDigest,
-		module.AreaForecastDiscussion,
-		module.WeatherStory,
-		module.OutdoorWindows,
-	)
-}
-
-func weekendModules() []module.ConfigItem {
-	return moduleItems(
-		module.Metadata,
-		module.CurrentConditions,
-		module.DerivedDaypartSummaries,
-		module.PrecipTiming,
-		module.AlertDigest,
-		module.AreaForecastDiscussion,
-		module.WeatherStory,
-		module.OutdoorWindows,
-	)
-}
-
-func stormModules() []module.ConfigItem {
-	return moduleItems(
-		module.Metadata,
-		module.CurrentConditions,
-		module.PrecipTiming,
-		module.AlertDigest,
-		module.AreaForecastDiscussion,
-		module.WeatherStory,
-	)
-}
-
 func moduleItems(ids ...module.ID) []module.ConfigItem {
 	items := make([]module.ConfigItem, 0, len(ids))
 	for _, id := range ids {

internal/report/storm_report.go

@@ -0,0 +1,67 @@
+package report
+
+import (
+	"fmt"
+	"time"
+
+	"gitea.maximumdirect.net/eric/weatherreporter/internal/module"
+	"gitea.maximumdirect.net/eric/weatherreporter/internal/timeutil"
+)
+
+func stormDefinition() Definition {
+	return Definition{
+		ID:                 Storm,
+		Name:               "Storm Report",
+		PromptID:           "weather.storm_report",
+		ComparisonStrategy: CompareExplicitWindow,
+		ArtifactGroup:      "storm",
+		BatchOutputName:    "storm.md",
+		Generated:          true,
+		CompatiblePriorIDs: []ID{Storm},
+		Modules:            stormModules(),
+		resolve:            resolveStorm,
+	}
+}
+
+func stormModules() []module.ConfigItem {
+	return moduleItems(
+		module.Metadata,
+		module.CurrentConditions,
+		module.PrecipTiming,
+		module.AlertDigest,
+		module.AreaForecastDiscussion,
+		module.WeatherStory,
+	)
+}
+
+func ParseStormPeriod(start string, end string, location *time.Location) (timeutil.Period, error) {
+	if location == nil {
+		location = time.UTC
+	}
+	startTime, err := timeutil.ParseStormTime(start, location)
+	if err != nil {
+		return timeutil.Period{}, err
+	}
+	endTime, err := timeutil.ParseStormTime(end, location)
+	if err != nil {
+		return timeutil.Period{}, err
+	}
+	period := timeutil.Period{Start: startTime, End: endTime}
+	if !period.IsValid() {
+		return timeutil.Period{}, fmt.Errorf("storm report requires end time after start time")
+	}
+	return period, nil
+}
+
+func resolveStorm(req ResolveRequest) (timeutil.Period, error) {
+	if req.StormStart.IsZero() {
+		return timeutil.Period{}, fmt.Errorf("storm report requires a start time")
+	}
+	if req.StormEnd.IsZero() {
+		return timeutil.Period{}, fmt.Errorf("storm report requires an end time")
+	}
+	if !req.StormEnd.After(req.StormStart) {
+		return timeutil.Period{}, fmt.Errorf("storm report requires end time after start time")
+	}
+	return timeutil.Period{Start: req.StormStart, End: req.StormEnd}, nil
+}

internal/report/three_day_report.go

@@ -0,0 +1,44 @@
+package report
+
+import (
+	"time"
+
+	"gitea.maximumdirect.net/eric/weatherreporter/internal/module"
+	"gitea.maximumdirect.net/eric/weatherreporter/internal/timeutil"
+)
+
+func threeDayDefinition() Definition {
+	return Definition{
+		ID:                 ThreeDay,
+		Name:               "3-Day Outlook",
+		PromptID:           "weather.three_day_outlook",
+		ComparisonStrategy: CompareSameValidDate,
+		ArtifactGroup:      "three-day",
+		BatchOutputName:    "three-day.md",
+		Generated:          true,
+		CompatiblePriorIDs: []ID{ThreeDay},
+		Modules:            threeDayModules(),
+		Morning:            true,
+		resolve:            resolveThreeDay,
+	}
+}
+
+func threeDayModules() []module.ConfigItem {
+	return moduleItems(
+		module.Metadata,
+		module.CurrentConditions,
+		module.DerivedDaypartSummaries,
+		module.PrecipTiming,
+		module.AlertDigest,
+		module.AreaForecastDiscussion,
+		module.WeatherStory,
+		module.OutdoorWindows,
+	)
+}
+
+func resolveThreeDay(req ResolveRequest) (timeutil.Period, error) {
+	localNow := req.Now.In(req.Location)
+	endDate := localNow.AddDate(0, 0, 3)
+	end := time.Date(endDate.Year(), endDate.Month(), endDate.Day(), 0, 0, 0, 0, req.Location)
+	return timeutil.Period{Start: localNow, End: end}, nil
+}

internal/report/weekend_report.go

@@ -0,0 +1,60 @@
+package report
+
+import (
+	"fmt"
+	"time"
+
+	"gitea.maximumdirect.net/eric/weatherreporter/internal/module"
+	"gitea.maximumdirect.net/eric/weatherreporter/internal/timeutil"
+)
+
+func weekendDefinition() Definition {
+	return Definition{
+		ID:                 Weekend,
+		Name:               "Weekend Outlook",
+		PromptID:           "weather.weekend_outlook",
+		ComparisonStrategy: CompareWeekendWindow,
+		ArtifactGroup:      "weekend",
+		BatchOutputName:    "weekend.md",
+		Generated:          true,
+		CompatiblePriorIDs: []ID{Weekend},
+		Modules:            weekendModules(),
+		Morning:            true,
+		resolve:            resolveWeekend,
+	}
+}
+
+func weekendModules() []module.ConfigItem {
+	return moduleItems(
+		module.Metadata,
+		module.CurrentConditions,
+		module.DerivedDaypartSummaries,
+		module.PrecipTiming,
+		module.AlertDigest,
+		module.AreaForecastDiscussion,
+		module.WeatherStory,
+		module.OutdoorWindows,
+	)
+}
+
+func resolveWeekend(req ResolveRequest) (timeutil.Period, error) {
+	localNow := req.Now.In(req.Location)
+	weekday := localNow.Weekday()
+	if weekday == time.Sunday {
+		return timeutil.Period{}, fmt.Errorf("weekend outlook is not scheduled on Sunday morning")
+	}
+
+	daysUntilSaturday := (int(time.Saturday) - int(weekday) + 7) % 7
+	saturday := localNow.AddDate(0, 0, daysUntilSaturday)
+	start := time.Date(saturday.Year(), saturday.Month(), saturday.Day(), 0, 0, 0, 0, req.Location)
+	if weekday == time.Friday || weekday == time.Saturday {
+		friday := start.AddDate(0, 0, -1)
+		fridayEvening := time.Date(friday.Year(), friday.Month(), friday.Day(), 18, 0, 0, 0, req.Location)
+		start = fridayEvening
+		if localNow.After(start) {
+			start = localNow
+		}
+	}
+	end := time.Date(saturday.Year(), saturday.Month(), saturday.Day(), 0, 0, 0, 0, req.Location).AddDate(0, 0, 2)
+	return timeutil.Period{Start: start, End: end}, nil
+}