Retire dormant prompt compatibility APIs

internal/promptinput/package.go

@@ -2,12 +2,10 @@
 package promptinput
 
 import (
-	"bytes"
 	"encoding/json"
 	"fmt"
 	"time"
 
-	"gitea.maximumdirect.net/eric/weatherreporter/internal/fileutil"
 	"gitea.maximumdirect.net/eric/weatherreporter/internal/module"
 	"gitea.maximumdirect.net/eric/weatherreporter/internal/report"
 	"gitea.maximumdirect.net/eric/weatherreporter/internal/timeutil"
@@ -210,17 +208,6 @@ func Validate(pkg Package) error {
 	return nil
 }
 
-func Save(path string, pkg Package) error {
-	data, err := MarshalYAML(pkg)
-	if err != nil {
-		return err
-	}
-	if err := fileutil.WriteFileAtomic(path, data); err != nil {
-		return fmt.Errorf("save data package: %w", err)
-	}
-	return nil
-}
-
 func MarshalYAML(pkg Package) ([]byte, error) {
 	if err := Validate(pkg); err != nil {
 		return nil, err
@@ -232,18 +219,6 @@ func MarshalYAML(pkg Package) ([]byte, error) {
 	return data, nil
 }
 
-func LoadYAML(data []byte) (Package, error) {
-	var pkg Package
-	decoder := yaml.NewDecoder(bytes.NewReader(data))
-	if err := decoder.Decode(&pkg); err != nil {
-		return Package{}, fmt.Errorf("decode data package: %w", err)
-	}
-	if err := Validate(pkg); err != nil {
-		return Package{}, err
-	}
-	return pkg, nil
-}
-
 func (b BriefingStanzas) MarshalYAML() (any, error) {
 	node := &yaml.Node{Kind: yaml.MappingNode}
 	categoryNames := map[string][]string{}
@@ -284,58 +259,6 @@ func (b BriefingStanzas) MarshalYAML() (any, error) {
 	return node, nil
 }
 
-func (b *BriefingStanzas) UnmarshalYAML(value *yaml.Node) error {
-	if value.Kind != yaml.MappingNode {
-		return fmt.Errorf("briefing must be a mapping")
-	}
-	values := map[string]any{}
-	order := make([]string, 0, len(value.Content)/2)
-	seen := map[string]struct{}{}
-	seenCategories := map[string]struct{}{}
-	categoryOrder := map[string][]string{}
-	for i := 0; i < len(value.Content); i += 2 {
-		name := value.Content[i].Value
-		if name == metadataStanza {
-			if err := decodeBriefingStanza(value.Content[i+1], name, values, &order, seen); err != nil {
-				return err
-			}
-			continue
-		}
-		if !knownBriefingCategory(name) {
-			return fmt.Errorf("unknown briefing category %q", name)
-		}
-		if _, ok := seenCategories[name]; ok {
-			return fmt.Errorf("duplicate briefing category %q", name)
-		}
-		seenCategories[name] = struct{}{}
-		categoryNode := value.Content[i+1]
-		if categoryNode.Kind != yaml.MappingNode {
-			return fmt.Errorf("briefing category %q must be a mapping", name)
-		}
-		var names []string
-		for j := 0; j < len(categoryNode.Content); j += 2 {
-			stanzaName := categoryNode.Content[j].Value
-			category, ok := briefingStanzaCategories[stanzaName]
-			if !ok {
-				return fmt.Errorf("briefing stanza %q has no prompt-input category", stanzaName)
-			}
-			if category != name {
-				return fmt.Errorf("briefing stanza %q belongs under category %q, not %q", stanzaName, category, name)
-			}
-			if err := decodeBriefingStanza(categoryNode.Content[j+1], stanzaName, values, &names, seen); err != nil {
-				return err
-			}
-		}
-		categoryOrder[name] = names
-	}
-	for _, category := range briefingCategoryOrder {
-		order = append(order, categoryOrder[category]...)
-	}
-	b.Order = order
-	b.Values = values
-	return nil
-}
-
 func (b BriefingStanzas) MarshalJSON() ([]byte, error) {
 	out := map[string]any{}
 	for _, name := range b.Order {
@@ -370,29 +293,6 @@ func appendYAMLMappingValue(node *yaml.Node, name string, value any) error {
 	return nil
 }
 
-func decodeBriefingStanza(node *yaml.Node, name string, values map[string]any, order *[]string, seen map[string]struct{}) error {
-	if _, ok := seen[name]; ok {
-		return fmt.Errorf("duplicate briefing stanza %q", name)
-	}
-	var stanza any
-	if err := node.Decode(&stanza); err != nil {
-		return err
-	}
-	seen[name] = struct{}{}
-	*order = append(*order, name)
-	values[name] = stanza
-	return nil
-}
-
-func knownBriefingCategory(name string) bool {
-	for _, category := range briefingCategoryOrder {
-		if name == category {
-			return true
-		}
-	}
-	return false
-}
-
 func yamlNode(value any) (*yaml.Node, error) {
 	data, err := json.Marshal(value)
 	if err != nil {

internal/promptinput/package_test.go

@@ -271,43 +271,6 @@ func TestMarshalYAMLPlacesSPCConvectiveStanzasInPromptCategories(t *testing.T) {
 		t.Fatalf("YAML output placed SPC convective stanzas in wrong category:\n%s", text)
 	}
 
-	loaded, err := LoadYAML(data)
-	if err != nil {
-		t.Fatalf("LoadYAML() error = %v", err)
-	}
-	if _, ok := loaded.Briefing.Values[string(module.SPCConvectiveOutlooks)]; !ok {
-		t.Fatal("loaded package missing spc_convective_outlooks stanza")
-	}
-	if _, ok := loaded.Briefing.Values[string(module.SPCConvectiveDiscussion)]; !ok {
-		t.Fatal("loaded package missing spc_convective_discussion stanza")
-	}
-}
-
-func TestLoadYAMLRoundTrip(t *testing.T) {
-	pkg, err := Build(validBuildRequest(t))
-	if err != nil {
-		t.Fatalf("Build() error = %v", err)
-	}
-	data, err := MarshalYAML(pkg)
-	if err != nil {
-		t.Fatalf("MarshalYAML() error = %v", err)
-	}
-
-	loaded, err := LoadYAML(data)
-	if err != nil {
-		t.Fatalf("LoadYAML() error = %v", err)
-	}
-
-	if loaded.SchemaVersion != SchemaVersion || loaded.RunID != pkg.RunID {
-		t.Fatalf("loaded package = %#v, want schema and run id", loaded)
-	}
-	wantOrder := []string{"metadata", "alert_digest", "derived_daily_summary", "narrative_forecast", "current_conditions"}
-	if strings.Join(loaded.Briefing.Order, ",") != strings.Join(wantOrder, ",") {
-		t.Fatalf("loaded package order = %#v, want grouped category order %#v", loaded.Briefing.Order, wantOrder)
-	}
-	if got := loaded.Briefing.Values["current_conditions"].(map[string]any)["condition_text"]; got != "Partly cloudy" {
-		t.Fatalf("loaded current_conditions.condition_text = %#v, want Partly cloudy", got)
-	}
 }
 
 func TestMarshalYAMLRejectsUncategorizedStanza(t *testing.T) {
@@ -337,50 +300,6 @@ func TestMarshalYAMLAttributesStanzaSerializationFailures(t *testing.T) {
 	}
 }
 
-func TestLoadYAMLRejectsMisplacedStanza(t *testing.T) {
-	data := []byte(`
-schema_version: weatherreporter.data_package.v4
-run_id: 20260529T100000Z_daily
-report:
-  id: daily
-  prompt_id: weather.daily_generated_text
-  generated_at: 2026-05-29T10:00:00Z
-  timezone: America/Chicago
-  current_local_date: "2026-05-29"
-  valid_period:
-    start: 2026-05-29T05:00:00Z
-    end: 2026-05-30T05:00:00Z
-briefing:
-  metadata:
-    run_id: 20260529T100000Z_daily
-  raw_data:
-    alert_digest:
-      checked: true
-`)
-
-	_, err := LoadYAML(data)
-	if err == nil || !strings.Contains(err.Error(), `briefing stanza "alert_digest" belongs under category "applicable_risk_products"`) {
-		t.Fatalf("LoadYAML() error = %v, want misplaced stanza error", err)
-	}
-}
-
-func TestLoadYAMLRejectsOldSchemaVersion(t *testing.T) {
-	pkg, err := Build(validBuildRequest(t))
-	if err != nil {
-		t.Fatalf("Build() error = %v", err)
-	}
-	data, err := MarshalYAML(pkg)
-	if err != nil {
-		t.Fatalf("MarshalYAML() error = %v", err)
-	}
-	data = []byte(strings.Replace(string(data), "weatherreporter.data_package.v4", "weatherreporter.data_package.v3", 1))
-
-	_, err = LoadYAML(data)
-	if err == nil || !strings.Contains(err.Error(), "schemaVersion must be weatherreporter.data_package.v4") {
-		t.Fatalf("LoadYAML() error = %v, want current schema version error", err)
-	}
-}
-
 func validBuildRequest(t *testing.T) BuildRequest {
 	t.Helper()
 	generatedAt := time.Date(2026, 5, 29, 10, 0, 0, 0, time.UTC)