Validate canonical comparison manifests

internal/comparison/publish_test.go

@@ -138,6 +138,14 @@ func TestRecognizeBundleRejectsUnsafeAndMalformedContents(t *testing.T) {
 				t.Fatal(err)
 			}
 		}},
+		{name: "duplicate manifest field", mutate: func(t *testing.T, directory string) {
+			t.Helper()
+			appendManifestField(t, directory, `"schemaVersion": "weatherreporter.comparison.v1"`)
+		}},
+		{name: "case variant manifest field", mutate: func(t *testing.T, directory string) {
+			t.Helper()
+			appendManifestField(t, directory, `"SchemaVersion": "weatherreporter.comparison.v1"`)
+		}},
 		{name: "traversal report path", mutate: func(t *testing.T, directory string) {
 			t.Helper()
 			path := filepath.Join(directory, ManifestFilename)
@@ -158,6 +166,29 @@ func TestRecognizeBundleRejectsUnsafeAndMalformedContents(t *testing.T) {
 				t.Fatal(err)
 			}
 		}},
+		{name: "noncanonical report path", mutate: func(t *testing.T, directory string) {
+			t.Helper()
+			path := filepath.Join(directory, ManifestFilename)
+			data, err := os.ReadFile(path)
+			if err != nil {
+				t.Fatal(err)
+			}
+			var manifest Manifest
+			if err := json.Unmarshal(data, &manifest); err != nil {
+				t.Fatal(err)
+			}
+			if err := os.Rename(filepath.Join(directory, manifest.Results[0].ReportPath), filepath.Join(directory, "arbitrary.md")); err != nil {
+				t.Fatal(err)
+			}
+			manifest.Results[0].ReportPath = "arbitrary.md"
+			data, err = json.Marshal(manifest)
+			if err != nil {
+				t.Fatal(err)
+			}
+			if err := os.WriteFile(path, data, 0o600); err != nil {
+				t.Fatal(err)
+			}
+		}},
 	}
 
 	for _, test := range tests {
@@ -171,6 +202,19 @@ func TestRecognizeBundleRejectsUnsafeAndMalformedContents(t *testing.T) {
 	}
 }
 
+func appendManifestField(t *testing.T, directory, field string) {
+	t.Helper()
+	path := filepath.Join(directory, ManifestFilename)
+	data, err := os.ReadFile(path)
+	if err != nil {
+		t.Fatal(err)
+	}
+	data = append(data[:len(data)-2], []byte(",\n  "+field+"\n}\n")...)
+	if err := os.WriteFile(path, data, 0o600); err != nil {
+		t.Fatal(err)
+	}
+}
+
 func TestPlanDestinationAcceptsRecognizedReplacement(t *testing.T) {
 	directory := publishTestBundle(t, testBundle())
 	plan, err := PlanDestination(filepath.Dir(directory), directory, true)