Finalize profile comparison implementation

internal/app/comparison_execution.go

@@ -35,7 +35,6 @@ type comparisonProfileOutcome struct {
 	Markdown         []byte
 	LLMDebugPath     string
 	Error            *comparison.SafeError
-	err              error
 }
 
 func executeComparisonProfiles(ctx context.Context, req comparisonExecutionRequest) comparisonExecutionResult {
@@ -100,14 +99,12 @@ func executeComparisonProfile(ctx context.Context, req comparisonExecutionReques
 	outcome.ValidationStatus = execution.ValidationStatus
 	outcome.LLMDebugPath = execution.LLMDebugPath
 	if err != nil {
-		outcome.err = err
 		safe := comparisonSafeExecutionError(err)
 		outcome.Error = &safe
 		return outcome
 	}
 	reportPath, err := comparison.ReportFilename(position, len(req.Inspection.Profiles), profile.ProfileID)
 	if err != nil {
-		outcome.err = err
 		safe := comparison.NewSafeError("application", "derive comparison report filename failed")
 		outcome.Error = &safe
 		return outcome
@@ -133,7 +130,6 @@ func markCanceledComparisonOutcome(outcome *comparisonProfileOutcome, err error)
 	outcome.ValidationStatus = promptexec.ValidationSkipped
 	outcome.ReportPath = ""
 	outcome.Markdown = nil
-	outcome.err = err
 	safe := comparisonSafeExecutionError(err)
 	outcome.Error = &safe
 }

internal/app/comparison_execution_test.go

@@ -73,7 +73,7 @@ func TestExecuteComparisonProfilesContinuesAfterProfileFailure(t *testing.T) {
 		t.Fatalf("outcomes = %#v", result.Outcomes)
 	}
 	failure := result.Outcomes[1]
-	if failure.Error == nil || failure.Error.Category != string(promptexec.Generation) || failure.Error.Message != "execute prompt failed" || failure.err == nil || failure.ReportPath != "" || len(failure.Markdown) != 0 {
+	if failure.Error == nil || failure.Error.Category != string(promptexec.Generation) || failure.Error.Message != "execute prompt failed" || failure.ReportPath != "" || len(failure.Markdown) != 0 {
 		t.Fatalf("failure outcome = %#v", failure)
 	}
 }