Remove completed roadmap cleanup plans

internal/generatedtext/catalog.go

@@ -23,32 +23,32 @@ type validator func([]byte) (any, []byte, error)
 type renderContextBuilder func(report.ID, string, briefing.Metadata, module.Snapshot, facts.CollectedFacts, facts.DerivedFacts, any) (any, error)
 
 type catalogEntry struct {
-	schemaID           string
-	templateID         string
-	validate           validator
-	buildRenderContext renderContextBuilder
+	schemaID             string
+	templateID           string
+	validate             validator
+	renderContextBuilder renderContextBuilder
 }
 
 type Handler struct {
-	reportID           report.ID
-	schemaID           string
-	templateID         string
-	validate           validator
-	buildRenderContext renderContextBuilder
+	reportID             report.ID
+	schemaID             string
+	templateID           string
+	validate             validator
+	renderContextBuilder renderContextBuilder
 }
 
 var catalog = []catalogEntry{
 	{
-		schemaID:           schemaIDHourly,
-		templateID:         templateIDHourly,
-		validate:           validateHourly,
-		buildRenderContext: buildHourlyContext,
+		schemaID:             schemaIDHourly,
+		templateID:           templateIDHourly,
+		validate:             validateHourly,
+		renderContextBuilder: buildHourlyContext,
 	},
 	{
-		schemaID:           schemaIDTomorrow,
-		templateID:         templateIDTomorrow,
-		validate:           validateTomorrow,
-		buildRenderContext: buildTomorrowContext,
+		schemaID:             schemaIDTomorrow,
+		templateID:           templateIDTomorrow,
+		validate:             validateTomorrow,
+		renderContextBuilder: buildTomorrowContext,
 	},
 }
 
@@ -67,11 +67,11 @@ func LookupDefinition(definition report.Definition) (Handler, error) {
 		}
 		if entry.schemaID == definition.GeneratedTextSchemaID && entry.templateID == definition.TemplateID {
 			return Handler{
-				reportID:           definition.ID,
-				schemaID:           entry.schemaID,
-				templateID:         entry.templateID,
-				validate:           entry.validate,
-				buildRenderContext: entry.buildRenderContext,
+				reportID:             definition.ID,
+				schemaID:             entry.schemaID,
+				templateID:           entry.templateID,
+				validate:             entry.validate,
+				renderContextBuilder: entry.renderContextBuilder,
 			}, nil
 		}
 	}
@@ -116,10 +116,10 @@ func (h Handler) Validate(data []byte) (any, []byte, error) {
 }
 
 func (h Handler) BuildRenderContext(metadata briefing.Metadata, snapshot module.Snapshot, collected facts.CollectedFacts, derived facts.DerivedFacts, generated any) (any, error) {
-	if h.buildRenderContext == nil {
+	if h.renderContextBuilder == nil {
 		return nil, fmt.Errorf("render-context builder is not registered for template %q on report %q", h.templateID, h.reportID)
 	}
-	return h.buildRenderContext(h.reportID, h.templateID, metadata, snapshot, collected, derived, generated)
+	return h.renderContextBuilder(h.reportID, h.templateID, metadata, snapshot, collected, derived, generated)
 }
 
 func (h Handler) Render(data any) ([]byte, error) {

internal/generatedtext/catalog_test.go

@@ -26,7 +26,7 @@ func TestCatalogCompleteForGeneratedTextTemplateReports(t *testing.T) {
 			if handler.validate == nil {
 				t.Fatal("validator is nil")
 			}
-			if handler.buildRenderContext == nil {
+			if handler.renderContextBuilder == nil {
 				t.Fatal("render-context builder is nil")
 			}
 			if schema, err := handler.Schema(); err != nil {