Centralize report name resolution

internal/config/config_test.go

@@ -205,6 +205,36 @@ reports:
 	}
 }
 
+func TestLoadReportModuleOverrideAliases(t *testing.T) {
+	path := writeConfig(t, `
+reports:
+  three-day-outlook:
+    deterministic_modules:
+      - metadata
+  weekend_outlook:
+    deterministic_modules:
+      - metadata
+  storm_report:
+    deterministic_modules:
+      - metadata
+`)
+
+	cfg, err := LoadFile(path)
+	if err != nil {
+		t.Fatalf("LoadFile() error = %v", err)
+	}
+	overrides := cfg.ReportModuleOverrides()
+	if len(overrides[report.ThreeDay]) != 1 || overrides[report.ThreeDay][0].ID != module.Metadata {
+		t.Fatalf("three-day alias override = %#v, want metadata override", overrides[report.ThreeDay])
+	}
+	if len(overrides[report.Weekend]) != 1 || overrides[report.Weekend][0].ID != module.Metadata {
+		t.Fatalf("weekend alias override = %#v, want metadata override", overrides[report.Weekend])
+	}
+	if len(overrides[report.Storm]) != 1 || overrides[report.Storm][0].ID != module.Metadata {
+		t.Fatalf("storm alias override = %#v, want metadata override", overrides[report.Storm])
+	}
+}
+
 func TestReportModuleOverrideValidation(t *testing.T) {
 	tests := []struct {
 		name    string
@@ -270,7 +300,7 @@ reports:
     deterministic_modules:
       - metadata
 `,
-			wantErr: "reports.daily_tomorrow is not a known report",
+			wantErr: "reports.daily_tomorrow",
 		},
 		{
 			name: "InvalidOptions",

internal/config/reports.go

@@ -4,7 +4,6 @@ import (
 	"bytes"
 	"fmt"
 	"reflect"
-	"strings"
 
 	"gitea.maximumdirect.net/eric/weatherreporter/internal/briefing"
 	"gitea.maximumdirect.net/eric/weatherreporter/internal/module"
@@ -18,7 +17,7 @@ func (cfg Config) ReportModuleOverrides() map[report.ID][]module.ConfigItem {
 		if !reportCfg.deterministicModulesSet {
 			continue
 		}
-		id, err := reportIDForConfigKey(key)
+		id, err := report.IDForConfigKey(key)
 		if err != nil {
 			continue
 		}
@@ -42,9 +41,9 @@ func normalizeReportModules(cfg *Config) error {
 	reportRegistry := report.DefaultRegistry()
 	seenReports := map[report.ID]string{}
 	for key, reportCfg := range cfg.Reports {
-		reportID, err := reportIDForConfigKey(key)
+		reportID, err := report.IDForConfigKey(key)
 		if err != nil {
-			return err
+			return fmt.Errorf("reports.%s: %w", key, err)
 		}
 		if previous, ok := seenReports[reportID]; ok {
 			return fmt.Errorf("reports.%s duplicates report override %q", key, previous)
@@ -105,23 +104,3 @@ func decodeKnownOptions(raw any, optionType reflect.Type) (any, error) {
 	}
 	return target.Elem().Interface(), nil
 }
-
-func reportIDForConfigKey(key string) (report.ID, error) {
-	normalized := strings.ReplaceAll(strings.TrimSpace(strings.ToLower(key)), "-", "_")
-	switch normalized {
-	case "daily", "daily_today":
-		return report.DailyToday, nil
-	case "tomorrow":
-		return report.Tomorrow, nil
-	case "hourly":
-		return report.Hourly, nil
-	case "three_day", "three_day_outlook":
-		return report.ThreeDay, nil
-	case "weekend", "weekend_outlook":
-		return report.Weekend, nil
-	case "storm", "storm_report":
-		return report.Storm, nil
-	default:
-		return "", fmt.Errorf("reports.%s is not a known report", key)
-	}
-}