Add configurable report module composition

internal/config/config_test.go

@@ -6,6 +6,9 @@ import (
 	"strings"
 	"testing"
 	"time"
+
+	"gitea.maximumdirect.net/eric/weatherreporter/internal/module"
+	"gitea.maximumdirect.net/eric/weatherreporter/internal/report"
 )
 
 func TestDefaults(t *testing.T) {
@@ -116,6 +119,138 @@ func TestLoadMinimalExampleConfig(t *testing.T) {
 	}
 }
 
+func TestLoadReportModuleOverrides(t *testing.T) {
+	path := writeConfig(t, `
+reports:
+  daily:
+    deterministic_modules:
+      - metadata
+      - current_conditions
+      - id: area_forecast_discussion
+        options:
+          sections:
+            - short_term
+`)
+
+	cfg, err := LoadFile(path)
+	if err != nil {
+		t.Fatalf("LoadFile() error = %v", err)
+	}
+	overrides := cfg.ReportModuleOverrides()
+	items := overrides[report.DailyToday]
+	if len(items) != 3 {
+		t.Fatalf("daily override length = %d, want 3", len(items))
+	}
+	if items[0].ID != module.Metadata || items[1].ID != module.CurrentConditions || items[2].ID != module.AreaForecastDiscussion {
+		t.Fatalf("daily override = %#v, want configured module order", items)
+	}
+	options, ok := items[2].Options.(module.AreaForecastDiscussionOptions)
+	if !ok {
+		t.Fatalf("AFD options type = %T, want AreaForecastDiscussionOptions", items[2].Options)
+	}
+	if strings.Join(options.Sections, ",") != "short_term" {
+		t.Fatalf("AFD sections = %#v, want short_term", options.Sections)
+	}
+}
+
+func TestReportModuleOverrideValidation(t *testing.T) {
+	tests := []struct {
+		name    string
+		yaml    string
+		wantErr string
+	}{
+		{
+			name: "UnknownReport",
+			yaml: `
+reports:
+  moon:
+    deterministic_modules:
+      - metadata
+`,
+			wantErr: "reports.moon",
+		},
+		{
+			name: "UnknownModule",
+			yaml: `
+reports:
+  daily:
+    deterministic_modules:
+      - missing_module
+`,
+			wantErr: `unknown module "missing_module"`,
+		},
+		{
+			name: "DuplicateModule",
+			yaml: `
+reports:
+  daily:
+    deterministic_modules:
+      - metadata
+      - metadata
+`,
+			wantErr: `duplicate module "metadata"`,
+		},
+		{
+			name: "IncompatibleModule",
+			yaml: `
+reports:
+  daily:
+    deterministic_modules:
+      - storm_window_summary
+`,
+			wantErr: `not compatible with report "daily_today"`,
+		},
+		{
+			name: "InvalidOptions",
+			yaml: `
+reports:
+  daily:
+    deterministic_modules:
+      - id: metadata
+        options:
+          sections:
+            - short_term
+`,
+			wantErr: "options are invalid",
+		},
+		{
+			name: "DuplicateReportAlias",
+			yaml: `
+reports:
+  daily:
+    deterministic_modules:
+      - metadata
+  daily_today:
+    deterministic_modules:
+      - current_conditions
+`,
+			wantErr: "duplicates report override",
+		},
+		{
+			name: "UnknownReportField",
+			yaml: `
+reports:
+  daily:
+    modules:
+      - metadata
+`,
+			wantErr: `unknown report entry field "modules"`,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			_, err := LoadFile(writeConfig(t, tt.yaml))
+			if err == nil {
+				t.Fatal("LoadFile() error = nil, want validation error")
+			}
+			if !strings.Contains(err.Error(), tt.wantErr) {
+				t.Fatalf("error = %q, want %q", err.Error(), tt.wantErr)
+			}
+		})
+	}
+}
+
 func TestExplicitMissingConfigReturnsError(t *testing.T) {
 	_, err := LoadFile(filepath.Join(t.TempDir(), "missing.yml"))
 	if err == nil {
@@ -126,6 +261,15 @@ func TestExplicitMissingConfigReturnsError(t *testing.T) {
 	}
 }
 
+func writeConfig(t *testing.T, contents string) string {
+	t.Helper()
+	path := filepath.Join(t.TempDir(), "config.yml")
+	if err := os.WriteFile(path, []byte(contents), 0o600); err != nil {
+		t.Fatalf("write config fixture: %v", err)
+	}
+	return path
+}
+
 func TestInvalidConfigProducesActionableError(t *testing.T) {
 	dir := t.TempDir()
 	path := filepath.Join(dir, "config.yml")