Add module contracts and registry validation

internal/report/period_test.go

@@ -6,6 +6,7 @@ import (
 	"testing"
 	"time"
 
+	"gitea.maximumdirect.net/eric/weatherreporter/internal/module"
 	"gitea.maximumdirect.net/eric/weatherreporter/internal/timeutil"
 )
 
@@ -251,6 +252,99 @@ func TestRegistryDefinitionsDeclarePathAndCompatibilityPolicy(t *testing.T) {
 	}
 }
 
+func TestRegistryDefinitionsDeclareDefaultModules(t *testing.T) {
+	tests := []struct {
+		id   ID
+		want []module.ID
+	}{
+		{
+			id: DailyToday,
+			want: []module.ID{
+				module.Metadata,
+				module.CurrentConditions,
+				module.DerivedDailySummary,
+				module.DerivedDaypartSummaries,
+				module.PrecipTiming,
+				module.AlertDigest,
+				module.ForecastDelta,
+				module.AreaForecastDiscussion,
+				module.WeatherStory,
+				module.OutdoorWindows,
+			},
+		},
+		{
+			id: DailyTomorrow,
+			want: []module.ID{
+				module.Metadata,
+				module.CurrentConditions,
+				module.DerivedDailySummary,
+				module.DerivedDaypartSummaries,
+				module.PrecipTiming,
+				module.AlertDigest,
+				module.ForecastDelta,
+				module.AreaForecastDiscussion,
+				module.WeatherStory,
+				module.OutdoorWindows,
+				module.TomorrowPlanning,
+			},
+		},
+		{
+			id: ThreeDay,
+			want: []module.ID{
+				module.Metadata,
+				module.CurrentConditions,
+				module.DerivedDaypartSummaries,
+				module.PrecipTiming,
+				module.AlertDigest,
+				module.ForecastDelta,
+				module.AreaForecastDiscussion,
+				module.WeatherStory,
+				module.OutdoorWindows,
+			},
+		},
+		{
+			id: Weekend,
+			want: []module.ID{
+				module.Metadata,
+				module.CurrentConditions,
+				module.DerivedDaypartSummaries,
+				module.PrecipTiming,
+				module.AlertDigest,
+				module.AreaForecastDiscussion,
+				module.WeatherStory,
+				module.OutdoorWindows,
+				module.WeekendPlanning,
+			},
+		},
+		{
+			id: Storm,
+			want: []module.ID{
+				module.Metadata,
+				module.CurrentConditions,
+				module.HourlyTable,
+				module.PrecipTiming,
+				module.AlertDigest,
+				module.AreaForecastDiscussion,
+				module.WeatherStory,
+				module.StormWindowSummary,
+			},
+		},
+	}
+
+	registry := DefaultRegistry()
+	for _, tt := range tests {
+		t.Run(string(tt.id), func(t *testing.T) {
+			definition, err := registry.Lookup(tt.id)
+			if err != nil {
+				t.Fatalf("Lookup() error = %v", err)
+			}
+			if !reflect.DeepEqual(definition.ModuleIDs(), tt.want) {
+				t.Fatalf("ModuleIDs() = %#v, want %#v", definition.ModuleIDs(), tt.want)
+			}
+		})
+	}
+}
+
 func TestResolvedMetadata(t *testing.T) {
 	location := mustLoadLocation(t)
 	resolved, err := Resolve(DailyToday, ResolveRequest{Now: mustParse("2026-05-29T05:00:00-05:00"), Location: location})