Relaxed CLI requirements when defaults are specified in the profile or application defaults

internal/adapter/http/handler.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"encoding/json"
 	"errors"
-	"fmt"
 	"net/http"
 	"strings"
 
@@ -37,7 +36,7 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 
 	var req runRequestDTO
 	if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
-		writeError(w, http.StatusBadRequest, "invalid_json", fmt.Sprintf("invalid JSON request: %v", err))
+		writeError(w, http.StatusBadRequest, "invalid_json", "invalid JSON request body")
 		return
 	}
 
@@ -79,8 +78,8 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		Model:          model,
 	})
 	if err != nil {
-		status, code := mapRunError(err)
-		writeError(w, status, code, err.Error())
+		status, code, message := mapRunError(err)
+		writeError(w, status, code, message)
 		return
 	}
 
@@ -95,19 +94,33 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		},
 		Validation: mapValidation(res.Validation),
 		Metadata: metadataDTO{
+			RunID:          res.RunID,
 			ProfileID:      res.ProfileID,
 			ProfileVersion: res.ProfileVersion,
+			ProfileHash:    res.ProfileHash,
 			ModelName:      res.ModelName,
 			Endpoint:       res.Endpoint,
-			InputHashes:    res.InputHashes,
-			PromptHash:     res.PromptHash,
+			ModelParams: modelParamsDTO{
+				Endpoint:       res.ModelParams.Endpoint,
+				Model:          res.ModelParams.Model,
+				Temperature:    res.ModelParams.Temperature,
+				MaxTokens:      res.ModelParams.MaxTokens,
+				TopP:           res.ModelParams.TopP,
+				TimeoutSeconds: res.ModelParams.TimeoutSeconds,
+			},
+			InputHashes: res.InputHashes,
+			PromptHash:  res.PromptHash,
 			Usage: tokenUsageDTO{
 				PromptTokens:     res.Usage.PromptTokens,
 				CompletionTokens: res.Usage.CompletionTokens,
 				TotalTokens:      res.Usage.TotalTokens,
 			},
-			StartTime: res.StartTime,
-			EndTime:   res.EndTime,
+			StartTime:          res.StartTime,
+			EndTime:            res.EndTime,
+			DurationMS:         res.Duration.Milliseconds(),
+			ValidationMode:     string(res.Validation.Mode),
+			ValidationStatus:   string(res.Validation.Status),
+			RepairAttemptsUsed: res.Validation.RepairAttempts,
 		},
 		RawModelOutput: res.RawOutput,
 	})
@@ -124,24 +137,24 @@ func mapValidation(v domain.ValidationResult) validationDTO {
 	}
 }
 
-func mapRunError(err error) (int, string) {
+func mapRunError(err error) (int, string, string) {
 	switch {
 	case errors.Is(err, profile.ErrProfileNotFound):
-		return http.StatusNotFound, "profile_not_found"
+		return http.StatusNotFound, "profile_not_found", "profile not found"
 	case errors.Is(err, usecase.ErrInvalidRequest):
-		return http.StatusBadRequest, "invalid_request"
+		return http.StatusBadRequest, "invalid_request", "invalid run request"
 	case errors.Is(err, usecase.ErrProfileLoad):
-		return http.StatusBadRequest, "profile_load_failed"
+		return http.StatusBadRequest, "profile_load_failed", "failed to load profile"
 	case errors.Is(err, usecase.ErrArtifactLoad):
-		return http.StatusBadRequest, "artifact_read_failed"
+		return http.StatusBadRequest, "artifact_read_failed", "failed to read input artifact"
 	case errors.Is(err, usecase.ErrPromptRender):
-		return http.StatusBadRequest, "prompt_render_failed"
+		return http.StatusBadRequest, "prompt_render_failed", "failed to render prompt"
 	case errors.Is(err, usecase.ErrLLMGenerate):
-		return http.StatusBadGateway, "llm_failed"
+		return http.StatusBadGateway, "llm_failed", "model generation request failed"
 	case errors.Is(err, usecase.ErrValidation):
-		return http.StatusInternalServerError, "validation_runtime_failed"
+		return http.StatusInternalServerError, "validation_runtime_failed", "validation runtime failed"
 	default:
-		return http.StatusInternalServerError, "internal_error"
+		return http.StatusInternalServerError, "internal_error", "internal server error"
 	}
 }