Capture prompt requirement metadata and templates

internal/configuration/prompts_test.go

@@ -170,6 +170,113 @@ func TestLoadAcceptsEmptyInlineContentAndRejectsInvalidPromptFields(t *testing.T
 	}
 }
 
+func TestRequirementSnapshotCapturesMetadataPresenceAndNormalizedValues(t *testing.T) {
+	state, err := load(mapping("requirement-metadata", map[string]any{
+		"prompts": map[string]any{"example": map[string]any{"v1": map[string]any{
+			"session_id": "{{.session}}",
+			"inputs": []any{
+				map[string]any{"name": "absent"},
+				map[string]any{"name": "null", "content_type": nil, "description": nil},
+				map[string]any{"name": "empty", "content_type": "", "description": ""},
+				map[string]any{"name": "normalized", "content_type": " text/plain ", "description": "  final text  "},
+			},
+			"messages": []any{map[string]any{"role": "user", "content": "{{input \"absent\"}}"}},
+			"output":   map[string]any{"format": "text", "validation_mode": "basic"},
+		}}},
+	}), nil)
+	if err != nil {
+		var loadError *configkit.LoadError
+		if errors.As(err, &loadError) {
+			t.Fatalf("%v: %+v", err, loadError.Diagnostics())
+		}
+		t.Fatal(err)
+	}
+
+	snapshot, ok := state.GetRequirementSnapshot("example", "v1")
+	if !ok || len(snapshot.Inputs) != 4 || len(snapshot.Templates.Messages) != 1 || snapshot.Templates.Session == nil {
+		t.Fatalf("requirement snapshot was not captured: %+v, %t", snapshot, ok)
+	}
+	for _, index := range []int{0, 1} {
+		if snapshot.Inputs[index].ContentType != nil || snapshot.Inputs[index].Description != nil {
+			t.Errorf("input %q should not have explicit string metadata: %+v", snapshot.Inputs[index].Name, snapshot.Inputs[index])
+		}
+	}
+	if snapshot.Inputs[2].ContentType == nil || *snapshot.Inputs[2].ContentType != "" ||
+		snapshot.Inputs[2].Description == nil || *snapshot.Inputs[2].Description != "" {
+		t.Errorf("explicit empty metadata presence was lost: %+v", snapshot.Inputs[2])
+	}
+	if snapshot.Inputs[3].ContentType == nil || *snapshot.Inputs[3].ContentType != "text/plain" ||
+		snapshot.Inputs[3].Description == nil || *snapshot.Inputs[3].Description != "final text" {
+		t.Errorf("snapshot did not use normalized final metadata: %+v", snapshot.Inputs[3])
+	}
+
+	definition, inspection, err := state.prompt("example", "v1")
+	if err != nil {
+		t.Fatal(err)
+	}
+	if len(definition.Inputs) != 4 || len(inspection.Inputs) != 4 || inspection.Inputs[2].ContentType != "" || inspection.Inputs[2].Description != "" ||
+		inspection.Inputs[3].ContentType != "text/plain" || inspection.Inputs[3].Description != "final text" {
+		t.Fatalf("existing prompt inspection shape or normalized values changed: %+v", inspection)
+	}
+
+	*snapshot.Inputs[2].ContentType = "caller mutation"
+	snapshot.Inputs[3].Name = "caller mutation"
+	snapshot.Templates.Messages[0] = nil
+	again, ok := state.GetRequirementSnapshot("example", "v1")
+	if !ok || *again.Inputs[2].ContentType != "" || again.Inputs[3].Name != "normalized" || again.Templates.Messages[0] == nil {
+		t.Fatalf("snapshot mutation escaped into captured state: %+v, %t", again, ok)
+	}
+	if _, ok := state.GetRequirementSnapshot("example", "V1"); ok {
+		t.Fatal("snapshot lookup unexpectedly changed exact version matching")
+	}
+}
+
+func TestInputMetadataPresenceDoesNotChangePromptHashOrInspection(t *testing.T) {
+	variants := []struct {
+		name   string
+		fields map[string]any
+	}{
+		{name: "absent"},
+		{name: "null", fields: map[string]any{"content_type": nil, "description": nil}},
+		{name: "empty", fields: map[string]any{"content_type": "", "description": ""}},
+	}
+	var expectedHash string
+	for _, variant := range variants {
+		t.Run(variant.name, func(t *testing.T) {
+			input := map[string]any{"name": "document"}
+			for name, value := range variant.fields {
+				input[name] = value
+			}
+			state, err := load(mapping("hash-"+variant.name, map[string]any{
+				"prompts": map[string]any{"same": map[string]any{"v1": map[string]any{
+					"inputs":   []any{input},
+					"messages": []any{map[string]any{"role": "user", "content": "hello"}},
+					"output":   map[string]any{"format": "text", "validation_mode": "basic"},
+				}}},
+			}), nil)
+			if err != nil {
+				var loadError *configkit.LoadError
+				if errors.As(err, &loadError) {
+					t.Fatalf("%v: %+v", err, loadError.Diagnostics())
+				}
+				t.Fatal(err)
+			}
+			_, inspection, err := state.prompt("same", "v1")
+			if err != nil {
+				t.Fatal(err)
+			}
+			if len(inspection.Inputs) != 1 || inspection.Inputs[0].ContentType != "" || inspection.Inputs[0].Description != "" {
+				t.Fatalf("old inspection metadata changed: %+v", inspection.Inputs)
+			}
+			if expectedHash == "" {
+				expectedHash = inspection.PromptHash
+			} else if inspection.PromptHash != expectedHash {
+				t.Fatalf("metadata presence changed the definition hash: got %q, want %q", inspection.PromptHash, expectedHash)
+			}
+		})
+	}
+}
+
 func promptWithFile(name string) map[string]any {
 	return map[string]any{"prompts": map[string]any{"example": map[string]any{"v1": map[string]any{
 		"messages": []any{map[string]any{"role": "user", "content_file": name}},