Clarify shared ownership of namespace views

This commit is contained in:
2026-10-17 13:52:50 +00:00
parent 6fff3d822c
commit 8627c751a4
4 changed files with 31 additions and 10 deletions

View File

@@ -1,6 +1,6 @@
# Configuration Collections Implementation Review Findings
Status: Findings 1–2 completed; Finding 3 open. Review completed 2026-10-17.
Status: all three findings completed 2026-10-17.
Reviewed implementation after `89af2a1` through `0221cd4` against the accepted
[feature roadmap](configuration-collections.md), [implementation plan](implementation.md),
@@ -131,7 +131,7 @@ examples, and `git diff --check`.
## Finding 3: Document Engine Ownership In Terms Of The Shared Assembly
Priority: P3. Status: open.
Priority: P3. Status: completed 2026-10-17.
Location: [Engine GoDoc](../../engine.go), lines 85–101; related
[prepared-handle GoDoc](../../prepared_execution.go) and
@@ -160,6 +160,15 @@ scope-mismatch rejection.
Validation: review the affected GoDoc together. Reuse the passing shared-capacity
and cross-view prepared-handle tests; no new behavior or test matrix is needed.
Completion: Engine, WithNamespaces, PrepareExecution, RunPrepared, and the
prepared-handle GoDoc now distinguish independent constructions from shared
namespace views. They describe shared clients/capacity and handle ownership,
with captured selections unchanged by the invoking view. No runtime behavior
was changed. Reviewed rendered `go doc` output; the existing shared-capacity and
cross-view prepared-handle tests and `git diff --check` passed. The full
race-enabled suite, vet, and offline examples from Finding 2 cover the unchanged
implementation.
## Review Validation
Passed on the reviewed committed tree with `GOWORK=off`: