Report known zero usage when smoke tests do not dispatch

This commit is contained in:
2026-10-13 20:32:24 +00:00
parent 116bd0e39b
commit 5ea6f06a6d
3 changed files with 31 additions and 16 deletions

View File

@@ -1,6 +1,6 @@
# Smoke Test Implementation Review Findings
Status: two findings completed; one open. Review completed 2026-10-13.
Status: all three findings completed 2026-10-13. Review completed 2026-10-13.
Reviewed implementation commits after `8fbd058` through
`2f735aedf9b5dcc98164292db46ae1eab3e15cde`, against the
@@ -101,7 +101,7 @@ passed for the facade, model client, generation, use case, and engine packages.
## Finding 3: Initialize Zero-Dispatch Usage Consistently
Priority: P3. Status: open.
Priority: P3. Status: completed 2026-10-13.
Location: [`SmokeTester.Run`](../../internal/usecase/smoke_tester.go),
lines 52–87, and its early return paths.
@@ -130,6 +130,14 @@ inference and an inapplicable/unsupported operation, reusing accumulator coverag
for arithmetic. Existing coordinator tests already cover correct zero-dispatch
accounting after the generation boundary is entered.
Completion: report finalization now applies the shared zero-attempt accumulator
whenever no attempt was dispatched, replacing scattered early-return assignments.
Unsupported/inapplicable operations and early cancellation return known, complete
zero usage; actual dispatches retain their reported or unknown usage unchanged.
The strengthened orchestration assertions failed before the fix. Final validation
passed with `GOWORK=off`: `go test -race ./...`, `go vet ./...`, the three offline
consumer examples, and `git diff --check`.
## Review Validation
Passed with `GOWORK=off`:
@@ -141,7 +149,8 @@ Passed with `GOWORK=off`:
The three findings were reproduced through the public API using a temporary
external Go program and a controlled HTTP RoundTripper; no live provider was
contacted and no reproduction source was added to the repository. The passing
suite does not currently cover these cases.
suite at the reviewed revision did not cover these cases; the completed
remediations add the corresponding regression coverage.
Both catalogs remain selected at locally validated `v3.20261013.0` candidates.
Their publication and any publication-date re-pinning remain separate release