Avoid redundant smoke report copying
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
# Smoke Test Implementation Review Findings
|
||||
|
||||
Status: Findings 1–3 completed; Finding 4 open. Reviews completed 2026-10-13.
|
||||
Status: All four findings completed 2026-10-13.
|
||||
|
||||
Reviewed implementation commits after `8fbd058` through
|
||||
`2f735aedf9b5dcc98164292db46ae1eab3e15cde`, against the
|
||||
@@ -141,7 +141,7 @@ consumer examples, and `git diff --check`.
|
||||
|
||||
## Finding 4: Consolidate Smoke Report Ownership Copying
|
||||
|
||||
Priority: P3. Status: open. Maintainability/efficiency consolidation candidate.
|
||||
Priority: P3. Status: completed 2026-10-13.
|
||||
|
||||
Follow-up review covers the implementation and remediation commits through
|
||||
`5ea6f06a6d0be32ecb68bc98513f02f29be1cae3`.
|
||||
@@ -197,6 +197,17 @@ Focused ownership tests passed on this revision:
|
||||
'TestSmokeTestConcludedInferenceMismatchHasNilGoErrorAndDetachedValues|TestCloneSmokeTestReportOwnsMutableValues'
|
||||
-count=1`. No implementation was changed during the duplication review.
|
||||
|
||||
Completion: the facade now copies mutable values directly into the public report,
|
||||
without first cloning an intermediate domain report. Provider parameters retain
|
||||
the existing JSON-value copy/error handling and pass through the shared target
|
||||
projection without another copy; credentials remain excluded. Domain cloning
|
||||
continues to serve its separate internal ownership boundary. Focused conversion
|
||||
coverage protects retained source values, independently converted results, nested
|
||||
maps/slices, optional facts/timings, attempts, credential exclusion, and copy errors.
|
||||
Existing public and domain ownership tests remain unchanged. Validation passed
|
||||
with `GOWORK=off`: focused ownership tests, `go test -race ./...`, `go vet ./...`,
|
||||
the three offline consumer examples, and `git diff --check`.
|
||||
|
||||
## Initial Review Validation
|
||||
|
||||
Passed with `GOWORK=off`:
|
||||
|
||||
Reference in New Issue
Block a user