Preserve caller cancellation in HTTP smoke probes

This commit is contained in:
2026-10-13 20:22:06 +00:00
parent 972a103a97
commit 208ff42915
4 changed files with 104 additions and 27 deletions

View File

@@ -1,6 +1,6 @@
# Smoke Test Implementation Review Findings
Status: three open findings. Review completed 2026-10-13.
Status: one finding completed; two open. Review completed 2026-10-13.
Reviewed implementation commits after `8fbd058` through
`2f735aedf9b5dcc98164292db46ae1eab3e15cde`, against the
@@ -16,7 +16,7 @@ below are reporting-correctness gaps, not reasons to redesign the feature.
## Finding 1: Preserve Caller Cancellation Independently Of Body Error Type
Priority: P2. Status: open.
Priority: P2. Status: completed 2026-10-13.
Locations: [`finishHTTP`](../../internal/usecase/smoke_tester.go), lines 355–366,
and [`runOpenRouterKey`](../../internal/usecase/smoke_authentication.go),
@@ -47,6 +47,13 @@ that cancels the caller and returns a non-context I/O error. Its existing fake
returns `context.Canceled`, which masks this defect. Check partial-report and
context identity rather than exact error text; reuse existing timeout coverage.
Completion: HTTP probe failures now check the caller context at the failed-I/O
boundary before classification, preserving partial response evidence even for
opaque transport/body errors. Completed authentication is not revoked when body
closure subsequently cancels the caller. The new regressions failed before the
fix; `GOWORK=off go test -race ./internal/usecase .`, focused use-case vet, and
`git diff --check` passed. Existing configured-timeout coverage remains green.
## Finding 2: Report The Actual Initial Inference Request Destination
Priority: P2. Status: open.