Report actual inference smoke test destinations
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
# Smoke Test Implementation Review Findings
|
||||
|
||||
Status: one finding completed; two open. Review completed 2026-10-13.
|
||||
Status: two findings completed; one open. Review completed 2026-10-13.
|
||||
|
||||
Reviewed implementation commits after `8fbd058` through
|
||||
`2f735aedf9b5dcc98164292db46ae1eab3e15cde`, against the
|
||||
@@ -56,7 +56,7 @@ fix; `GOWORK=off go test -race ./internal/usecase .`, focused use-case vet, and
|
||||
|
||||
## Finding 2: Report The Actual Initial Inference Request Destination
|
||||
|
||||
Priority: P2. Status: open.
|
||||
Priority: P2. Status: completed 2026-10-13.
|
||||
|
||||
Locations: [`recordGenerationEvidence`](../../internal/usecase/smoke_tester.go),
|
||||
lines 240–248, and
|
||||
@@ -91,6 +91,14 @@ that distinguishes the actual completion URL from the last destination. Reuse
|
||||
existing HTTP redirect tests for credential/response attribution mechanics and
|
||||
keep injected-client HTTP destination evidence unknown.
|
||||
|
||||
Completion: built-in generation now passes the frozen prepared request URL
|
||||
through internal generation evidence. Diagnostic target/initial-attempt URLs
|
||||
use that value, while the configured base stays in effective settings and
|
||||
injected inference leaves HTTP destinations unknown. Public GoDoc and the
|
||||
internal generation document describe the corrected behavior. No-redirect,
|
||||
redirect, and injected regressions failed before the fix; race-enabled tests
|
||||
passed for the facade, model client, generation, use case, and engine packages.
|
||||
|
||||
## Finding 3: Initialize Zero-Dispatch Usage Consistently
|
||||
|
||||
Priority: P3. Status: open.
|
||||
|
||||
Reference in New Issue
Block a user