Make GoDoc the public API contract

engine_test.go

@@ -1020,6 +1020,7 @@ func TestPublicErrorsSupportErrorsIs(t *testing.T) {
 		client    promptkit.LLMClient
 		schemaDir string
 		want      error
+		notWant   error
 	}{
 		{
 			name:   "invalid request",
@@ -1028,10 +1029,11 @@ func TestPublicErrorsSupportErrorsIs(t *testing.T) {
 			want:   promptkit.ErrInvalidRequest,
 		},
 		{
-			name:   "prompt not found",
-			req:    promptkit.RunRequest{PromptID: "missing.prompt"},
-			client: &fakeLLMClient{response: &promptkit.GenerateResponse{Content: "ok"}},
-			want:   promptkit.ErrPromptNotFound,
+			name:    "prompt not found",
+			req:     promptkit.RunRequest{PromptID: "missing.prompt"},
+			client:  &fakeLLMClient{response: &promptkit.GenerateResponse{Content: "ok"}},
+			want:    promptkit.ErrPromptNotFound,
+			notWant: promptkit.ErrPromptLoad,
 		},
 		{
 			name: "profile not found",
@@ -1042,8 +1044,9 @@ func TestPublicErrorsSupportErrorsIs(t *testing.T) {
 					"transcript": promptkit.Inline("Rin opens the gate."),
 				},
 			},
-			client: &fakeLLMClient{response: &promptkit.GenerateResponse{Content: "ok"}},
-			want:   promptkit.ErrProfileNotFound,
+			client:  &fakeLLMClient{response: &promptkit.GenerateResponse{Content: "ok"}},
+			want:    promptkit.ErrProfileNotFound,
+			notWant: promptkit.ErrProfileLoad,
 		},
 		{
 			name: "artifact load",
@@ -1114,6 +1117,9 @@ func TestPublicErrorsSupportErrorsIs(t *testing.T) {
 			if !errors.Is(err, tc.want) {
 				t.Fatalf("expected errors.Is(%v), got %v", tc.want, err)
 			}
+			if tc.notWant != nil && errors.Is(err, tc.notWant) {
+				t.Fatalf("did not expect errors.Is(%v), got %v", tc.notWant, err)
+			}
 		})
 	}
 }
@@ -1699,6 +1705,16 @@ func TestEngineRunLayersTransportAndGenerationTimeouts(t *testing.T) {
 			configTimeout:          5 * time.Second,
 			wantRemainingAtRequest: 5 * time.Second,
 		},
+		{
+			name:                   "zero configuration uses ten minute transport default",
+			wantRemainingAtRequest: 10 * time.Minute,
+		},
+		{
+			name:                   "negative configuration uses ten minute transport default",
+			configTimeout:          -2 * time.Second,
+			suppliedClientTimeout:  -3 * time.Second,
+			wantRemainingAtRequest: 10 * time.Minute,
+		},
 		{
 			name:                   "profile deadline is shorter than transport cap",
 			suppliedClientTimeout:  6 * time.Second,