package scenes import ( "context" "encoding/json" "slices" "strings" "testing" "time" "gitea.maximumdirect.net/eric/notarius/internal/framework/llm" "gitea.maximumdirect.net/eric/promptkit" ) func TestPromptAssetsPrepareTranscriptWithInstructionOrdering(t *testing.T) { if !slices.Contains(promptAssetManifest.SharedFiles, "common-dnd-transcript-full.md") { t.Fatalf("shared prompt assets = %#v, want complete-session transcript scope", promptAssetManifest.SharedFiles) } transcript := []byte(`{"sentinel":"scene-transcript"}`) prepared := prepareScenesPrompt(t, transcript, "scene-players", "scene-party", "scene-glossary") if prepared.PromptID != PromptID { t.Fatalf("prompt id = %q, want %q", prepared.PromptID, PromptID) } if prepared.OutputContract.SchemaPath != "dnd_scenes_llm.v1.json" { t.Fatalf("scene output schema path = %q, want private LLM schema", prepared.OutputContract.SchemaPath) } if prepared.Messages[0].Role != "system" || prepared.Messages[1].Role != "user" { t.Fatalf("initial prompt roles = %#v, want system followed by campaign references", prepared.Messages[:2]) } if cache := prepared.Messages[1].CacheControl; cache == nil || cache.Type != promptkit.CacheControlEphemeral { t.Fatalf("campaign-reference cache control = %#v, want ephemeral", cache) } if cache := prepared.Messages[0].CacheControl; cache != nil { t.Fatalf("system cache control = %#v, want nil", cache) } if references := prepared.Messages[1].Content; !strings.Contains(references, "scene-players") || !strings.Contains(references, "scene-party") || !strings.Contains(references, "scene-glossary") { t.Fatalf("reference message = %q, want supplied reference inputs", references) } transcriptIndex := -1 for index, message := range prepared.Messages { if strings.Contains(message.Content, "scene-transcript") { transcriptIndex = index } } if transcriptIndex != len(prepared.Messages)-1 { t.Fatalf("transcript message index = %d, want final message in %#v", transcriptIndex, prepared.Messages) } if cache := prepared.Messages[transcriptIndex].CacheControl; cache == nil || cache.Type != promptkit.CacheControlEphemeral { t.Fatalf("transcript cache control = %#v, want ephemeral", cache) } instructionsIndex := transcriptIndex - 1 if instructionsIndex <= 1 || prepared.Messages[instructionsIndex].CacheControl != nil { t.Fatalf("instruction message = %#v, want uncached message after references and before transcript", prepared.Messages[instructionsIndex]) } for index, message := range prepared.Messages { if index != 1 && (strings.Contains(message.Content, "scene-players") || strings.Contains(message.Content, "scene-party") || strings.Contains(message.Content, "scene-glossary")) { t.Errorf("message %d unexpectedly rendered reference input", index) } if index != transcriptIndex && strings.Contains(message.Content, "scene-transcript") { t.Errorf("message %d unexpectedly rendered transcript input", index) } } } func TestPromptAssetDiagnosticsOmitRawMaterials(t *testing.T) { transcript := []byte(`{"secret":"source text"}`) prepared := prepareScenesPrompt(t, transcript, "private player note", "private party note", "private glossary note") metadata := newChunker(t, &fakeScenesLLMClient{}).ManifestMetadata() payload, err := json.Marshal(map[string]any{ "prepared": map[string]any{ "prompt_id": prepared.PromptID, "prompt_version": prepared.PromptVersion, "prompt_hash": prepared.PromptHash, "rendered_prompt_hash": prepared.RenderedPromptHash, "selected_profile_id": prepared.SelectedProfileID, "output_contract": prepared.OutputContract, "input_hashes": prepared.InputHashes, "effective_model_params": prepared.EffectiveModelParams, }, "manifest": metadata, }) if err != nil { t.Fatalf("marshal diagnostics: %v", err) } diagnostics := string(payload) for _, forbidden := range []string{ "source text", "private player note", "private party note", "private glossary note", `"properties"`, "start_unit_id", } { if strings.Contains(diagnostics, forbidden) { t.Fatalf("diagnostics leaked %q: %s", forbidden, diagnostics) } } if metadata["prompt_id"] != PromptID || metadata["prompt_version"] != ResponseSchemaVersion { t.Fatalf("manifest prompt metadata = %#v", metadata) } if !strings.HasPrefix(metadata["prompt_sha256"].(string), "sha256:") { t.Fatalf("manifest prompt hash = %#v, want sha256-prefixed", metadata["prompt_sha256"]) } } func prepareScenesPrompt(t *testing.T, transcript []byte, players string, party string, glossary string) *promptkit.PreparedRun { t.Helper() registry := llm.NewAssetRegistry() if err := RegisterPromptAssets(registry); err != nil { t.Fatalf("register scene prompt assets: %v", err) } engine := newScenesPromptEngine(t, registry) prepared, err := engine.Prepare(context.Background(), promptkit.RunRequest{ PromptID: PromptID, PromptVersion: ResponseSchemaVersion, ProfileID: "scene-test-profile", Inputs: map[string]promptkit.ArtifactRef{ "transcript": promptkit.InlineWithURI("file:///session.json", string(transcript)), "players": promptkit.Inline(players), "party": promptkit.Inline(party), "glossary": promptkit.Inline(glossary), }, }) if err != nil { t.Fatalf("Prepare() error = %v, want nil", err) } return prepared } func newScenesPromptEngine(t *testing.T, registry *llm.AssetRegistry) *promptkit.Engine { t.Helper() options, err := registry.PromptKitOptions() if err != nil { t.Fatalf("PromptKitOptions() error = %v, want nil", err) } options = append(options, promptkit.WithProfiles(promptkit.OpenAICompatibleProfile(promptkit.OpenAICompatibleProfileConfig{ ID: "scene-test-profile", Endpoint: "http://127.0.0.1:1/v1", Model: "scene-test-model", }))) engine, err := promptkit.NewEngine(promptkit.Config{Timeout: time.Second}, options...) if err != nil { t.Fatalf("NewEngine() error = %v, want nil", err) } return engine }