Fix config validation edge cases

internal/core/config/file_config.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"os"
 	"regexp"
+	"sort"
 	"strings"
 	"time"
 
@@ -198,11 +199,23 @@ func (c *Config) applyFileConfigWithLookup(fileCfg FileConfig, lookup func(strin
 		c.Pipelines = map[string]pipeline.PipelineProfile{}
 	}
 
-	for rawID, fileProfile := range fileCfg.LLMProfiles {
-		profileID := strings.TrimSpace(rawID)
-		if profileID == "" {
-			return fmt.Errorf("llm profile id must not be empty")
+	profileIDs, rawLLMProfileIDs, err := normalizedMapKeys(fileCfg.LLMProfiles, "llm profile id")
+	if err != nil {
+		return err
+	}
+	pipelineIDs, rawPipelineIDs, err := normalizedMapKeys(fileCfg.Pipelines, "pipeline id")
+	if err != nil {
+		return err
+	}
+	for _, pipelineID := range pipelineIDs {
+		filePipeline := fileCfg.Pipelines[rawPipelineIDs[pipelineID]]
+		if _, _, err := normalizedMapKeys(filePipeline.Artifacts, fmt.Sprintf("pipeline %q artifact lane id", pipelineID)); err != nil {
+			return err
 		}
+	}
+
+	for _, profileID := range profileIDs {
+		fileProfile := fileCfg.LLMProfiles[rawLLMProfileIDs[profileID]]
 		profile := c.LLMProfiles[profileID]
 		if fileProfile.Provider != nil {
 			profile.Provider = strings.TrimSpace(*fileProfile.Provider)
@@ -233,10 +246,11 @@ func (c *Config) applyFileConfigWithLookup(fileCfg FileConfig, lookup func(strin
 		c.LLMProfiles[profileID] = profile
 	}
 
-	for rawID, filePipeline := range fileCfg.Pipelines {
-		pipelineID := strings.TrimSpace(rawID)
-		if pipelineID == "" {
-			return fmt.Errorf("pipeline id must not be empty")
+	for _, pipelineID := range pipelineIDs {
+		filePipeline := fileCfg.Pipelines[rawPipelineIDs[pipelineID]]
+		laneIDs, rawLaneIDs, err := normalizedMapKeys(filePipeline.Artifacts, fmt.Sprintf("pipeline %q artifact lane id", pipelineID))
+		if err != nil {
+			return err
 		}
 		profile := pipeline.PipelineProfile{
 			ID:        pipelineID,
@@ -249,11 +263,8 @@ func (c *Config) applyFileConfigWithLookup(fileCfg FileConfig, lookup func(strin
 		if filePipeline.Output != nil {
 			profile.Output = filePipeline.Output.toPipelineBinding()
 		}
-		for rawLaneID, fileLane := range filePipeline.Artifacts {
-			laneID := strings.TrimSpace(rawLaneID)
-			if laneID == "" {
-				return fmt.Errorf("pipeline %q artifact lane id must not be empty", pipelineID)
-			}
+		for _, laneID := range laneIDs {
+			fileLane := filePipeline.Artifacts[rawLaneIDs[laneID]]
 			lane := pipeline.ArtifactLaneProfile{
 				Extract: fileLane.Extract.toPipelineBinding(),
 			}
@@ -289,6 +300,24 @@ func (c *Config) applyFileConfigWithLookup(fileCfg FileConfig, lookup func(strin
 	return nil
 }
 
+func normalizedMapKeys[T any](values map[string]T, keyName string) ([]string, map[string]string, error) {
+	keys := make([]string, 0, len(values))
+	rawByNormalized := make(map[string]string, len(values))
+	for rawID := range values {
+		id := strings.TrimSpace(rawID)
+		if id == "" {
+			return nil, nil, fmt.Errorf("%s must not be empty", keyName)
+		}
+		if _, ok := rawByNormalized[id]; ok {
+			return nil, nil, fmt.Errorf("%s %q is duplicated after trimming", keyName, id)
+		}
+		rawByNormalized[id] = rawID
+		keys = append(keys, id)
+	}
+	sort.Strings(keys)
+	return keys, rawByNormalized, nil
+}
+
 func resolveAPIKeyEnv(envName string, lookup func(string) (string, bool)) (string, error) {
 	name := strings.TrimSpace(envName)
 	if name == "" {