Use references in D&D spell extraction
This commit is contained in:
@@ -20,6 +20,7 @@ const (
|
||||
reasonMissingRequiredField = "missing_required_field"
|
||||
reasonMissingSourceRef = "missing_source_ref"
|
||||
reasonInvalidSourceRef = "invalid_source_ref"
|
||||
reasonSpellNotNearSource = "spell_not_near_source"
|
||||
)
|
||||
|
||||
var _ contracts.Validator = ShapeValidator{}
|
||||
@@ -54,12 +55,15 @@ func (validator SourceRefValidator) Validate(ctx context.Context, req contracts.
|
||||
}
|
||||
|
||||
decisions := make([]contracts.ValidationDecision, 0, len(req.Candidates))
|
||||
var warnings []contracts.Warning
|
||||
for _, candidate := range req.Candidates {
|
||||
decisions = append(decisions, validateSourceRefs(req.Source, candidate))
|
||||
warnings = append(warnings, sourceRelatednessWarnings(req.Source, candidate)...)
|
||||
}
|
||||
return contracts.ValidationResult{
|
||||
ValidatorName: validator.Name(),
|
||||
Decisions: decisions,
|
||||
Warnings: warnings,
|
||||
}, nil
|
||||
}
|
||||
|
||||
@@ -88,6 +92,66 @@ func validateSourceRefs(doc *source.SourceDocument, candidate artifacts.Artifact
|
||||
return validate.Approved(candidate.Index)
|
||||
}
|
||||
|
||||
func sourceRelatednessWarnings(doc *source.SourceDocument, candidate artifacts.ArtifactCandidate) []contracts.Warning {
|
||||
if doc == nil || len(candidate.SourceRefs) == 0 {
|
||||
return nil
|
||||
}
|
||||
var payload SpellCast
|
||||
if err := json.Unmarshal(candidate.Payload, &payload); err != nil {
|
||||
return nil
|
||||
}
|
||||
spell := strings.TrimSpace(payload.Spell)
|
||||
if spell == "" {
|
||||
return nil
|
||||
}
|
||||
|
||||
needle := strings.ToLower(spell)
|
||||
for _, ref := range candidate.SourceRefs {
|
||||
text, ok := sourceRefText(doc, ref)
|
||||
if !ok {
|
||||
continue
|
||||
}
|
||||
if strings.Contains(strings.ToLower(text), needle) {
|
||||
return nil
|
||||
}
|
||||
}
|
||||
|
||||
return []contracts.Warning{
|
||||
{
|
||||
Scope: fmt.Sprintf("candidate.%d", candidate.Index),
|
||||
ReasonCode: reasonSpellNotNearSource,
|
||||
Message: fmt.Sprintf("spell %q was not found in the cited source text", spell),
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
func sourceRefText(doc *source.SourceDocument, ref source.SourceRef) (string, bool) {
|
||||
if err := source.ValidateRef(doc, ref); err != nil {
|
||||
return "", false
|
||||
}
|
||||
start := -1
|
||||
end := -1
|
||||
for i, unit := range doc.Units {
|
||||
if unit.ID == ref.StartUnitID {
|
||||
start = i
|
||||
}
|
||||
if unit.ID == ref.EndUnitID {
|
||||
end = i
|
||||
}
|
||||
}
|
||||
if start < 0 || end < start {
|
||||
return "", false
|
||||
}
|
||||
var b strings.Builder
|
||||
for i := start; i <= end; i++ {
|
||||
if b.Len() > 0 {
|
||||
b.WriteString("\n")
|
||||
}
|
||||
b.WriteString(doc.Units[i].Text)
|
||||
}
|
||||
return b.String(), true
|
||||
}
|
||||
|
||||
func requiredSpellCastFields(payload SpellCast) []struct {
|
||||
name string
|
||||
value string
|
||||
|
||||
Reference in New Issue
Block a user