Move location registry modules to canonical namespace

internal/modules/dnd/validate/locationregistry/identity/validator.go

@@ -0,0 +1,76 @@
+// Package identity validates stable, evidence-anchored location identity.
+package identity
+
+import (
+	"context"
+	"fmt"
+
+	"gitea.maximumdirect.net/eric/notarius/internal/framework/contracts"
+	"gitea.maximumdirect.net/eric/notarius/internal/framework/pipeline"
+	"gitea.maximumdirect.net/eric/notarius/internal/modules/dnd"
+	domainidentity "gitea.maximumdirect.net/eric/notarius/internal/modules/dnd/locations/identity"
+	"gitea.maximumdirect.net/eric/notarius/internal/modules/dnd/shared/diagnostics"
+	locationshape "gitea.maximumdirect.net/eric/notarius/internal/modules/dnd/validate/locationregistry/shape"
+)
+
+const (
+	Key        = "normalize/dnd/location-registry/identity"
+	ReasonCode = "invalid_location_identity"
+	policy     = domainidentity.Policy
+)
+
+type Options struct{}
+type Validator struct{}
+
+var _ contracts.TypedValidator[dnd.LocationRegistry] = (*Validator)(nil)
+var _ pipeline.CheckpointFingerprintProvider = (*Validator)(nil)
+
+func New(Options) *Validator      { return &Validator{} }
+func (v *Validator) Name() string { return Key }
+func (v *Validator) ExecutionClass() contracts.ExecutionClass {
+	return contracts.ExecutionClassDeterministic
+}
+func (v *Validator) CheckpointFingerprints() []pipeline.CheckpointFingerprint {
+	return []pipeline.CheckpointFingerprint{{Name: "policy", Value: policy}}
+}
+
+func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationRequest[dnd.LocationRegistry]) (contracts.ValidationResult, error) {
+	if err := locationshape.Validate(req.Value); err != nil {
+		return contracts.ValidationResult{Approved: true}, nil
+	}
+	identityIssues := domainidentity.ValidateList(req.Value)
+	if len(identityIssues) == 0 {
+		return contracts.ValidationResult{Approved: true}, nil
+	}
+	issues := make([]string, len(identityIssues))
+	for index, issue := range identityIssues {
+		issues[index] = fmt.Sprintf("locations[%d] %s: %s", issue.RecordIndex, issue.Code, diagnostics.Quote(issue.Value))
+	}
+	return contracts.ValidationResult{
+		Approved: false, ReasonCode: ReasonCode,
+		Message: diagnostics.Aggregate("invalid location identity", issues),
+	}, nil
+}
+
+func Spec() pipeline.ValidatorSpec {
+	return pipeline.ValidatorSpec{Key: Key, ExecutionClass: contracts.ExecutionClassDeterministic}
+}
+
+func Register(registry *pipeline.ValidatorRegistry) error {
+	return pipeline.RegisterTypedValidatorBuilder(registry, dnd.LocationRegistryKind, Spec(), validateOptions, func(request pipeline.BuildRequest) (contracts.TypedValidator[dnd.LocationRegistry], error) {
+		options, err := DecodeOptions(request.Options)
+		if err != nil {
+			return nil, err
+		}
+		return New(options), nil
+	})
+}
+
+func DecodeOptions(options map[string]any) (Options, error) {
+	if err := pipeline.RejectUnknownOptions(options); err != nil {
+		return Options{}, err
+	}
+	return Options{}, nil
+}
+
+func validateOptions(options map[string]any) error { _, err := DecodeOptions(options); return err }

internal/modules/dnd/validate/locationregistry/identity/validator_test.go

@@ -0,0 +1,70 @@
+package identity
+
+import (
+	"context"
+	"reflect"
+	"strings"
+	"testing"
+
+	"gitea.maximumdirect.net/eric/notarius/internal/core/source"
+	"gitea.maximumdirect.net/eric/notarius/internal/framework/contracts"
+	"gitea.maximumdirect.net/eric/notarius/internal/framework/pipeline"
+	"gitea.maximumdirect.net/eric/notarius/internal/modules/dnd"
+	domainidentity "gitea.maximumdirect.net/eric/notarius/internal/modules/dnd/locations/identity"
+)
+
+func TestValidatorAllowsSameNameAtDistinctEvidence(t *testing.T) {
+	refs := []source.SourceRef{{SourceID: "session", StartUnitID: 1, EndUnitID: 1}}
+	otherRefs := []source.SourceRef{{SourceID: "session", StartUnitID: 2, EndUnitID: 2}}
+	value := dnd.LocationRegistry{Locations: []dnd.Location{
+		{ID: domainidentity.DeriveID("Watchtower", refs), Name: "Watchtower", SourceRefs: refs},
+		{ID: domainidentity.DeriveID("Watchtower", otherRefs), Name: "Watchtower", SourceRefs: otherRefs},
+	}}
+	before := value
+	result, err := New(Options{}).Validate(context.Background(), request(value))
+	if err != nil || !result.Approved || !reflect.DeepEqual(value, before) {
+		t.Fatalf("Validate() = %#v, %v; want non-mutating approval", result, err)
+	}
+}
+
+func TestValidatorDefersShapeAndRejectsDerivationAndDuplicateID(t *testing.T) {
+	result, err := New(Options{}).Validate(context.Background(), request(dnd.LocationRegistry{Locations: []dnd.Location{{Name: "Missing"}}}))
+	if err != nil || !result.Approved {
+		t.Fatalf("shape-invalid result = %#v, %v; want deferral", result, err)
+	}
+	refs := []source.SourceRef{{SourceID: "session", StartUnitID: 1, EndUnitID: 1}}
+	value := dnd.LocationRegistry{Locations: []dnd.Location{
+		{ID: "not-an-id", Name: "Gate", SourceRefs: refs},
+		{ID: domainidentity.DeriveID("Gate", refs), Name: "Other Gate", SourceRefs: refs},
+		{ID: domainidentity.DeriveID("Gate", refs), Name: "Gate", SourceRefs: refs},
+	}}
+	result, err = New(Options{}).Validate(context.Background(), request(value))
+	if err != nil || result.Approved || result.ReasonCode != ReasonCode {
+		t.Fatalf("identity result = %#v, %v; want rejection", result, err)
+	}
+	for _, want := range []string{"invalid_id", "id_mismatch", "duplicate_id", "locations["} {
+		if !strings.Contains(result.Message, want) {
+			t.Fatalf("message %q missing %q", result.Message, want)
+		}
+	}
+}
+
+func TestValidatorRegistersIdentityPolicy(t *testing.T) {
+	if got := New(Options{}).CheckpointFingerprints(); len(got) != 1 || got[0].Value != domainidentity.Policy {
+		t.Fatalf("fingerprints = %#v", got)
+	}
+	registry := pipeline.NewValidatorRegistry()
+	if err := Register(registry); err != nil {
+		t.Fatalf("Register() error = %v", err)
+	}
+	if got, ok := registry.Spec(Key); !ok || got != Spec() || got.ExecutionClass != contracts.ExecutionClassDeterministic {
+		t.Fatalf("registered spec = %#v, ok = %t", got, ok)
+	}
+	if _, err := DecodeOptions(map[string]any{"unexpected": true}); err == nil {
+		t.Fatal("DecodeOptions() accepted an unknown option")
+	}
+}
+
+func request(value dnd.LocationRegistry) contracts.TypedValidationRequest[dnd.LocationRegistry] {
+	return contracts.TypedValidationRequest[dnd.LocationRegistry]{Value: value}
+}