Strengthen validation retries and checkpoint safety

internal/modules/dnd/validate/combatturns/invariants/validator.go

@@ -40,7 +40,7 @@ func (v *Validator) CheckpointFingerprints() []pipeline.CheckpointFingerprint {
 
 func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationRequest[dnd.CombatTurnList]) (contracts.ValidationResult, error) {
 	if err := Validate(req.Source, req.Value); err != nil {
-		return contracts.ValidationResult{Approved: false, ReasonCode: ReasonCode, Message: err.Error()}, nil
+		return contracts.ValidationResult{Approved: false, ReasonCode: ReasonCode, Message: err.Error(), CorrectionGuidance: "Return combat turns in transcript order, without duplicate turns, using consistent contextual combatant names and evidence for each turn."}, nil
 	}
 	return contracts.ValidationResult{Approved: true}, nil
 }

internal/modules/dnd/validate/combatturns/shape/validator.go

@@ -100,5 +100,5 @@ func DecodeOptions(options map[string]any) (Options, error) {
 func validateOptions(options map[string]any) error { _, err := DecodeOptions(options); return err }
 
 func rejection(message string) contracts.ValidationResult {
-	return contracts.ValidationResult{Approved: false, ReasonCode: ReasonCode, Message: message}
+	return contracts.ValidationResult{Approved: false, ReasonCode: ReasonCode, Message: message, CorrectionGuidance: "Return a complete combat-turn list with every required field present, valid combatant names, and valid source references."}
 }

internal/modules/dnd/validate/combatturns/shape/validator_test.go

@@ -41,6 +41,9 @@ func TestValidateRejectsEveryOwnedShapeBoundary(t *testing.T) {
 			if err != nil || result.Approved || result.ReasonCode != ReasonCode {
 				t.Fatalf("Validator result = %#v, %v; want shape rejection", result, err)
 			}
+			if err := contracts.ValidateValidationResult(result); err != nil {
+				t.Fatalf("ValidateValidationResult() error = %v for %#v", err, result)
+			}
 		})
 	}
 }

internal/modules/dnd/validate/combatturns/source_refs/validator.go

@@ -49,9 +49,10 @@ func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationReq
 		return contracts.ValidationResult{Approved: true}, nil
 	}
 	return contracts.ValidationResult{
-		Approved:   false,
-		ReasonCode: ReasonCode,
-		Message:    diagnostics.Aggregate("invalid combat turn source references", issues),
+		Approved:           false,
+		ReasonCode:         ReasonCode,
+		Message:            diagnostics.Aggregate("invalid combat turn source references", issues),
+		CorrectionGuidance: "Return combat turns whose source references identify valid transcript ranges within the supplied extraction chunk and directly support each turn.",
 	}, nil
 }
 

internal/modules/dnd/validate/combatturns/source_refs/validator_test.go

@@ -42,6 +42,9 @@ func TestValidatorRejectsInvalidSourceIdentityExistenceAndOrder(t *testing.T) {
 			if err != nil || result.Approved || result.ReasonCode != ReasonCode || !strings.Contains(result.Message, test.want) {
 				t.Fatalf("Validate() = %#v, %v; want source-reference rejection containing %q", result, err, test.want)
 			}
+			if err := contracts.ValidateValidationResult(result); err != nil {
+				t.Fatalf("ValidateValidationResult() error = %v for %#v", err, result)
+			}
 		})
 	}
 }