Convert ConfigKit documents to runtime configuration

2026-09-13 16:39:33 +00:00
parent 9c247cf3a2
commit cf17dd7bd0
3 changed files with 425 additions and 0 deletions
--- a/internal/core/config/loaded_config_test.go
+++ b/internal/core/config/loaded_config_test.go
@@ -0,0 +1,102 @@
+package config
+
+import (
+	"bytes"
+	"strings"
+	"testing"
+
+	configkit "gitea.maximumdirect.net/eric/ConfigKit"
+	"gitea.maximumdirect.net/eric/notarius/internal/framework/pipeline"
+)
+
+func TestLoadedConfigConvertsDocumentsAndResolvesRuntimePipeline(t *testing.T) {
+	t.Parallel()
+
+	loaded, err := loadConfigSource(configkit.Bytes("document.yml", []byte(`version: 5
+pipelines:
+  session:
+    llm_profile: local
+    structured_output_repair_attempts: 0
+    input:
+      module: input
+    chunk:
+      module: generic
+      validators: []
+    artifacts:
+      score:
+        extract:
+          module: extract
+          validators:
+            - module: configured-a
+              options:
+                nested:
+                  level: 1
+`)), LoadOptions{})
+	if err != nil {
+		t.Fatalf("loadConfigSource() error = %v", err)
+	}
+	profile := loaded.Config.Pipelines["session"]
+	if profile.LLMProfile != "local" || profile.StructuredOutputRepairAttempts == nil || *profile.StructuredOutputRepairAttempts != 0 {
+		t.Fatalf("pipeline profile = %#v", profile)
+	}
+	if !profile.Chunk.Validators.Set || profile.Chunk.Validators.Validators == nil || len(profile.Chunk.Validators.Validators) != 0 {
+		t.Fatalf("empty validator chain was not preserved: %#v", profile.Chunk.Validators)
+	}
+	validator := profile.Artifacts["score"].Extract.Validators.Validators[0]
+	if validator.Module != "configured-a" || validator.Options["nested"].(map[string]any)["level"] == nil {
+		t.Fatalf("validator conversion = %#v", validator)
+	}
+
+	effective, err := loaded.Config.Resolve(ResolveInput{PipelineID: "session", Catalog: effectiveCatalog(t)})
+	if err != nil {
+		t.Fatalf("Resolve() error = %v", err)
+	}
+	if effective.ResolvedPipeline.ID != "session" || effective.ResolvedPipeline.Digest == "" {
+		t.Fatalf("resolved pipeline = %#v", effective.ResolvedPipeline)
+	}
+}
+
+func TestLoadedConfigOwnsRuntimeValuesAndKeepsFrozenInspection(t *testing.T) {
+	t.Parallel()
+
+	loaded, err := loadConfigSource(configkit.Bytes("document.yml", []byte(`version: 5
+pipelines:
+  session:
+    input: {module: input}
+    artifacts:
+      score:
+        extract:
+          module: extract
+          options:
+            nested: {value: original}
+`)), LoadOptions{})
+	if err != nil {
+		t.Fatalf("loadConfigSource() error = %v", err)
+	}
+
+	first := loaded.RuntimeConfig()
+	first.Pipelines["session"] = pipelineProfileWithChangedOption(first.Pipelines["session"])
+	second := loaded.RuntimeConfig()
+	if got := second.Pipelines["session"].Artifacts["score"].Extract.Options["nested"].(map[string]any)["value"]; got != "original" {
+		t.Fatalf("runtime configuration aliases caller mutation: %#v", got)
+	}
+
+	loaded.Config.Pipelines["session"] = pipelineProfileWithChangedOption(loaded.Config.Pipelines["session"])
+	var effective bytes.Buffer
+	if err := loaded.WriteEffective(&effective); err != nil {
+		t.Fatalf("WriteEffective() error = %v", err)
+	}
+	if !strings.Contains(effective.String(), "original") || strings.Contains(effective.String(), "changed") {
+		t.Fatalf("effective document changed with runtime mutation: %q", effective.String())
+	}
+}
+
+func pipelineProfileWithChangedOption(profile pipeline.PipelineProfile) pipeline.PipelineProfile {
+	profile = clonePipelineProfile(profile)
+	nested := profile.Artifacts["score"].Extract.Options["nested"].(map[string]any)
+	nested["value"] = "changed"
+	lane := profile.Artifacts["score"]
+	lane.Extract.Options["nested"] = nested
+	profile.Artifacts["score"] = lane
+	return profile
+}