Tighten NPC interaction validation and consistency

internal/modules/dnd/validate/npcinteractions/source_relatedness/validator.go

@@ -16,7 +16,8 @@ import (
 const (
 	Key               = "extract/dnd/npc-interactions/source_relatedness"
 	WarningReasonCode = "npc_interaction_not_near_source"
-	policy            = "dnd.npc_interactions.validator.source_relatedness.v1"
+	OmittedReasonCode = "npc_interaction_relatedness_warnings_omitted"
+	policy            = "dnd.npc_interactions.validator.source_relatedness.v2"
 )
 
 type Options struct{}
@@ -57,7 +58,10 @@ func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationReq
 			Message:    fmt.Sprintf("NPC interaction name %s was not found in cited source text", diagnostics.Quote(interaction.Name)),
 		})
 	}
-	return contracts.ValidationResult{Approved: true, Warnings: warnings}, nil
+	return contracts.ValidationResult{
+		Approved: true,
+		Warnings: diagnostics.LimitWarnings(warnings, "npc_interactions", OmittedReasonCode),
+	}, nil
 }
 
 func Spec() pipeline.ValidatorSpec {

internal/modules/dnd/validate/npcinteractions/source_relatedness/validator_test.go

@@ -10,6 +10,7 @@ import (
 	"gitea.maximumdirect.net/eric/notarius/internal/framework/contracts"
 	"gitea.maximumdirect.net/eric/notarius/internal/framework/pipeline"
 	"gitea.maximumdirect.net/eric/notarius/internal/modules/dnd"
+	"gitea.maximumdirect.net/eric/notarius/internal/modules/dnd/shared/diagnostics"
 )
 
 func TestValidatorUsesOnlyCurrentTranscriptAndWarnsOncePerInteraction(t *testing.T) {
@@ -49,3 +50,26 @@ func TestValidatorDefersMalformedShapeAndInvalidRanges(t *testing.T) {
 		t.Fatal(err)
 	}
 }
+
+func TestValidatorBoundsWarnings(t *testing.T) {
+	count := diagnostics.MaxWarnings + 5
+	interactions := make([]dnd.NPCInteraction, count)
+	for index := range interactions {
+		interactions[index] = dnd.NPCInteraction{
+			Name:       "Missing NPC",
+			Kind:       dnd.NPCInteractionKindMentioned,
+			SourceRefs: []source.SourceRef{{SourceID: "session", StartUnitID: 1, EndUnitID: 1}},
+		}
+	}
+	result, err := New(Options{}).Validate(context.Background(), contracts.TypedValidationRequest[dnd.NPCInteractionList]{
+		Source: &source.SourceDocument{ID: "session", Units: []source.SourceUnit{{ID: 1, Text: "The party waits."}}},
+		Value:  dnd.NPCInteractionList{Interactions: interactions},
+	})
+	if err != nil || !result.Approved {
+		t.Fatalf("Validate() = %#v, %v", result, err)
+	}
+	if len(result.Warnings) != diagnostics.MaxWarnings ||
+		result.Warnings[len(result.Warnings)-1].ReasonCode != OmittedReasonCode {
+		t.Fatalf("warnings = %#v", result.Warnings)
+	}
+}