eric/notarius
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused NPC registry and identity aliases

Browse Source
This commit is contained in:
Eric Rakestraw
2026-07-25 13:06:40 +00:00
parent d752c51aec
commit aeaaf44ae0
3 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
docs/internal/modules.md
View File

@@ -53,8 +53,9 @@ LLM-backed extensions own their prompt definitions and response schemas under
package-local embedded assets. Shared filesystem composition belongs in package-local embedded assets. Shared filesystem composition belongs in
`internal/framework/promptfs`; reusable D&D prompt fragments, reference `internal/framework/promptfs`; reusable D&D prompt fragments, reference
declarations, prompt-input assembly, and source-unit/citation helpers belong in declarations, prompt-input assembly, and source-unit/citation helpers belong in
`internal/modules/dnd/shared`, which also owns document-aware source-reference `internal/modules/dnd/shared`, which owns operation-scoped indexed
ordering and canonicalization plus bounded D&D diagnostics. The source-reference validation, citation traversal, ordering and canonicalization,
plus bounded D&D diagnostics. The
D&D scene chunker and spell, NPC, combat-turn, NPC-interaction, and scene-description extractors use ordered D&D scene chunker and spell, NPC, combat-turn, NPC-interaction, and scene-description extractors use ordered
package-local prompt manifests for both rendering and prompt fingerprinting, so package-local prompt manifests for both rendering and prompt fingerprinting, so
only the shared fragments each prompt actually renders participate in either only the shared fragments each prompt actually renders participate in either
@@ -117,7 +118,10 @@ preparation; generated artifacts cross it at the ordered step handoff. It owns
the `npcs` slot and its bounded, content-safe validation failures. NPC source the `npcs` slot and its bounded, content-safe validation failures. NPC source
references are durable provenance and are not treated as evidence for a references are durable provenance and are not treated as evidence for a
consuming pipeline. The NPC codec owns the strict durable `dnd/npc-list` JSON consuming pipeline. The NPC codec owns the strict durable `dnd/npc-list` JSON
boundary and exposes candidate versus approved encode/decode operations. boundary and exposes candidate versus approved encode/decode operations. The
shared `internal/modules/dnd/codec/candidatejson` package supplies strict typed
candidate JSON mechanics; each artifact codec retains its own durable schema
and approved-value policy.
The `internal/modules/dnd/codec/combatturns` package owns the durable The `internal/modules/dnd/codec/combatturns` package owns the durable
`dnd/combat-turn-list` schema and candidate versus approved JSON boundary. It `dnd/combat-turn-list` schema and candidate versus approved JSON boundary. It
@@ -345,8 +349,9 @@ normalization warnings.
### `internal/modules/generic/merge/appendorder` ### `internal/modules/generic/merge/appendorder`
The merger passes typed values to an injected combine function in framework The merger passes typed values to an injected combine function in framework
source-chunk order. The D&D registrar specializes it with a spell-list append source-chunk order. The D&D registrar specializes it for all five artifact
function. lists; each append merger preserves collection presence and order while giving
the result independently owned nested source-reference slices.
### `internal/modules/generic/normalize/noop` ### `internal/modules/generic/normalize/noop`

3
internal/modules/dnd/npcs/identity/identity.go
View File

@@ -138,9 +138,6 @@ func ValidateRegistry(npcs []dnd.NPC) []Issue {
// ValidateList validates the identity members of list. // ValidateList validates the identity members of list.
func ValidateList(list dnd.NPCList) []Issue { return ValidateRegistry(list.NPCs) } func ValidateList(list dnd.NPCList) []Issue { return ValidateRegistry(list.NPCs) }
// Validate is a convenience alias for ValidateList.
func Validate(list dnd.NPCList) []Issue { return ValidateList(list) }
// Error makes an issue useful in simple callers while preserving its // Error makes an issue useful in simple callers while preserving its
// structured fields for aggregate diagnostics. // structured fields for aggregate diagnostics.
func (i Issue) Error() string { func (i Issue) Error() string {

3
internal/modules/dnd/npcs/registry/registry.go
View File

@@ -203,9 +203,6 @@ func Resolve(references contracts.ReferenceSet) (*Registry, error) {
}, nil }, nil
} }
// New is an alias for Resolve for callers constructing a prepared registry.
func New(references contracts.ReferenceSet) (*Registry, error) { return Resolve(references) }
// Bound reports whether an NPC reference was supplied and validated. // Bound reports whether an NPC reference was supplied and validated.
func (r *Registry) Bound() bool { return r != nil && r.bound } func (r *Registry) Bound() bool { return r != nil && r.bound }