Remove legacy raw pipeline contracts

internal/framework/pipeline/default_modules_test.go

@@ -2,6 +2,7 @@ package pipeline_test
 
 import (
 	"context"
+	"encoding/json"
 	"testing"
 
 	"gitea.maximumdirect.net/eric/notarius/internal/core/config"
@@ -71,30 +72,40 @@ func defaultModuleCatalog(t *testing.T) pipeline.ModuleCatalog {
 	if err := units.Register(chunkers); err != nil {
 		t.Fatalf("register generic chunker: %v", err)
 	}
-	if err := extractors.RegisterLegacyRawWithSpec(pipeline.ModuleSpec{
-		Key:      "extract",
-		Stage:    pipeline.StageExtract,
-		Requires: []string{"chunks"},
-		Provides: []string{"records"},
-	}, func() (contracts.LegacyRawExtractor, error) {
+	if err := pipeline.RegisterExtractor[defaultArtifact](extractors, pipeline.ModuleSpec{
+		Key:          "extract",
+		Stage:        pipeline.StageExtract,
+		ArtifactKind: defaultArtifactKind,
+		Requires:     []string{"chunks"},
+		Provides:     []string{"records"},
+	}, func() (contracts.Extractor[defaultArtifact], error) {
 		return defaultExtractor{}, nil
 	}); err != nil {
 		t.Fatalf("register extractor: %v", err)
 	}
-	if err := appendorder.Register(mergers); err != nil {
+	if err := appendorder.RegisterTyped(mergers, defaultArtifactKind, func(values []defaultArtifact) (defaultArtifact, error) {
+		if len(values) == 0 {
+			return defaultArtifact{}, nil
+		}
+		return values[0], nil
+	}); err != nil {
 		t.Fatalf("register appendorder merger: %v", err)
 	}
-	if err := noop.Register(normalizers); err != nil {
+	if err := noop.RegisterTyped[defaultArtifact](normalizers, defaultArtifactKind); err != nil {
 		t.Fatalf("register noop normalizer: %v", err)
 	}
 	if err := jsonoutput.Register(outputs); err != nil {
 		t.Fatalf("register json output: %v", err)
 	}
 
+	codecs := pipeline.NewArtifactCodecRegistry()
+	if err := pipeline.RegisterArtifactCodec(codecs, defaultArtifactCodec{}); err != nil {
+		t.Fatalf("register artifact codec: %v", err)
+	}
 	return pipeline.ModuleCatalog{
 		Inputs:          inputs,
 		Chunkers:        chunkers,
-		ArtifactCodecs:  pipeline.NewArtifactCodecRegistry(),
+		ArtifactCodecs:  codecs,
 		Extractors:      extractors,
 		Mergers:         mergers,
 		Normalizers:     normalizers,
@@ -117,6 +128,25 @@ func (defaultExtractor) Key() string { return "extract" }
 
 func (defaultExtractor) ReferenceSlots() []contracts.ReferenceSlot { return nil }
 
-func (defaultExtractor) Extract(ctx context.Context, req contracts.ExtractionRequest) (contracts.ExtractionResult, error) {
-	return contracts.ExtractionResult{}, nil
+func (defaultExtractor) Extract(ctx context.Context, req contracts.TypedExtractionRequest) (contracts.TypedExtractionResult[defaultArtifact], error) {
+	return contracts.TypedExtractionResult[defaultArtifact]{}, nil
+}
+
+const defaultArtifactKind contracts.ArtifactKind = "test/default"
+
+type defaultArtifact struct {
+	Value string `json:"value"`
+}
+type defaultArtifactCodec struct{}
+
+func (defaultArtifactCodec) Kind() contracts.ArtifactKind { return defaultArtifactKind }
+func (defaultArtifactCodec) Schema() contracts.ArtifactSchema {
+	return contracts.ArtifactSchema{ID: "urn:notarius:test:default", Name: "default", Version: "1", JSONSchema: []byte(`{"type":"object"}`)}
+}
+func (defaultArtifactCodec) MediaType() string                            { return "application/json" }
+func (defaultArtifactCodec) Encode(value defaultArtifact) ([]byte, error) { return json.Marshal(value) }
+func (defaultArtifactCodec) Decode(content []byte) (defaultArtifact, error) {
+	var value defaultArtifact
+	err := json.Unmarshal(content, &value)
+	return value, err
 }