Relax private D&D response schemas

internal/modules/dnd/extract/spells/schema_test.go

@@ -29,6 +29,66 @@ func TestLoadResponseSchemaUsesExtractorOwnedLLMSchema(t *testing.T) {
 	if err := validateJSONSchema(validJSON, schema.JSONSchema); err != nil {
 		t.Fatalf("valid private spells response rejected: %v", err)
 	}
+	for _, test := range []struct {
+		name     string
+		response map[string]any
+		valid    bool
+	}{
+		{
+			name: "semantic blanks and empty evidence",
+			response: map[string]any{"spell_casts": []any{map[string]any{
+				"caster": "", "spell": "", "effect": "", "narrative_description": "", "source_refs": []any{},
+			}}},
+			valid: true,
+		},
+		{
+			name: "nonpositive unit candidates",
+			response: map[string]any{"spell_casts": []any{map[string]any{
+				"caster": "Aria", "spell": "Cure Wounds", "effect": "Heals.", "narrative_description": "Aria heals.",
+				"source_refs": []any{map[string]any{"start_unit_id": 0, "end_unit_id": -1}},
+			}}},
+			valid: true,
+		},
+		{
+			name: "missing required field",
+			response: map[string]any{"spell_casts": []any{map[string]any{
+				"spell": "Cure Wounds", "effect": "Heals.", "narrative_description": "Aria heals.", "source_refs": []any{},
+			}}},
+		},
+		{
+			name: "unknown field",
+			response: map[string]any{"spell_casts": []any{map[string]any{
+				"caster": "Aria", "spell": "Cure Wounds", "effect": "Heals.", "narrative_description": "Aria heals.", "source_refs": []any{}, "id": "assigned later",
+			}}},
+		},
+		{
+			name: "wrong field type",
+			response: map[string]any{"spell_casts": []any{map[string]any{
+				"caster": 7, "spell": "Cure Wounds", "effect": "Heals.", "narrative_description": "Aria heals.", "source_refs": []any{},
+			}}},
+		},
+		{
+			name: "noninteger source identifier",
+			response: map[string]any{"spell_casts": []any{map[string]any{
+				"caster": "Aria", "spell": "Cure Wounds", "effect": "Heals.", "narrative_description": "Aria heals.",
+				"source_refs": []any{map[string]any{"start_unit_id": 1.5, "end_unit_id": 2}},
+			}}},
+		},
+	} {
+		t.Run(test.name, func(t *testing.T) {
+			content, err := json.Marshal(test.response)
+			if err != nil {
+				t.Fatal(err)
+			}
+			err = validateJSONSchema(content, schema.JSONSchema)
+			if (err == nil) != test.valid {
+				t.Fatalf("validateJSONSchema() error = %v, want valid=%t", err, test.valid)
+			}
+		})
+	}
+	if err := validateJSONSchema([]byte(`{"spell_casts":`), schema.JSONSchema); err == nil {
+		t.Fatal("validateJSONSchema() error = nil, want malformed JSON rejected")
+	}
 
 	withCanonicalSourceID := validSpellsResponse()
 	withCanonicalSourceID["spell_casts"].([]any)[0].(map[string]any)["source_refs"].([]any)[0].(map[string]any)["source_id"] = "session-alpha"