Migrate production modules to raw outputs

internal/modules/merge/appendorder/merger_test.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"encoding/json"
 	"reflect"
+	"strings"
 	"testing"
 
 	"gitea.maximumdirect.net/eric/notarius/internal/framework/contracts"
@@ -77,12 +78,12 @@ func TestMergeDefensivelyCopiesRawPayload(t *testing.T) {
 	}
 }
 
-func TestMergeWrapsMultipleOutputsInChunkOrder(t *testing.T) {
+func TestMergeConcatenatesCommonTopLevelArrayFieldInChunkOrder(t *testing.T) {
 	result, err := New().Merge(context.Background(), contracts.MergeRequest{
 		LaneID: "events",
 		ExtractOutputs: []contracts.ExtractOutput{
-			extractOutput("chunk-0", 0, `{"name":"first"}`),
-			extractOutput("chunk-1", 1, `{"name":"second"}`),
+			extractOutput("chunk-1", 1, `{"events":[{"name":"second"}]}`),
+			extractOutput("chunk-0", 0, `{"events":[{"name":"first"}]}`),
 		},
 	})
 	if err != nil {
@@ -93,27 +94,83 @@ func TestMergeWrapsMultipleOutputsInChunkOrder(t *testing.T) {
 	}
 
 	var decoded struct {
-		Outputs []struct {
-			ChunkID    string          `json:"chunk_id"`
-			ChunkIndex int             `json:"chunk_index"`
-			Content    json.RawMessage `json:"content"`
-		} `json:"outputs"`
+		Events []struct {
+			Name string `json:"name"`
+		} `json:"events"`
 	}
 	if err := json.Unmarshal(result.Output.Payload.Content, &decoded); err != nil {
 		t.Fatalf("Unmarshal() error = %v, want nil", err)
 	}
-	if len(decoded.Outputs) != 2 || decoded.Outputs[0].ChunkID != "chunk-0" || decoded.Outputs[1].ChunkID != "chunk-1" {
-		t.Fatalf("outputs = %#v, want chunk order", decoded.Outputs)
+	if len(decoded.Events) != 2 || decoded.Events[0].Name != "first" || decoded.Events[1].Name != "second" {
+		t.Fatalf("events = %#v, want concatenated chunk order", decoded.Events)
+	}
+	if result.Output.Schema.ID != "schema-id" {
+		t.Fatalf("schema = %#v, want common extract schema", result.Output.Schema)
 	}
 }
 
-func TestMergeHandlesEmptyInput(t *testing.T) {
-	result, err := New().Merge(context.Background(), contracts.MergeRequest{LaneID: "events"})
+func TestMergeFallsBackToOrderedJSONValueArrayWhenShapesDiffer(t *testing.T) {
+	result, err := New().Merge(context.Background(), contracts.MergeRequest{
+		LaneID: "events",
+		ExtractOutputs: []contracts.ExtractOutput{
+			extractOutput("chunk-1", 1, `{"notes":["second"]}`),
+			extractOutput("chunk-0", 0, `{"events":[{"name":"first"}]}`),
+		},
+	})
 	if err != nil {
 		t.Fatalf("Merge() error = %v, want nil", err)
 	}
-	if string(result.Output.Payload.Content) != `{"outputs":[]}` {
-		t.Fatalf("content = %s, want empty outputs", result.Output.Payload.Content)
+
+	var decoded []map[string]any
+	if err := json.Unmarshal(result.Output.Payload.Content, &decoded); err != nil {
+		t.Fatalf("Unmarshal() error = %v, want nil", err)
+	}
+	if len(decoded) != 2 {
+		t.Fatalf("len(decoded) = %d, want 2", len(decoded))
+	}
+	if _, ok := decoded[0]["events"]; !ok {
+		t.Fatalf("decoded[0] = %#v, want first chunk value", decoded[0])
+	}
+	if _, ok := decoded[1]["notes"]; !ok {
+		t.Fatalf("decoded[1] = %#v, want second chunk value", decoded[1])
+	}
+}
+
+func TestMergeRejectsInvalidJSONAndNonJSONMediaTypes(t *testing.T) {
+	tests := []struct {
+		name   string
+		output contracts.ExtractOutput
+		want   string
+	}{
+		{
+			name:   "invalid JSON",
+			output: extractOutput("chunk-0", 0, `{"events":[`),
+			want:   "invalid JSON",
+		},
+		{
+			name: "non JSON media type",
+			output: func() contracts.ExtractOutput {
+				output := extractOutput("chunk-0", 0, `{"events":[]}`)
+				output.Payload.MediaType = "text/plain"
+				return output
+			}(),
+			want: "unsupported media type",
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			_, err := New().Merge(context.Background(), contracts.MergeRequest{
+				LaneID:         "events",
+				ExtractOutputs: []contracts.ExtractOutput{test.output},
+			})
+			if err == nil {
+				t.Fatal("Merge() error = nil, want error")
+			}
+			if !strings.Contains(err.Error(), test.want) {
+				t.Fatalf("Merge() error = %q, want %q", err.Error(), test.want)
+			}
+		})
 	}
 }