Add internal debug bundle collaborators

internal/framework/debug/recorder.go

@@ -3,39 +3,36 @@ package debug
 import (
 	"strings"
 
-	coreworkspace "gitea.maximumdirect.net/eric/notarius/internal/core/workspace"
+	"gitea.maximumdirect.net/eric/notarius/internal/core/fileio"
 	"gitea.maximumdirect.net/eric/notarius/internal/framework/pipeline"
 )
 
-type WorkspaceRecorder struct {
+type FilesystemRecorder struct {
 	root string
 }
 
-func NewWorkspaceRecorder(settings coreworkspace.Settings, runID string) (pipeline.DebugRecorder, error) {
-	root, err := settings.DebugRunDirectory(runID)
-	if err != nil {
-		return nil, err
-	}
+func NewFilesystemRecorder(root string) (pipeline.DebugRecorder, error) {
+	root = strings.TrimSpace(root)
 	if strings.TrimSpace(root) == "" {
 		return pipeline.NoopDebugRecorder(), nil
 	}
-	return &WorkspaceRecorder{root: root}, nil
+	return &FilesystemRecorder{root: root}, nil
 }
 
-func (r *WorkspaceRecorder) Enabled() bool {
+func (r *FilesystemRecorder) Enabled() bool {
 	return r != nil && strings.TrimSpace(r.root) != ""
 }
 
-func (r *WorkspaceRecorder) WriteJSON(name string, payload any) error {
+func (r *FilesystemRecorder) WriteJSON(name string, payload any) error {
 	if !r.Enabled() {
 		return nil
 	}
-	return coreworkspace.WriteJSON(r.root, name, payload)
+	return fileio.WriteJSON(r.root, name, payload, 0o700, 0o600)
 }
 
-func (r *WorkspaceRecorder) WriteBytes(name string, data []byte) error {
+func (r *FilesystemRecorder) WriteBytes(name string, data []byte) error {
 	if !r.Enabled() {
 		return nil
 	}
-	return coreworkspace.WriteBytes(r.root, name, data)
+	return fileio.WriteBytes(r.root, name, data, 0o700, 0o600)
 }

internal/framework/debug/recorder_test.go

@@ -0,0 +1,28 @@
+package debug
+
+import (
+	"os"
+	"path/filepath"
+	"testing"
+)
+
+func TestFilesystemRecorderWritesWithinTraceRoot(t *testing.T) {
+	root := t.TempDir()
+	recorder, err := NewFilesystemRecorder(root)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if err := recorder.WriteBytes("attempt/data", []byte("payload")); err != nil {
+		t.Fatal(err)
+	}
+	info, err := os.Stat(filepath.Join(root, "attempt", "data"))
+	if err != nil {
+		t.Fatal(err)
+	}
+	if info.Mode().Perm() != 0o600 {
+		t.Fatalf("mode=%#o", info.Mode().Perm())
+	}
+	if err := recorder.WriteBytes("../outside", nil); err == nil {
+		t.Fatal("accepted traversal")
+	}
+}