Refactor the D&D spells module to apply deterministic fields where appropriate

internal/modules/extract/dnd/spells/schema_test.go

@@ -37,6 +37,10 @@ func TestLoadResponseSchemaForSpells(t *testing.T) {
 	properties := decoded["properties"].(map[string]any)
 	spellCastProperties := properties["spell_casts"].(map[string]any)["items"].(map[string]any)["properties"].(map[string]any)
 	sourceRefProperties := spellCastProperties["source_refs"].(map[string]any)["items"].(map[string]any)["properties"].(map[string]any)
+	sourceRefRequired := spellCastProperties["source_refs"].(map[string]any)["items"].(map[string]any)["required"].([]any)
+	if !containsJSONField(sourceRefRequired, "source_id") {
+		t.Fatalf("canonical source refs required = %#v, want source_id", sourceRefRequired)
+	}
 	for _, field := range []string{"start_unit_id", "end_unit_id"} {
 		property := sourceRefProperties[field].(map[string]any)
 		if property["type"] != "integer" {
@@ -48,6 +52,32 @@ func TestLoadResponseSchemaForSpells(t *testing.T) {
 	}
 }
 
+func TestLLMResponseSchemaOmitsSourceID(t *testing.T) {
+	raw, err := embeddedAssets.ReadFile("assets/schemas/dnd_spells_llm.v1.json")
+	if err != nil {
+		t.Fatalf("ReadFile(LLM schema) error = %v, want nil", err)
+	}
+	if !json.Valid(raw) {
+		t.Fatalf("LLM schema is invalid JSON: %s", raw)
+	}
+
+	var decoded map[string]any
+	if err := json.Unmarshal(raw, &decoded); err != nil {
+		t.Fatalf("Unmarshal(LLM schema) error = %v, want nil", err)
+	}
+	properties := decoded["properties"].(map[string]any)
+	spellCastProperties := properties["spell_casts"].(map[string]any)["items"].(map[string]any)["properties"].(map[string]any)
+	sourceRefItems := spellCastProperties["source_refs"].(map[string]any)["items"].(map[string]any)
+	sourceRefProperties := sourceRefItems["properties"].(map[string]any)
+	sourceRefRequired := sourceRefItems["required"].([]any)
+	if _, ok := sourceRefProperties["source_id"]; ok {
+		t.Fatalf("LLM source ref schema contains source_id property: %#v", sourceRefProperties)
+	}
+	if containsJSONField(sourceRefRequired, "source_id") {
+		t.Fatalf("LLM source refs required = %#v, want no source_id", sourceRefRequired)
+	}
+}
+
 func TestResponseSchemaJSONIsMutationSafe(t *testing.T) {
 	first, err := loadResponseSchema()
 	if err != nil {
@@ -89,3 +119,12 @@ func TestResponseSchemaDiagnosticsOmitRawSchema(t *testing.T) {
 		t.Fatalf("diagnostics should omit raw schema content: %#v", diagnostics)
 	}
 }
+
+func containsJSONField(fields []any, want string) bool {
+	for _, field := range fields {
+		if field == want {
+			return true
+		}
+	}
+	return false
+}