Make D&D prompt assets provider neutral

internal/modules/dnd/extract/spells/prompt_assets_test.go

@@ -0,0 +1,121 @@
+package spells
+
+import (
+	"context"
+	"encoding/json"
+	"strings"
+	"testing"
+	"time"
+
+	"gitea.maximumdirect.net/eric/notarius/internal/framework/llm"
+	"gitea.maximumdirect.net/eric/promptkit"
+)
+
+func TestPromptAssetsPrepareSpellPrompt(t *testing.T) {
+	transcript := []byte(`{"id":"session-1","segments":[{"id":"u1","text":"Mira casts shield."}]}`)
+	prepared := prepareSpellsPrompt(t, transcript, "Dana: Mira", "Mira: wizard", "Shield: abjuration")
+
+	if prepared.PromptID != PromptID {
+		t.Fatalf("prompt id = %q, want %q", prepared.PromptID, PromptID)
+	}
+	if prepared.OutputContract.SchemaPath != "dnd_spells_llm.v1.json" {
+		t.Fatalf("schema path = %q, want LLM-only schema", prepared.OutputContract.SchemaPath)
+	}
+}
+
+func TestPromptAssetsPrepareWithMissingOptionalReferences(t *testing.T) {
+	transcript := []byte(`{"id":"session-1","segments":[]}`)
+	prepared := prepareSpellsPrompt(t, transcript, " ", " ", " ")
+
+	for _, message := range prepared.Messages {
+		if strings.Contains(message.Content, "Player list reference:") && strings.Contains(message.Content, "Party roster reference:") && strings.Contains(message.Content, "Glossary reference:") {
+			return
+		}
+	}
+	t.Fatalf("reference message did not render empty optional reference placeholders")
+}
+
+func TestPromptAssetDiagnosticsOmitRawMaterials(t *testing.T) {
+	transcript := []byte(`{"secret":"source text"}`)
+	reference := "private party note"
+	prepared := prepareSpellsPrompt(t, transcript, "private player note", reference, " ")
+	metadata := newExtractor(t, &fakeSpellsLLMClient{}, overlaySpellCatalogReference()).ManifestMetadata()
+
+	payload, err := json.Marshal(map[string]any{
+		"prepared": map[string]any{
+			"prompt_id":              prepared.PromptID,
+			"prompt_version":         prepared.PromptVersion,
+			"prompt_hash":            prepared.PromptHash,
+			"rendered_prompt_hash":   prepared.RenderedPromptHash,
+			"selected_profile_id":    prepared.SelectedProfileID,
+			"output_contract":        prepared.OutputContract,
+			"input_hashes":           prepared.InputHashes,
+			"effective_model_params": prepared.EffectiveModelParams,
+		},
+		"manifest": metadata,
+	})
+	if err != nil {
+		t.Fatalf("marshal diagnostics: %v", err)
+	}
+	diagnostics := string(payload)
+	for _, forbidden := range []string{
+		"source text",
+		"private player note",
+		reference,
+		"Cure Wounds",
+		"Aegis of Emberfall",
+		"Emberfall Aegis",
+		"Private campaign source",
+		"file:///private-source.json",
+		`"properties"`,
+		"spell_casts",
+	} {
+		if strings.Contains(diagnostics, forbidden) {
+			t.Fatalf("diagnostics leaked %q: %s", forbidden, diagnostics)
+		}
+	}
+	if metadata["prompt_id"] != PromptID || metadata["prompt_version"] != SchemaVersion {
+		t.Fatalf("manifest prompt metadata = %#v", metadata)
+	}
+	if !strings.HasPrefix(metadata["prompt_sha256"].(string), "sha256:") {
+		t.Fatalf("manifest prompt hash = %#v, want sha256-prefixed", metadata["prompt_sha256"])
+	}
+}
+
+func prepareSpellsPrompt(t *testing.T, transcript []byte, players string, party string, glossary string) *promptkit.PreparedRun {
+	t.Helper()
+	registry := llm.NewAssetRegistry()
+	if err := RegisterPromptAssets(registry); err != nil {
+		t.Fatalf("register spell prompt assets: %v", err)
+	}
+	options, err := registry.PromptKitOptions()
+	if err != nil {
+		t.Fatalf("PromptKitOptions() error = %v, want nil", err)
+	}
+	options = append(options, promptkit.WithProfiles(promptkit.OpenAICompatibleProfile(promptkit.OpenAICompatibleProfileConfig{
+		ID:       "spell-test-profile",
+		Endpoint: "http://127.0.0.1:1/v1",
+		Model:    "spell-test-model",
+	})))
+	engine, err := promptkit.NewEngine(promptkit.Config{Timeout: time.Second}, options...)
+	if err != nil {
+		t.Fatalf("NewEngine() error = %v, want nil", err)
+	}
+	prepared, err := engine.Prepare(context.Background(), promptkit.RunRequest{
+		PromptID:      PromptID,
+		PromptVersion: SchemaVersion,
+		ProfileID:     "spell-test-profile",
+		Inputs: map[string]promptkit.ArtifactRef{
+			"transcript":    promptkit.InlineWithURI("file:///session.json", string(transcript)),
+			"spell_catalog": promptkit.Inline(`{"spell_names":["Cure Wounds"]}`),
+			"npcs":          promptkit.Inline(`{"npcs":[]}`),
+			"players":       promptkit.Inline(players),
+			"party":         promptkit.Inline(party),
+			"glossary":      promptkit.Inline(glossary),
+		},
+	})
+	if err != nil {
+		t.Fatalf("Prepare() error = %v, want nil", err)
+	}
+	return prepared
+}