Classify registry normalization diagnostics

internal/modules/dnd/shared/diagnostics/diagnostics_test.go

@@ -69,3 +69,26 @@ func TestDataQualityResultGroupsFindingsWithoutWarnings(t *testing.T) {
 		t.Fatalf("diagnostic = %#v", diagnostic)
 	}
 }
+
+func TestCollectGroupsNormalizationFindingsWithBoundedSamples(t *testing.T) {
+	findings := make([]contracts.Warning, 5)
+	for index := range findings {
+		findings[index] = contracts.Warning{
+			Scope:      fmt.Sprintf("records[%d]", index),
+			ReasonCode: "record_normalized",
+			Message:    fmt.Sprintf("record %d normalized", index),
+		}
+	}
+
+	groups, err := Collect(findings, contracts.DiagnosticDispositionObservation, contracts.DiagnosticCategoryNormalization)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if len(groups) != 1 {
+		t.Fatalf("groups = %#v, want one grouped observation", groups)
+	}
+	diagnostic := groups[0]
+	if diagnostic.Disposition != contracts.DiagnosticDispositionObservation || diagnostic.Category != contracts.DiagnosticCategoryNormalization || diagnostic.OccurrenceCount != 5 || len(diagnostic.Samples) != contracts.MaxDiagnosticSamples || diagnostic.OmittedSampleCount != 2 {
+		t.Fatalf("diagnostic = %#v", diagnostic)
+	}
+}