Move DnD shared prompt assets into helper package

internal/modules/sharedassets/dnd/assets.go

@@ -0,0 +1,47 @@
+package dnd
+
+import (
+	"embed"
+	"io/fs"
+
+	"gitea.maximumdirect.net/eric/notarius/internal/framework/llm"
+	"gitea.maximumdirect.net/eric/notarius/internal/modules/sharedassets"
+)
+
+//go:embed assets/prompts/*.md
+var embeddedAssets embed.FS
+
+var sharedPromptFiles = []string{
+	"common-dnd-system.md",
+	"common-dnd-transcript.md",
+	"common-dnd-references.md",
+}
+
+func SharedPromptFiles() []sharedassets.SharedPromptFile {
+	files := make([]sharedassets.SharedPromptFile, 0, len(sharedPromptFiles))
+	for _, name := range sharedPromptFiles {
+		files = append(files, sharedassets.SharedPromptFile{
+			Name: name,
+			FS:   embeddedAssets,
+			Path: "assets/prompts/" + name,
+		})
+	}
+	return files
+}
+
+func CommonHashParts() []llm.AssetHashPart {
+	return []llm.AssetHashPart{
+		{FS: embeddedAssets, Path: "assets/prompts/common-dnd-system.md"},
+		{FS: embeddedAssets, Path: "assets/prompts/common-dnd-transcript.md"},
+	}
+}
+
+func ReferenceHashParts() []llm.AssetHashPart {
+	return []llm.AssetHashPart{
+		{FS: embeddedAssets, Path: "assets/prompts/common-dnd-references.md"},
+	}
+}
+
+func ModulePromptFS(moduleDir string, moduleFS fs.FS, files []sharedassets.ModulePromptFile) (fs.FS, error) {
+	return sharedassets.ModulePromptFS(moduleDir, moduleFS, files, SharedPromptFiles()...)
+}

internal/modules/sharedassets/dnd/assets/prompts/common-dnd-references.md

@@ -0,0 +1,12 @@
+Optional reference material for this Dungeons & Dragons campaign is provided
+below. Use it only to disambiguate names, aliases, speakers, campaign terms, or
+spell names already present in the transcript.
+
+Player list reference:
+{{ input "players" }}
+
+Party roster reference:
+{{ input "party" }}
+
+Glossary reference:
+{{ input "glossary" }}

internal/modules/sharedassets/dnd/assets/prompts/common-dnd-system.md

@@ -0,0 +1,8 @@
+You work with Dungeons & Dragons gameplay transcripts.
+
+Use only the provided transcript and reference material. Source text may contain
+transcription errors, repeated lines, incomplete sentences, and misheard proper
+nouns. Reference material, when present, is supporting context only and must not
+be treated as a source of extracted events by itself.
+
+Return only valid JSON matching the configured response schema.

internal/modules/sharedassets/dnd/assets/prompts/common-dnd-transcript.md

@@ -0,0 +1,3 @@
+A transcript of a Dungeons & Dragons gameplay session is provided below.
+
+{{ input "transcript" }}

internal/modules/sharedassets/dnd/assets_test.go

@@ -0,0 +1,87 @@
+package dnd
+
+import (
+	"io/fs"
+	"testing"
+	"testing/fstest"
+
+	"gitea.maximumdirect.net/eric/notarius/internal/framework/llm"
+	"gitea.maximumdirect.net/eric/notarius/internal/modules/sharedassets"
+)
+
+func TestSharedPromptFilesReturnsNewSlice(t *testing.T) {
+	first := SharedPromptFiles()
+	second := SharedPromptFiles()
+
+	if len(first) != 3 || len(second) != 3 {
+		t.Fatalf("SharedPromptFiles() lengths = %d and %d, want 3", len(first), len(second))
+	}
+	first[0].Name = "changed.md"
+	if second[0].Name != "common-dnd-system.md" {
+		t.Fatalf("SharedPromptFiles() reused descriptor slice: %#v", second)
+	}
+}
+
+func TestSharedPromptFilesReferenceEmbeddedAssets(t *testing.T) {
+	for _, file := range SharedPromptFiles() {
+		if file.FS == nil {
+			t.Fatalf("SharedPromptFiles() descriptor %q has nil FS", file.Name)
+		}
+		if _, err := fs.ReadFile(file.FS, file.Path); err != nil {
+			t.Fatalf("ReadFile(%q) error = %v, want nil", file.Path, err)
+		}
+	}
+}
+
+func TestHashPartsReferenceSharedPrompts(t *testing.T) {
+	assertHashParts(t, "common", CommonHashParts(), []string{
+		"assets/prompts/common-dnd-system.md",
+		"assets/prompts/common-dnd-transcript.md",
+	})
+	assertHashParts(t, "reference", ReferenceHashParts(), []string{
+		"assets/prompts/common-dnd-references.md",
+	})
+
+	for _, part := range append(CommonHashParts(), ReferenceHashParts()...) {
+		if _, err := fs.ReadFile(part.FS, part.Path); err != nil {
+			t.Fatalf("ReadFile(%q) error = %v, want nil", part.Path, err)
+		}
+	}
+}
+
+func assertHashParts(t *testing.T, name string, parts []llm.AssetHashPart, want []string) {
+	t.Helper()
+	if len(parts) != len(want) {
+		t.Fatalf("%s hash parts length = %d, want %d", name, len(parts), len(want))
+	}
+	for i, part := range parts {
+		if part.Path != want[i] {
+			t.Fatalf("%s hash part %d path = %q, want %q", name, i, part.Path, want[i])
+		}
+		if part.FS == nil {
+			t.Fatalf("%s hash part %d has nil FS", name, i)
+		}
+	}
+}
+
+func TestModulePromptFSMountsDNDSharedPrompts(t *testing.T) {
+	fsys, err := ModulePromptFS("dnd.test", fstest.MapFS{
+		"assets/prompts/dnd.test.yaml": {Data: []byte("id: dnd.test")},
+	}, []sharedassets.ModulePromptFile{
+		{Name: "dnd.test.yaml", Path: "assets/prompts/dnd.test.yaml"},
+	})
+	if err != nil {
+		t.Fatalf("ModulePromptFS() error = %v, want nil", err)
+	}
+
+	for _, path := range []string{
+		"assets/prompts/dnd.test/dnd.test.yaml",
+		"assets/prompts/dnd.test/sharedassets/common-dnd-system.md",
+		"assets/prompts/dnd.test/sharedassets/common-dnd-transcript.md",
+		"assets/prompts/dnd.test/sharedassets/common-dnd-references.md",
+	} {
+		if _, err := fs.ReadFile(fsys, path); err != nil {
+			t.Fatalf("ReadFile(%q) error = %v, want nil", path, err)
+		}
+	}
+}