Finalize structured diagnostic aggregation

internal/modules/dnd/validate/itemoccurrences/source_relatedness/validator.go

@@ -45,13 +45,13 @@ func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationReq
 		return contracts.ValidationResult{Approved: true}, nil
 	}
 
-	warnings := make([]contracts.Warning, 0)
+	warnings := make([]diagnostics.Finding, 0)
 	for index, occurrence := range req.Value.Occurrences {
 		citedText, err := resolver.CitedText(occurrence.SourceRefs)
 		if err != nil || shared.ContainsTokenSequence(citedText, occurrence.Name) {
 			continue
 		}
-		warnings = append(warnings, contracts.Warning{
+		warnings = append(warnings, diagnostics.Finding{
 			Scope:      fmt.Sprintf("occurrences[%d]", index),
 			ReasonCode: ReasonCode,
 			Message:    fmt.Sprintf("item occurrence name %s was not found in cited source text", diagnostics.Quote(occurrence.Name)),