Add configuration inspection commands

internal/cli/configkit_commands_test.go

@@ -2,9 +2,16 @@ package cli
 
 import (
 	"bytes"
+	"context"
+	"errors"
+	"io"
 	"path/filepath"
 	"strings"
 	"testing"
+
+	"gitea.maximumdirect.net/eric/notarius/internal/core/artifacts"
+	"gitea.maximumdirect.net/eric/notarius/internal/core/config"
+	"gitea.maximumdirect.net/eric/notarius/internal/framework/contracts"
 )
 
 func TestConfigKitReadOnlyCommandsLoadImportsAndProfiles(t *testing.T) {
@@ -34,3 +41,92 @@ func TestConfigKitReadOnlyCommandsRejectVersionFour(t *testing.T) {
 		t.Fatalf("list = %d, %q", code, stderr.String())
 	}
 }
+
+func TestConfigurationInspectionCommandsRenderSafeConfigKitViews(t *testing.T) {
+	t.Parallel()
+	root := t.TempDir()
+	path := filepath.Join(root, "notarius.yml")
+	writeConfigKitFile(t, path, `version: 5
+concurrency:
+  total_llm: 4
+pipelines:
+  "0":
+    input: {module: input}
+`)
+	writeConfigKitFile(t, filepath.Join(root, "profiles", "development.yml"), "concurrency:\n  total_llm: 3\n")
+	writeConfigKitFile(t, filepath.Join(root, "profiles", "retired.yml"), "pipelines: null\n")
+
+	providerCalled := false
+	opts := commandContractOptions(t)
+	opts.LLMClientFactory = func(context.Context, config.Config, string, LLMRuntimeOverrides) (contracts.StructuredLLMClient, []artifacts.LLMProfileManifest, error) {
+		providerCalled = true
+		return nil, nil, errors.New("LLM client must not be constructed")
+	}
+
+	var stdout, stderr bytes.Buffer
+	if code := RunWithOptions([]string{"config", "effective", "--config", path, "--config-profile", "development"}, &stdout, &stderr, opts); code != 0 || !strings.Contains(stdout.String(), "total_llm: 3") || stderr.Len() != 0 {
+		t.Fatalf("effective = %d, %q, %q", code, stdout.String(), stderr.String())
+	}
+	if providerCalled {
+		t.Fatal("config effective constructed an LLM client")
+	}
+
+	stdout.Reset()
+	stderr.Reset()
+	if code := RunWithOptions([]string{"config", "explain", "--config", path, "--config-profile", "development", "/concurrency/total_llm"}, &stdout, &stderr, opts); code != 0 || !strings.Contains(stdout.String(), `path: "/concurrency/total_llm"`) || stderr.Len() != 0 {
+		t.Fatalf("explain effective = %d, %q, %q", code, stdout.String(), stderr.String())
+	}
+
+	stdout.Reset()
+	stderr.Reset()
+	if code := RunWithOptions([]string{"config", "explain", "--config", path, ""}, &stdout, &stderr, opts); code != 0 || !strings.Contains(stdout.String(), `path: ""`) || stderr.Len() != 0 {
+		t.Fatalf("explain root = %d, %q, %q", code, stdout.String(), stderr.String())
+	}
+
+	stdout.Reset()
+	stderr.Reset()
+	if code := RunWithOptions([]string{"config", "explain", "--config", path, "--config-profile", "retired", "/pipelines/0"}, &stdout, &stderr, opts); code != 0 || !strings.Contains(stdout.String(), `path: "/pipelines/0"`) || stderr.Len() != 0 {
+		t.Fatalf("explain removed mapping key = %d, %q, %q", code, stdout.String(), stderr.String())
+	}
+}
+
+func TestConfigExplainRejectsInvalidAndUnknownPointers(t *testing.T) {
+	t.Parallel()
+	path := writeCommandConfig(t, "session", "other")
+	for _, test := range []struct {
+		name     string
+		pointer  string
+		wantCode int
+	}{
+		{name: "missing", wantCode: 2},
+		{name: "malformed escape", pointer: "/pipelines~2session", wantCode: 2},
+		{name: "unknown", pointer: "/unknown", wantCode: 1},
+		{name: "invalid sequence index", pointer: "/pipelines/session/steps/+0", wantCode: 1},
+	} {
+		t.Run(test.name, func(t *testing.T) {
+			var stdout, stderr bytes.Buffer
+			args := []string{"config", "explain", "--config", path}
+			if test.name != "missing" {
+				args = append(args, test.pointer)
+			}
+			if code := RunWithOptions(args, &stdout, &stderr, commandContractOptions(t)); code != test.wantCode || stdout.Len() != 0 || stderr.Len() == 0 {
+				t.Fatalf("code=%d stdout=%q stderr=%q", code, stdout.String(), stderr.String())
+			}
+		})
+	}
+}
+
+func TestConfigInspectionCommandsReportWriterFailures(t *testing.T) {
+	t.Parallel()
+	path := writeCommandConfig(t, "session", "other")
+	var stderr bytes.Buffer
+	if code := RunWithOptions([]string{"config", "effective", "--config", path}, failingInspectionWriter{}, &stderr, commandContractOptions(t)); code != 1 || !strings.Contains(stderr.String(), "write effective configuration") {
+		t.Fatalf("effective writer failure = %d, %q", code, stderr.String())
+	}
+}
+
+type failingInspectionWriter struct{}
+
+func (failingInspectionWriter) Write([]byte) (int, error) {
+	return 0, io.ErrClosedPipe
+}