eric/notarius
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Finalize D&D prompt integration and documentation

Browse Source
This commit is contained in:
Eric Rakestraw
2026-07-21 14:58:26 +00:00
parent b344d16dc1
commit 3ba2bfd7f6
8 changed files with 105 additions and 236 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
internal/modules/dnd/chunk/scenes/scriptorium_assets_test.go
View File

@@ -18,29 +18,29 @@ func TestScriptoriumPromptPreparesTranscriptAndTaskMessages(t *testing.T) {
if prepared.PromptID != PromptID {
t.Fatalf("prompt id = %q, want %q", prepared.PromptID, PromptID)
}
if got := len(prepared.Messages); got != 5 {
t.Fatalf("message count = %d, want 5", got)
transcriptMessages := 0
referenceMessageFound := false
for _, message := range prepared.Messages {
if strings.Contains(message.Content, string(transcript)) {
transcriptMessages++
if message.Role != "user" || message.CacheControl == nil {
t.Fatalf("transcript message did not render as cacheable user message: %#v", message)
}
}
if strings.Contains(message.Content, "Alice: Aria") &&
strings.Contains(message.Content, "Aria: cleric") &&
strings.Contains(message.Content, "Brightmantle: temple") {
referenceMessageFound = true
if message.Role != "user" || message.CacheControl == nil {
t.Fatalf("reference message did not render as cacheable user message: %#v", message)
}
}
}
if prepared.Messages[1].Role != "user" || prepared.Messages[1].CacheControl == nil {
t.Fatalf("transcript message did not render as cacheable user message: %#v", prepared.Messages[1])
if transcriptMessages != 1 {
t.Fatalf("raw transcript rendered in %d messages, want exactly one", transcriptMessages)
}
if !strings.Contains(prepared.Messages[1].Content, string(transcript)) {
t.Fatalf("transcript message did not include source input")
}
if prepared.Messages[2].CacheControl == nil {
t.Fatalf("reference message did not render as cacheable user message: %#v", prepared.Messages[2])
}
if !strings.Contains(prepared.Messages[2].Content, "Alice: Aria") {
t.Fatalf("reference message missing player content")
}
if !strings.Contains(prepared.Messages[2].Content, "Aria: cleric") {
t.Fatalf("reference message missing party content")
}
if !strings.Contains(prepared.Messages[2].Content, "Brightmantle: temple") {
t.Fatalf("reference message missing glossary content")
}
if strings.Contains(prepared.Messages[3].Content, string(transcript)) {
t.Fatalf("task message leaked transcript bytes")
if !referenceMessageFound {
t.Fatalf("reference message did not render all supplied reference material")
}
}

7
internal/modules/dnd/normalize/combatturns/normalizer.go
View File

@@ -19,7 +19,8 @@ import (
const (
Key = "dnd/combat-turns"
NormalizationPolicy = "dnd.combat_turns.normalize.v1"
normalizationPolicy = "dnd.combat_turns.normalize.v1"
NormalizationPolicy = normalizationPolicy
ReasonCodeFieldsNormalized = "combat_turn_fields_normalized"
ReasonCodeActorCanonicalized = "combat_actor_canonicalized"
@@ -71,7 +72,7 @@ func (n *Normalizer) ManifestMetadata() map[string]any {
return nil
}
metadata := map[string]any{
"normalization_policy": NormalizationPolicy,
"normalization_policy": normalizationPolicy,
"identity_policy": identity.Policy,
}
if n.npcRegistry.Bound() {
@@ -86,7 +87,7 @@ func (n *Normalizer) CheckpointFingerprints() []pipeline.CheckpointFingerprint {
return nil
}
fingerprints := []pipeline.CheckpointFingerprint{
{Name: "normalization_policy", Value: NormalizationPolicy},
{Name: "normalization_policy", Value: normalizationPolicy},
{Name: "identity_policy", Value: identity.Policy},
}
if n.npcRegistry.Bound() {

2
internal/modules/dnd/normalize/combatturns/normalizer_test.go
View File

@@ -189,7 +189,7 @@ func TestNormalizerPreparationMetadataFingerprintsAndModuleContract(t *testing.T
if err != nil {
t.Fatalf("New() error = %v", err)
}
if metadata := unbound.ManifestMetadata(); metadata["npc_registry_digest"] != nil || metadata["npc_count"] != nil || metadata["normalization_policy"] != NormalizationPolicy || metadata["identity_policy"] != identity.Policy {
if metadata := unbound.ManifestMetadata(); metadata["npc_registry_digest"] != nil || metadata["npc_count"] != nil || metadata["normalization_policy"] != normalizationPolicy || metadata["identity_policy"] != identity.Policy {
t.Fatalf("unbound metadata = %#v", metadata)
}
if got := unbound.CheckpointFingerprints(); len(got) != 2 || got[0].Name != "normalization_policy" || got[1].Name != "identity_policy" {

7
internal/modules/dnd/normalize/npcs/normalizer.go
View File

@@ -19,7 +19,8 @@ import (
const (
Key = "dnd/npcs"
NormalizationPolicy = "dnd.npcs.normalize.v1"
normalizationPolicy = "dnd.npcs.normalize.v1"
NormalizationPolicy = normalizationPolicy
ReasonCodeNPCFieldsNormalized = "npc_fields_normalized"
ReasonCodeNPCIDRecomputed = "npc_id_recomputed"
@@ -51,7 +52,7 @@ func (n *Normalizer) ManifestMetadata() map[string]any {
}
return map[string]any{
"identity_policy": identity.Policy,
"normalization_policy": NormalizationPolicy,
"normalization_policy": normalizationPolicy,
}
}
@@ -61,7 +62,7 @@ func (n *Normalizer) CheckpointFingerprints() []pipeline.CheckpointFingerprint {
}
return []pipeline.CheckpointFingerprint{
{Name: "identity_policy", Value: identity.Policy},
{Name: "normalization_policy", Value: NormalizationPolicy},
{Name: "normalization_policy", Value: normalizationPolicy},
}
}

10
internal/modules/dnd/normalize/npcs/normalizer_test.go
View File

@@ -10,7 +10,7 @@ import (
"gitea.maximumdirect.net/eric/notarius/internal/framework/contracts"
"gitea.maximumdirect.net/eric/notarius/internal/framework/pipeline"
"gitea.maximumdirect.net/eric/notarius/internal/modules/dnd"
domainidentity "gitea.maximumdirect.net/eric/notarius/internal/modules/dnd/npcs/identity"
identity "gitea.maximumdirect.net/eric/notarius/internal/modules/dnd/npcs/identity"
)
func TestModuleContractAndIdentity(t *testing.T) {
@@ -48,13 +48,13 @@ func TestModuleContractAndIdentity(t *testing.T) {
normalizer := New(Options{})
metadata := normalizer.ManifestMetadata()
if metadata["identity_policy"] != domainidentity.Policy || metadata["normalization_policy"] != NormalizationPolicy {
if metadata["identity_policy"] != identity.Policy || metadata["normalization_policy"] != normalizationPolicy {
t.Fatalf("metadata = %#v, want identity and normalization policies", metadata)
}
fingerprints := normalizer.CheckpointFingerprints()
wantFingerprints := []pipeline.CheckpointFingerprint{
{Name: "identity_policy", Value: domainidentity.Policy},
{Name: "normalization_policy", Value: NormalizationPolicy},
{Name: "identity_policy", Value: identity.Policy},
{Name: "normalization_policy", Value: normalizationPolicy},
}
if !reflect.DeepEqual(fingerprints, wantFingerprints) {
t.Fatalf("fingerprints = %#v, want %#v", fingerprints, wantFingerprints)
@@ -104,7 +104,7 @@ func TestNormalizePerRecordFieldsAndEvidence(t *testing.T) {
if !reflect.DeepEqual(got.SourceRefs, wantRefs) {
t.Fatalf("source refs = %#v, want %#v", got.SourceRefs, wantRefs)
}
if got.ID != domainidentity.DeriveID("Lady Ash") {
if got.ID != identity.DeriveID("Lady Ash") {
t.Fatalf("ID = %q, want derived ID", got.ID)
}
if !hasWarning(result.Warnings, ReasonCodeNPCFieldsNormalized, "npcs[0]") ||