Bound D&D normalization diagnostics

internal/modules/dnd/validate/combatturns/source_relatedness/validator.go

@@ -15,6 +15,7 @@ import (
 const (
 	Key               = "extract/dnd/combat-turns/source_relatedness"
 	WarningReasonCode = "combat_turn_not_near_source"
+	OmittedReasonCode = "combat_turn_relatedness_warnings_omitted"
 	policy            = "dnd.combat_turns.validator.source_relatedness.v2"
 )
 
@@ -64,7 +65,10 @@ func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationReq
 			}),
 		})
 	}
-	return contracts.ValidationResult{Approved: true, Warnings: warnings}, nil
+	return contracts.ValidationResult{
+		Approved: true,
+		Warnings: diagnostics.LimitWarnings(warnings, "combat_turns", OmittedReasonCode),
+	}, nil
 }
 func actorAppearsInCitedText(citedText string, actor string) bool {
 	return shared.ContainsTokenSequence(citedText, actor)

internal/modules/dnd/validate/combatturns/source_relatedness/validator_test.go

@@ -10,6 +10,7 @@ import (
 	"gitea.maximumdirect.net/eric/notarius/internal/framework/contracts"
 	"gitea.maximumdirect.net/eric/notarius/internal/framework/pipeline"
 	"gitea.maximumdirect.net/eric/notarius/internal/modules/dnd"
+	"gitea.maximumdirect.net/eric/notarius/internal/modules/dnd/shared/diagnostics"
 )
 
 func TestValidatorUsesDocumentOrderAndUnicodeComparisonForActor(t *testing.T) {
@@ -45,6 +46,34 @@ func TestValidatorWarnsOncePerTurnForUnrelatedActor(t *testing.T) {
 	}
 }
 
+func TestValidatorLimitsUnrelatedActorWarnings(t *testing.T) {
+	turns := make([]dnd.CombatTurn, diagnostics.MaxWarnings+1)
+	for index := range turns {
+		turns[index] = dnd.CombatTurn{
+			Actor:      "Missing Actor",
+			TurnKind:   dnd.CombatTurnKindTurn,
+			SourceRefs: []source.SourceRef{{SourceID: "session", StartUnitID: 1, EndUnitID: 1}},
+		}
+	}
+	result, err := New(Options{}).Validate(context.Background(), contracts.TypedValidationRequest[dnd.CombatTurnList]{
+		Source: relatednessDocument(),
+		Value:  dnd.CombatTurnList{CombatTurns: turns},
+	})
+	if err != nil || !result.Approved {
+		t.Fatalf("Validate() = %#v, %v", result, err)
+	}
+	if len(result.Warnings) != diagnostics.MaxWarnings {
+		t.Fatalf("warning count = %d, want %d", len(result.Warnings), diagnostics.MaxWarnings)
+	}
+	if first := result.Warnings[0]; first.Scope != "combat_turns[0]" || first.ReasonCode != WarningReasonCode {
+		t.Fatalf("first warning = %#v, want first turn warning", first)
+	}
+	summary := result.Warnings[len(result.Warnings)-1]
+	if summary.Scope != "combat_turns" || summary.ReasonCode != OmittedReasonCode || summary.Message != "2 additional warning(s) omitted" {
+		t.Fatalf("warning summary = %#v", summary)
+	}
+}
+
 func TestValidatorDoesNotMatchShortActorSubstring(t *testing.T) {
 	value := dnd.CombatTurnList{CombatTurns: []dnd.CombatTurn{{
 		Actor: "Art", TurnKind: dnd.CombatTurnKindTurn,