Tighten D&D prompt contracts and tests

internal/modules/dnd/extract/locations/prompt_assets_test.go

@@ -2,7 +2,6 @@ package locations
 
 import (
 	"context"
-	"strings"
 	"testing"
 	"time"
 
@@ -30,34 +29,7 @@ func TestRegisterPromptAssetsPreparesLocationPrompt(t *testing.T) {
 	if err != nil {
 		t.Fatalf("Prepare() error = %v", err)
 	}
-	if prepared.OutputContract.SchemaPath != "dnd_locations_llm.v1.json" {
-		t.Fatalf("output contract = %#v", prepared.OutputContract)
-	}
-	referenceIndex := -1
-	transcriptIndex := -1
-	for index, message := range prepared.Messages {
-		if strings.Contains(message.Content, "location-player") {
-			referenceIndex = index
-		}
-		if strings.Contains(message.Content, "location-transcript") {
-			transcriptIndex = index
-		}
-	}
-	instructionsIndex := len(prepared.Messages) - 1
-	if referenceIndex < 0 || transcriptIndex <= referenceIndex || transcriptIndex >= instructionsIndex {
-		t.Fatalf("message order = references %d, transcript %d, instructions %d; want that order", referenceIndex, transcriptIndex, instructionsIndex)
-	}
-	for _, index := range []int{referenceIndex, transcriptIndex, instructionsIndex} {
-		if prepared.Messages[index].CacheControl == nil || prepared.Messages[index].CacheControl.Type != promptkit.CacheControlEphemeral {
-			t.Fatalf("message %d cache control = %#v, want ephemeral", index, prepared.Messages[index].CacheControl)
-		}
-	}
-	for index, message := range prepared.Messages {
-		if index != referenceIndex && strings.Contains(message.Content, "location-player") {
-			t.Errorf("message %d unexpectedly rendered campaign-reference input", index)
-		}
-		if index != transcriptIndex && strings.Contains(message.Content, "location-transcript") {
-			t.Errorf("message %d unexpectedly rendered transcript input", index)
-		}
+	if prepared.PromptID != PromptID || prepared.OutputContract.SchemaPath != "dnd_locations_llm.v1.json" {
+		t.Fatalf("prepared prompt = %#v, want location prompt identity and schema wiring", prepared)
 	}
 }