Add feedback-aware correction contracts

internal/modules/dnd/chunk/scenes/chunker_test.go

@@ -533,6 +533,11 @@ func (client *fakeScenesLLMClient) CompleteStructured(ctx context.Context, req c
 
 func cloneStructuredCompletionRequest(req contracts.StructuredCompletionRequest) contracts.StructuredCompletionRequest {
 	req.Inputs = req.Inputs.Clone()
+	correction, err := contracts.CloneSemanticCorrection(req.Correction)
+	if err != nil {
+		panic(err)
+	}
+	req.Correction = correction
 	req.Vars = cloneVars(req.Vars)
 	return req
 }

internal/modules/dnd/extract/combatturns/extractor_test.go

@@ -592,6 +592,11 @@ func (client *fakeCombatTurnsLLMClient) CompleteStructured(_ context.Context, re
 
 func cloneStructuredCompletionRequest(req contracts.StructuredCompletionRequest) contracts.StructuredCompletionRequest {
 	req.Inputs = req.Inputs.Clone()
+	correction, err := contracts.CloneSemanticCorrection(req.Correction)
+	if err != nil {
+		panic(err)
+	}
+	req.Correction = correction
 	if len(req.Vars) == 0 {
 		req.Vars = nil
 		return req

internal/modules/dnd/extract/itemoccurrences/test_helpers_test.go

@@ -58,6 +58,11 @@ func newExtractor(t *testing.T, client contracts.StructuredLLMClient, references
 
 func cloneStructuredCompletionRequest(req contracts.StructuredCompletionRequest) contracts.StructuredCompletionRequest {
 	req.Inputs = req.Inputs.Clone()
+	correction, err := contracts.CloneSemanticCorrection(req.Correction)
+	if err != nil {
+		panic(err)
+	}
+	req.Correction = correction
 	return req
 }
 

internal/modules/dnd/extract/itemregistry/test_helpers_test.go

@@ -88,5 +88,10 @@ func (client *fakeItemsLLMClient) CompleteStructured(ctx context.Context, req co
 
 func cloneStructuredCompletionRequest(req contracts.StructuredCompletionRequest) contracts.StructuredCompletionRequest {
 	req.Inputs = req.Inputs.Clone()
+	correction, err := contracts.CloneSemanticCorrection(req.Correction)
+	if err != nil {
+		panic(err)
+	}
+	req.Correction = correction
 	return req
 }

internal/modules/dnd/extract/locationoccurrences/test_helpers_test.go

@@ -78,5 +78,10 @@ func (client *fakeOccurrencesLLMClient) CompleteStructured(_ context.Context, re
 
 func cloneStructuredCompletionRequest(req contracts.StructuredCompletionRequest) contracts.StructuredCompletionRequest {
 	req.Inputs = req.Inputs.Clone()
+	correction, err := contracts.CloneSemanticCorrection(req.Correction)
+	if err != nil {
+		panic(err)
+	}
+	req.Correction = correction
 	return req
 }

internal/modules/dnd/extract/locationregistry/test_helpers_test.go

@@ -85,5 +85,10 @@ func (client *fakeLocationsLLMClient) CompleteStructured(_ context.Context, req
 
 func cloneStructuredCompletionRequest(req contracts.StructuredCompletionRequest) contracts.StructuredCompletionRequest {
 	req.Inputs = req.Inputs.Clone()
+	correction, err := contracts.CloneSemanticCorrection(req.Correction)
+	if err != nil {
+		panic(err)
+	}
+	req.Correction = correction
 	return req
 }

internal/modules/dnd/extract/npcoccurrences/extractor_test.go

@@ -452,5 +452,10 @@ func (client *fakeOccurrencesLLMClient) CompleteStructured(_ context.Context, re
 
 func cloneStructuredCompletionRequest(req contracts.StructuredCompletionRequest) contracts.StructuredCompletionRequest {
 	req.Inputs = req.Inputs.Clone()
+	correction, err := contracts.CloneSemanticCorrection(req.Correction)
+	if err != nil {
+		panic(err)
+	}
+	req.Correction = correction
 	return req
 }

internal/modules/dnd/extract/npcregistry/test_helpers_test.go

@@ -65,6 +65,11 @@ func mismatchedSourceInputRequest(req contracts.TypedExtractionRequest) contract
 
 func cloneStructuredCompletionRequest(req contracts.StructuredCompletionRequest) contracts.StructuredCompletionRequest {
 	req.Inputs = req.Inputs.Clone()
+	correction, err := contracts.CloneSemanticCorrection(req.Correction)
+	if err != nil {
+		panic(err)
+	}
+	req.Correction = correction
 	if len(req.Vars) == 0 {
 		req.Vars = nil
 		return req

internal/modules/dnd/extract/scenedescriptions/test_helpers_test.go

@@ -61,6 +61,11 @@ func mismatchedSourceInputRequest(req contracts.TypedExtractionRequest) contract
 
 func cloneStructuredCompletionRequest(req contracts.StructuredCompletionRequest) contracts.StructuredCompletionRequest {
 	req.Inputs = req.Inputs.Clone()
+	correction, err := contracts.CloneSemanticCorrection(req.Correction)
+	if err != nil {
+		panic(err)
+	}
+	req.Correction = correction
 	if len(req.Vars) == 0 {
 		req.Vars = nil
 		return req

internal/modules/dnd/extract/spells/test_helpers_test.go

@@ -163,6 +163,11 @@ func (client *fakeSpellsLLMClient) CompleteStructured(_ context.Context, req con
 
 func cloneStructuredCompletionRequest(req contracts.StructuredCompletionRequest) contracts.StructuredCompletionRequest {
 	req.Inputs = req.Inputs.Clone()
+	correction, err := contracts.CloneSemanticCorrection(req.Correction)
+	if err != nil {
+		panic(err)
+	}
+	req.Correction = correction
 	if len(req.Vars) == 0 {
 		req.Vars = nil
 		return req

internal/modules/dnd/normalize/itemregistry/normalizer_test.go

@@ -366,7 +366,11 @@ type recordingNormalizerClient struct {
 }
 
 func (c *recordingNormalizerClient) CompleteStructured(_ context.Context, request contracts.StructuredCompletionRequest, output any) (contracts.StructuredCompletionResponse, error) {
-	c.requests = append(c.requests, request)
+	snapshot, err := contracts.CloneStructuredCompletionRequest(request)
+	if err != nil {
+		return contracts.StructuredCompletionResponse{}, fmt.Errorf("clone recording request: %w", err)
+	}
+	c.requests = append(c.requests, snapshot)
 	if c.err != nil {
 		return contracts.StructuredCompletionResponse{}, c.err
 	}

internal/modules/dnd/normalize/locationregistry/test_helpers_test.go

@@ -3,6 +3,7 @@ package locationregistry
 import (
 	"context"
 	"encoding/json"
+	"fmt"
 	"testing"
 
 	"gitea.maximumdirect.net/eric/notarius/internal/core/source"
@@ -17,7 +18,11 @@ type recordingLocationNormalizerClient struct {
 }
 
 func (c *recordingLocationNormalizerClient) CompleteStructured(_ context.Context, request contracts.StructuredCompletionRequest, output any) (contracts.StructuredCompletionResponse, error) {
-	c.requests = append(c.requests, request)
+	snapshot, err := contracts.CloneStructuredCompletionRequest(request)
+	if err != nil {
+		return contracts.StructuredCompletionResponse{}, fmt.Errorf("clone recording request: %w", err)
+	}
+	c.requests = append(c.requests, snapshot)
 	if c.err != nil {
 		return contracts.StructuredCompletionResponse{}, c.err
 	}

internal/modules/dnd/normalize/npcregistry/normalizer_test.go

@@ -3,6 +3,7 @@ package npcregistry
 import (
 	"context"
 	"encoding/json"
+	"fmt"
 	"reflect"
 	"strings"
 	"testing"
@@ -148,7 +149,11 @@ type recordingNPCNormalizerClient struct {
 }
 
 func (c *recordingNPCNormalizerClient) CompleteStructured(_ context.Context, request contracts.StructuredCompletionRequest, output any) (contracts.StructuredCompletionResponse, error) {
-	c.requests = append(c.requests, request)
+	snapshot, err := contracts.CloneStructuredCompletionRequest(request)
+	if err != nil {
+		return contracts.StructuredCompletionResponse{}, fmt.Errorf("clone recording request: %w", err)
+	}
+	c.requests = append(c.requests, snapshot)
 	if c.err != nil {
 		return contracts.StructuredCompletionResponse{}, c.err
 	}

internal/modules/integration/dnd_combat_runner_test.go

@@ -375,8 +375,12 @@ func (client *fakeCombatLLMClient) CompleteStructured(ctx context.Context, req c
 	if err := ctx.Err(); err != nil {
 		return contracts.StructuredCompletionResponse{}, err
 	}
+	snapshot, err := contracts.CloneStructuredCompletionRequest(req)
+	if err != nil {
+		return contracts.StructuredCompletionResponse{}, fmt.Errorf("clone fake request: %w", err)
+	}
 	client.mu.Lock()
-	client.requests = append(client.requests, req)
+	client.requests = append(client.requests, snapshot)
 	index := len(client.requests) - 1
 	client.mu.Unlock()
 	if index >= len(client.responses) {

internal/modules/integration/dnd_npc_registry_runner_test.go

@@ -240,7 +240,11 @@ type fakeNPCProductionLLMClient struct {
 }
 
 func (client *fakeNPCProductionLLMClient) CompleteStructured(_ context.Context, req contracts.StructuredCompletionRequest, out any) (contracts.StructuredCompletionResponse, error) {
-	client.requests = append(client.requests, req)
+	snapshot, err := contracts.CloneStructuredCompletionRequest(req)
+	if err != nil {
+		return contracts.StructuredCompletionResponse{}, fmt.Errorf("clone fake request: %w", err)
+	}
+	client.requests = append(client.requests, snapshot)
 	var content []byte
 	switch req.PromptID {
 	case npcregistry.PromptID:

internal/modules/integration/dnd_spells_helpers_test.go

@@ -71,6 +71,11 @@ func responseSourceRefs(startUnitID int, endUnitID int) []spellSourceRefResponse
 
 func cloneStructuredCompletionRequest(req contracts.StructuredCompletionRequest) contracts.StructuredCompletionRequest {
 	req.Inputs = req.Inputs.Clone()
+	correction, err := contracts.CloneSemanticCorrection(req.Correction)
+	if err != nil {
+		panic(err)
+	}
+	req.Correction = correction
 	if len(req.Vars) == 0 {
 		req.Vars = nil
 		return req