Require chunk-local extraction evidence

internal/modules/dnd/validate/combatturns/source_refs/validator.go

@@ -15,7 +15,7 @@ import (
 const (
 	Key        = "extract/dnd/combat-turns/source_refs"
 	ReasonCode = "invalid_combat_turn_source_refs"
-	policy     = "dnd.combat_turns.validator.source_refs.v1"
+	policy     = "dnd.combat_turns.validator.source_refs.v2"
 )
 
 type Options struct{}
@@ -34,10 +34,17 @@ func (v *Validator) CheckpointFingerprints() []pipeline.CheckpointFingerprint {
 }
 
 func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationRequest[dnd.CombatTurnList]) (contracts.ValidationResult, error) {
+	if req.Stage == string(pipeline.StageExtract) && req.Chunk == nil {
+		return contracts.ValidationResult{}, fmt.Errorf("combat-turn source-reference validator requires the current extraction chunk")
+	}
 	if err := combatshape.Validate(req.Value); err != nil {
 		return contracts.ValidationResult{Approved: true}, nil
 	}
-	issues := sourceRefIssues(source.NewDocumentIndex(req.Source), req.Value)
+	var coverage *chunkCoverage
+	if req.Stage == string(pipeline.StageExtract) {
+		coverage = newChunkCoverage(req.Chunk)
+	}
+	issues := sourceRefIssues(source.NewDocumentIndex(req.Source), req.Source, coverage, req.Value)
 	if len(issues) == 0 {
 		return contracts.ValidationResult{Approved: true}, nil
 	}
@@ -48,18 +55,52 @@ func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationReq
 	}, nil
 }
 
-func sourceRefIssues(index source.DocumentIndex, value dnd.CombatTurnList) []string {
+func sourceRefIssues(index source.DocumentIndex, doc *source.SourceDocument, coverage *chunkCoverage, value dnd.CombatTurnList) []string {
 	issues := make([]string, 0)
 	for turnIndex, turn := range value.CombatTurns {
 		for refIndex, ref := range turn.SourceRefs {
 			if err := index.ValidateRef(ref); err != nil {
 				issues = append(issues, fmt.Sprintf("combat_turns[%d].source_refs[%d]: %s", turnIndex, refIndex, diagnostics.Truncate(err.Error())))
+				continue
+			}
+			if coverage != nil && !coverage.contains(doc, ref) {
+				issues = append(issues, fmt.Sprintf("combat_turns[%d].source_refs[%d]: source reference is outside the current extraction chunk", turnIndex, refIndex))
 			}
 		}
 	}
 	return issues
 }
 
+type chunkCoverage struct {
+	sourceID string
+	unitIDs  map[int]struct{}
+}
+
+func newChunkCoverage(chunk *source.Chunk) *chunkCoverage {
+	coverage := &chunkCoverage{sourceID: chunk.SourceID, unitIDs: make(map[int]struct{}, len(chunk.Units))}
+	for _, unit := range chunk.Units {
+		coverage.unitIDs[unit.ID] = struct{}{}
+	}
+	return coverage
+}
+
+func (coverage *chunkCoverage) contains(doc *source.SourceDocument, ref source.SourceRef) bool {
+	if coverage == nil || doc == nil || ref.SourceID != coverage.sourceID {
+		return false
+	}
+	start, startOK := source.UnitIndex(doc, ref.StartUnitID)
+	end, endOK := source.UnitIndex(doc, ref.EndUnitID)
+	if !startOK || !endOK || start > end {
+		return false
+	}
+	for position := start; position <= end; position++ {
+		if _, found := coverage.unitIDs[doc.Units[position].ID]; !found {
+			return false
+		}
+	}
+	return true
+}
+
 func Spec() pipeline.ValidatorSpec {
 	return pipeline.ValidatorSpec{Key: Key, ExecutionClass: contracts.ExecutionClassDeterministic}
 }

internal/modules/dnd/validate/combatturns/source_refs/validator_test.go

@@ -46,6 +46,39 @@ func TestValidatorRejectsInvalidSourceIdentityExistenceAndOrder(t *testing.T) {
 	}
 }
 
+func TestValidatorEnforcesCurrentChunkEvidenceDuringExtraction(t *testing.T) {
+	doc := validDocument()
+	value := validCombatTurnList()
+	value.CombatTurns[0].SourceRefs[0].EndUnitID = 2
+	req := contracts.TypedValidationRequest[dnd.CombatTurnList]{
+		Stage:  string(pipeline.StageExtract),
+		Source: doc,
+		Chunk:  &source.Chunk{SourceID: doc.ID, Units: append([]source.SourceUnit(nil), doc.Units...)},
+		Value:  value,
+	}
+	result, err := New(Options{}).Validate(context.Background(), req)
+	if err != nil || !result.Approved {
+		t.Fatalf("in-chunk extraction evidence = %#v, %v; want approval", result, err)
+	}
+
+	req.Chunk = &source.Chunk{SourceID: doc.ID, Units: []source.SourceUnit{{ID: 1}}}
+	result, err = New(Options{}).Validate(context.Background(), req)
+	if err != nil || result.Approved || !strings.Contains(result.Message, "outside the current extraction chunk") {
+		t.Fatalf("off-chunk extraction evidence = %#v, %v; want rejection", result, err)
+	}
+
+	req.Chunk = nil
+	if _, err = New(Options{}).Validate(context.Background(), req); err == nil || !strings.Contains(err.Error(), "requires the current extraction chunk") {
+		t.Fatalf("missing extraction chunk error = %v", err)
+	}
+
+	req.Stage = string(pipeline.StageNormalize)
+	result, err = New(Options{}).Validate(context.Background(), req)
+	if err != nil || !result.Approved {
+		t.Fatalf("document-wide normalization evidence = %#v, %v; want approval", result, err)
+	}
+}
+
 func TestValidatorDefersMalformedShape(t *testing.T) {
 	value := dnd.CombatTurnList{CombatTurns: []dnd.CombatTurn{{Actor: "Aria"}}}
 	result, err := New(Options{}).Validate(context.Background(), contracts.TypedValidationRequest[dnd.CombatTurnList]{Source: validDocument(), Value: value})