Centralize shared D&D LLM assets

internal/modules/dnd/shared/entityreconcile/assets.go

@@ -1,6 +0,0 @@
-package entityreconcile
-
-import "embed"
-
-//go:embed assets/schemas/dnd_entity_reconcile_llm.v1.json
-var embeddedAssets embed.FS

internal/modules/dnd/shared/entityreconcile/assets/schemas/dnd_entity_reconcile_llm.v1.json

@@ -1,24 +0,0 @@
-{
-  "$schema": "https://json-schema.org/draft/2020-12/schema",
-  "$id": "notarius.dnd.entity_reconcile.llm",
-  "type": "object",
-  "additionalProperties": false,
-  "required": ["duplicate_groups"],
-  "properties": {
-    "duplicate_groups": {
-      "type": "array",
-      "items": {
-        "type": "object",
-        "additionalProperties": false,
-        "required": ["members", "canonical"],
-        "properties": {
-          "members": {
-            "type": "array",
-            "items": {"type": "string"}
-          },
-          "canonical": {"type": "string"}
-        }
-      }
-    }
-  }
-}

internal/modules/dnd/shared/entityreconcile/schema.go

@@ -1,6 +1,10 @@
 package entityreconcile
 
 import (
+	"fmt"
+	"io/fs"
+
+	rootassets "gitea.maximumdirect.net/eric/notarius/assets"
 	"gitea.maximumdirect.net/eric/notarius/internal/framework/llm"
 )
 
@@ -9,13 +13,25 @@ const (
 	ResponseSchemaID   = "notarius.dnd.entity_reconcile.llm"
 	ResponseSchemaName = "notarius_dnd_entity_reconcile_llm_v1"
 	SchemaVersion      = "v1"
-	SchemaAssetPath    = "assets/schemas/dnd_entity_reconcile_llm.v1.json"
+	SchemaAssetPath    = "schemas/dnd_entity_reconcile_llm.v1.json"
 )
 
+func schemaAssetFS() (fs.FS, error) {
+	assets, err := fs.Sub(rootassets.FS(), "dnd/entity-reconciliation")
+	if err != nil {
+		return nil, fmt.Errorf("scope entity reconciliation assets: %w", err)
+	}
+	return assets, nil
+}
+
 // LoadResponseSchema returns the shared private duplicate-group response
 // contract. It is intentionally separate from durable artifact schemas.
 func LoadResponseSchema() (llm.ResponseSchema, error) {
-	return llm.LoadResponseSchema(embeddedAssets, llm.ResponseSchemaDefinition{
+	assets, err := schemaAssetFS()
+	if err != nil {
+		return llm.ResponseSchema{}, err
+	}
+	return llm.LoadResponseSchema(assets, llm.ResponseSchemaDefinition{
 		Key:       ResponseSchemaKey,
 		ID:        ResponseSchemaID,
 		Version:   SchemaVersion,
@@ -27,5 +43,13 @@ func LoadResponseSchema() (llm.ResponseSchema, error) {
 // RegisterSchemaAssets makes the shared private response schema available to
 // prompt preparation. A family registrar can register it once for all consumers.
 func RegisterSchemaAssets(registry *llm.AssetRegistry) error {
-	return registry.RegisterSchemaFS(embeddedAssets, "assets/schemas")
+	assets, err := schemaAssetFS()
+	if err != nil {
+		return err
+	}
+	schemas, err := fs.Sub(assets, "schemas")
+	if err != nil {
+		return fmt.Errorf("scope entity reconciliation schemas: %w", err)
+	}
+	return registry.RegisterSchemaFS(schemas, ".")
 }