Harden diagnostic handling and warning presentation

internal/modules/dnd/validate/npcoccurrences/source_relatedness/validator.go

@@ -50,18 +50,18 @@ func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationReq
 		}
 		citedTexts[index] = citedText
 	}
-	warnings := make([]diagnostics.Finding, 0)
+	findings := make([]diagnostics.Finding, 0)
 	for index, occurrence := range req.Value.Occurrences {
 		if shared.ContainsTokenSequence(citedTexts[index], occurrence.Name) {
 			continue
 		}
-		warnings = append(warnings, diagnostics.Finding{
+		findings = append(findings, diagnostics.Finding{
 			Scope:      fmt.Sprintf("occurrences[%d]", index),
 			ReasonCode: ReasonCode,
 			Message:    fmt.Sprintf("NPC occurrence name %s was not found in cited source text", diagnostics.Quote(occurrence.Name)),
 		})
 	}
-	return diagnostics.DataQualityResult(warnings)
+	return diagnostics.DataQualityResult(findings)
 }
 
 func Spec() pipeline.ValidatorSpec {

internal/modules/dnd/validate/npcoccurrences/source_relatedness/validator_test.go

@@ -50,7 +50,7 @@ func TestValidatorDefersMalformedShapeAndInvalidRanges(t *testing.T) {
 	}
 }
 
-func TestValidatorBoundsWarnings(t *testing.T) {
+func TestValidatorBoundsAdvisories(t *testing.T) {
 	count := contracts.MaxDiagnosticSamples + 5
 	occurrences := make([]dnd.NPCOccurrence, count)
 	for index := range occurrences {