Harden diagnostic handling and warning presentation

internal/modules/dnd/validate/enemyevents/source_relatedness/validator.go

@@ -42,13 +42,13 @@ func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationReq
 	if err != nil {
 		return contracts.ValidationResult{Approved: true}, nil
 	}
-	warnings := make([]diagnostics.Finding, 0)
+	findings := make([]diagnostics.Finding, 0)
 	for eventIndex, event := range req.Value.Events {
 		citedText, err := resolver.CitedText(event.SourceRefs)
 		if err != nil || shared.ContainsTokenSequence(citedText, event.Name) {
 			continue
 		}
-		warnings = append(warnings, diagnostics.Finding{
+		findings = append(findings, diagnostics.Finding{
 			Scope:      fmt.Sprintf("events[%d]", eventIndex),
 			ReasonCode: ReasonCode,
 			Message: diagnostics.Aggregate("enemy event subject not near source", []string{
@@ -56,7 +56,7 @@ func (v *Validator) Validate(_ context.Context, req contracts.TypedValidationReq
 			}),
 		})
 	}
-	return diagnostics.DataQualityResult(warnings)
+	return diagnostics.DataQualityResult(findings)
 }
 
 func Spec() pipeline.ValidatorSpec {