Centralize NPC LLM assets

internal/modules/dnd/normalize/npcs/assets.go

@@ -1,6 +0,0 @@
-package npcs
-
-import "embed"
-
-//go:embed assets/prompts/*.yaml assets/prompts/*.md
-var embeddedAssets embed.FS

internal/modules/dnd/normalize/npcs/assets/prompts/candidates.md

@@ -1,4 +0,0 @@
-The supplied NPC candidates are below. Use only these display names in the
-response.
-
-{{ input "candidates" }}

internal/modules/dnd/normalize/npcs/assets/prompts/dnd.npcs.normalize.yaml

@@ -1,30 +0,0 @@
-id: dnd.npcs.normalize
-version: "v1"
-default_profile: dnd-extraction
-inputs:
-  - name: candidates
-    required: true
-    content_type: application/json
-  - name: transcript
-    required: true
-    content_type: application/json
-messages:
-  - role: system
-    content_file: ./sharedassets/common-dnd-system.md
-  - role: user
-    content_file: ./task.md
-  - role: user
-    content_file: ./sharedassets/common-dnd-entity-reconciliation.md
-    cache_control:
-      type: ephemeral
-  - role: user
-    content_file: ./candidates.md
-  - role: user
-    content_file: ./sharedassets/common-dnd-transcript.md
-    cache_control:
-      type: ephemeral
-output:
-  format: json
-  validation_mode: json_schema
-  schema_path: dnd_entity_reconcile_llm.v1.json
-  repair_attempts: 0

internal/modules/dnd/normalize/npcs/assets/prompts/task.md

@@ -1,13 +0,0 @@
-Review NPC candidates and their cited transcript context to identify aliases
-that refer to the same individual. Propose only groups supported by the
-transcript, and preserve distinct individuals even when their names are
-similar.
-
-For every accepted group, choose as canonical only a supplied candidate from
-that evidence-supported duplicate group. Prefer a complete, stable proper name
-over an abbreviation. Prefer an unadorned proper name over that name plus a
-contextual class, role, title, or relationship descriptor unless the transcript
-establishes the descriptor as part of the person's name. A longer display name
-is not inherently more canonical; for example, do not prefer `Captain Aria`
-over `Aria` solely because it includes the contextual title `Captain`. Do not
-invent, edit, or combine display names.

internal/modules/dnd/normalize/npcs/prompt_assets.go

@@ -2,8 +2,10 @@ package npcs
 
 import (
 	"fmt"
+	"io/fs"
 	"sync"
 
+	rootassets "gitea.maximumdirect.net/eric/notarius/assets"
 	"gitea.maximumdirect.net/eric/notarius/internal/framework/llm"
 	"gitea.maximumdirect.net/eric/notarius/internal/framework/promptfs"
 	"gitea.maximumdirect.net/eric/notarius/internal/modules/dnd/shared"
@@ -14,9 +16,9 @@ const promptAssetRoot = "assets/prompts"
 var promptAssetManifest = shared.PromptAssetManifest{
 	ModuleDir: PromptID,
 	ModuleFiles: []promptfs.ModulePromptFile{
-		{Name: "dnd.npcs.normalize.yaml", Path: "assets/prompts/dnd.npcs.normalize.yaml"},
-		{Name: "task.md", Path: "assets/prompts/task.md"},
-		{Name: "candidates.md", Path: "assets/prompts/candidates.md"},
+		{Name: "dnd.npcs.normalize.yaml", Path: "prompts/dnd.npcs.normalize.yaml"},
+		{Name: "task.md", Path: "prompts/task.md"},
+		{Name: "candidates.md", Path: "prompts/candidates.md"},
 	},
 	SharedFiles: []string{
 		"common-dnd-system.md",
@@ -25,8 +27,20 @@ var promptAssetManifest = shared.PromptAssetManifest{
 	},
 }
 
+func moduleAssetFS() (fs.FS, error) {
+	assets, err := fs.Sub(rootassets.FS(), "dnd/npcs/normalize")
+	if err != nil {
+		return nil, fmt.Errorf("scope NPC normalization assets: %w", err)
+	}
+	return assets, nil
+}
+
 func RegisterPromptAssets(registry *llm.AssetRegistry) error {
-	promptFS, err := promptAssetManifest.PromptFS(embeddedAssets)
+	assets, err := moduleAssetFS()
+	if err != nil {
+		return err
+	}
+	promptFS, err := promptAssetManifest.PromptFS(assets)
 	if err != nil {
 		return fmt.Errorf("prepare NPC normalization prompt assets: %w", err)
 	}
@@ -35,7 +49,12 @@ func RegisterPromptAssets(registry *llm.AssetRegistry) error {
 
 func promptAssetMetadata() (string, error) {
 	promptAssetHashOnce.Do(func() {
-		promptAssetHash, promptAssetHashErr = promptAssetManifest.Hash(embeddedAssets)
+		assets, err := moduleAssetFS()
+		if err != nil {
+			promptAssetHashErr = err
+			return
+		}
+		promptAssetHash, promptAssetHashErr = promptAssetManifest.Hash(assets)
 	})
 	return promptAssetHash, promptAssetHashErr
 }